summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2024-01-02 13:22:39 (GMT)
committerGitHub <noreply@github.com>2024-01-02 13:22:39 (GMT)
commit1c381ec4edfa6364474fa795a93ed1cccb6df903 (patch)
treedfe16b94545826e1399114722f0e6aa329408f3c
parent9beb56594db36eab985f1fa05385eb34fae178ac (diff)
downloadcpython-1c381ec4edfa6364474fa795a93ed1cccb6df903.zip
cpython-1c381ec4edfa6364474fa795a93ed1cccb6df903.tar.gz
cpython-1c381ec4edfa6364474fa795a93ed1cccb6df903.tar.bz2
[3.11] gh-113602: Bail out when the parser tries to override existing errors (GH-113607) (#113653)
gh-113602: Bail out when the parser tries to override existing errors (GH-113607) (cherry picked from commit 9ed36d533ab8b256f0a589b5be6d7a2fdcf4aff2) Signed-off-by: Pablo Galindo <pablogsal@gmail.com> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
-rw-r--r--Lib/test/test_syntax.py2
-rw-r--r--Misc/NEWS.d/next/Core and Builtins/2024-01-01-00-07-02.gh-issue-113602.cWuTzk.rst2
-rw-r--r--Parser/pegen_errors.c4
3 files changed, 8 insertions, 0 deletions
diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py
index 050d084..9dd0f74 100644
--- a/Lib/test/test_syntax.py
+++ b/Lib/test/test_syntax.py
@@ -2143,6 +2143,8 @@ func(
"""
self._check_error(code, "parenthesis '\\)' does not match opening parenthesis '\\['")
+ self._check_error("match y:\n case e(e=v,v,", " was never closed")
+
# Examples with dencodings
s = b'# coding=latin\n(aaaaaaaaaaaaaaaaa\naaaaaaaaaaa\xb5'
self._check_error(s, r"'\(' was never closed")
diff --git a/Misc/NEWS.d/next/Core and Builtins/2024-01-01-00-07-02.gh-issue-113602.cWuTzk.rst b/Misc/NEWS.d/next/Core and Builtins/2024-01-01-00-07-02.gh-issue-113602.cWuTzk.rst
new file mode 100644
index 0000000..5e06465
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2024-01-01-00-07-02.gh-issue-113602.cWuTzk.rst
@@ -0,0 +1,2 @@
+Fix an error that was causing the parser to try to overwrite existing errors
+and crashing in the process. Patch by Pablo Galindo
diff --git a/Parser/pegen_errors.c b/Parser/pegen_errors.c
index fb9fa29..ccb0d37 100644
--- a/Parser/pegen_errors.c
+++ b/Parser/pegen_errors.c
@@ -299,6 +299,10 @@ _PyPegen_raise_error_known_location(Parser *p, PyObject *errtype,
Py_ssize_t end_lineno, Py_ssize_t end_col_offset,
const char *errmsg, va_list va)
{
+ // Bail out if we already have an error set.
+ if (p->error_indicator && PyErr_Occurred()) {
+ return NULL;
+ }
PyObject *value = NULL;
PyObject *errstr = NULL;
PyObject *error_line = NULL;