summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2018-02-19 04:14:27 (GMT)
committerGitHub <noreply@github.com>2018-02-19 04:14:27 (GMT)
commit2a93fae8b5b26cbfef6c8afb702d305d3919de85 (patch)
treede25cef9ad59e7298fdb8a08e06ec05fca283c20
parent5c81ed49412e41a671283cdb4c297dab52f5b7c5 (diff)
downloadcpython-2a93fae8b5b26cbfef6c8afb702d305d3919de85.zip
cpython-2a93fae8b5b26cbfef6c8afb702d305d3919de85.tar.gz
cpython-2a93fae8b5b26cbfef6c8afb702d305d3919de85.tar.bz2
Improve error message for "setup.py upload" without dist files (GH-21060)
(cherry picked from commit 08a6926b2584040fe3c3f06263b0b5f1fbbdc24c) Co-authored-by: Éric Araujo <merwok@netwok.org>
-rw-r--r--Lib/distutils/command/upload.py3
-rw-r--r--Misc/NEWS.d/next/Library/2018-02-17-19-20-19.bpo-21060.S1Z-x6.rst3
2 files changed, 5 insertions, 1 deletions
diff --git a/Lib/distutils/command/upload.py b/Lib/distutils/command/upload.py
index f7752f9..32dda35 100644
--- a/Lib/distutils/command/upload.py
+++ b/Lib/distutils/command/upload.py
@@ -57,7 +57,8 @@ class upload(PyPIRCCommand):
def run(self):
if not self.distribution.dist_files:
- msg = "No dist file created in earlier command"
+ msg = ("Must create and upload files in one command "
+ "(e.g. setup.py sdist upload)")
raise DistutilsOptionError(msg)
for command, pyversion, filename in self.distribution.dist_files:
self.upload_file(command, pyversion, filename)
diff --git a/Misc/NEWS.d/next/Library/2018-02-17-19-20-19.bpo-21060.S1Z-x6.rst b/Misc/NEWS.d/next/Library/2018-02-17-19-20-19.bpo-21060.S1Z-x6.rst
new file mode 100644
index 0000000..4e0a113
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2018-02-17-19-20-19.bpo-21060.S1Z-x6.rst
@@ -0,0 +1,3 @@
+Rewrite confusing message from setup.py upload from
+"No dist file created in earlier command" to the more helpful
+"Must create and upload files in one command".