diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2021-09-29 13:54:47 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-29 13:54:47 (GMT) |
| commit | 456d6d9fefac828c19fc1b562f6301f00965fe59 (patch) | |
| tree | 0d3a5478c4a404e53780a0fab36e066c85cdd5dd | |
| parent | 8344fef7dc2cf0ef8a33449df9c165247fb37a3a (diff) | |
| download | cpython-456d6d9fefac828c19fc1b562f6301f00965fe59.zip cpython-456d6d9fefac828c19fc1b562f6301f00965fe59.tar.gz cpython-456d6d9fefac828c19fc1b562f6301f00965fe59.tar.bz2 | |
bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) (GH-28622)
(cherry picked from commit f4b94b1f57827083990272b5f282aa1493ae2bf4)
Co-authored-by: Steve Dower <steve.dower@python.org>
| -rw-r--r-- | Misc/NEWS.d/next/Build/2021-09-16-18-00-43.bpo-45220.TgbkvW.rst | 3 | ||||
| -rw-r--r-- | PCbuild/python.props | 3 |
2 files changed, 6 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Build/2021-09-16-18-00-43.bpo-45220.TgbkvW.rst b/Misc/NEWS.d/next/Build/2021-09-16-18-00-43.bpo-45220.TgbkvW.rst new file mode 100644 index 0000000..8bbd634 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2021-09-16-18-00-43.bpo-45220.TgbkvW.rst @@ -0,0 +1,3 @@ +Avoid building with the Windows 11 SDK previews automatically. This may be +overridden by setting the ``DefaultWindowsSDKVersion`` environment variable +before building. diff --git a/PCbuild/python.props b/PCbuild/python.props index 295b729..0d25e51 100644 --- a/PCbuild/python.props +++ b/PCbuild/python.props @@ -106,6 +106,9 @@ <!-- Sometimes the version in the registry has to .0 suffix, and sometimes it doesn't. Check and add it --> <_RegistryVersion Condition="$(_RegistryVersion) != '' and !$(_RegistryVersion.EndsWith('.0'))">$(_RegistryVersion).0</_RegistryVersion> + <!-- Avoid upgrading to Windows 11 SDK for now, but assume the latest Win10 SDK is installed --> + <_RegistryVersion Condition="$([System.Version]::Parse($(_RegistryVersion))) >= $([System.Version]::Parse(`10.0.22000.0`))">10.0.19041.0</_RegistryVersion> + <!-- The minimum allowed SDK version to use for building --> <DefaultWindowsSDKVersion>10.0.10586.0</DefaultWindowsSDKVersion> <DefaultWindowsSDKVersion Condition="$([System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))">$(_RegistryVersion)</DefaultWindowsSDKVersion> |