summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDong-hee Na <donghee.na@python.org>2021-04-30 19:01:55 (GMT)
committerGitHub <noreply@github.com>2021-04-30 19:01:55 (GMT)
commit6143fcdf8bfe54c24e3081bcee423f4d51f35c4e (patch)
treee9bb5360522c4451419f162c42199be5510b8fb7
parent6689e45dfee75d756c540ff0946ebf0ae8847f43 (diff)
downloadcpython-6143fcdf8bfe54c24e3081bcee423f4d51f35c4e.zip
cpython-6143fcdf8bfe54c24e3081bcee423f4d51f35c4e.tar.gz
cpython-6143fcdf8bfe54c24e3081bcee423f4d51f35c4e.tar.bz2
bpo-43979: Remove unnecessary operation from urllib.parse.parse_qsl (GH-25756)
Automerge-Triggered-By: GH:gpshead
-rw-r--r--Lib/urllib/parse.py3
-rw-r--r--Misc/NEWS.d/next/Library/2021-05-01-01-36-51.bpo-43979.43oJ9L.rst2
2 files changed, 3 insertions, 2 deletions
diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
index c11c695..4249163 100644
--- a/Lib/urllib/parse.py
+++ b/Lib/urllib/parse.py
@@ -752,9 +752,8 @@ def parse_qsl(qs, keep_blank_values=False, strict_parsing=False,
if max_num_fields < num_fields:
raise ValueError('Max number of fields exceeded')
- pairs = [s1 for s1 in qs.split(separator)]
r = []
- for name_value in pairs:
+ for name_value in qs.split(separator):
if not name_value and not strict_parsing:
continue
nv = name_value.split('=', 1)
diff --git a/Misc/NEWS.d/next/Library/2021-05-01-01-36-51.bpo-43979.43oJ9L.rst b/Misc/NEWS.d/next/Library/2021-05-01-01-36-51.bpo-43979.43oJ9L.rst
new file mode 100644
index 0000000..d5d1caa
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2021-05-01-01-36-51.bpo-43979.43oJ9L.rst
@@ -0,0 +1,2 @@
+Removed an unnecessary list comprehension before looping from
+:func:`urllib.parse.parse_qsl`. Patch by Christoph Zwerschke and Dong-hee Na.