diff options
author | Antoine Pitrou <solipsis@pitrou.net> | 2012-01-25 14:38:32 (GMT) |
---|---|---|
committer | Antoine Pitrou <solipsis@pitrou.net> | 2012-01-25 14:38:32 (GMT) |
commit | 6f25d75f25ae83285e3c3e95ca279e49ce5da691 (patch) | |
tree | 4ce44dc428ac68d5134d6819f647a53e3fbfacdd | |
parent | b744cef654d037cee1c6c07d9c0b6ff073fd5604 (diff) | |
download | cpython-6f25d75f25ae83285e3c3e95ca279e49ce5da691.zip cpython-6f25d75f25ae83285e3c3e95ca279e49ce5da691.tar.gz cpython-6f25d75f25ae83285e3c3e95ca279e49ce5da691.tar.bz2 |
Remove debug output, fix assert (hopefully) and exercise signedness issues a bit more.
-rw-r--r-- | Lib/test/test_import.py | 2 | ||||
-rw-r--r-- | Python/import.c | 9 |
2 files changed, 3 insertions, 8 deletions
diff --git a/Lib/test/test_import.py b/Lib/test/test_import.py index 412e6b8..e426290 100644 --- a/Lib/test/test_import.py +++ b/Lib/test/test_import.py @@ -288,7 +288,7 @@ class ImportTests(unittest.TestCase): with open(source, 'w') as f: pass try: - os.utime(source, (2 ** 33, 2 ** 33)) + os.utime(source, (2 ** 33 - 5, 2 ** 33 - 5)) except OverflowError: self.skipTest("cannot set modification time to large integer") except OSError as e: diff --git a/Python/import.c b/Python/import.c index f9f3cdb..2cac9b5 100644 --- a/Python/import.c +++ b/Python/import.c @@ -905,14 +905,9 @@ write_compiled_module(PyCodeObject *co, char *cpathname, struct stat *srcstat) (void) unlink(cpathname); return; } - /* Now write the true mtime */ + /* Now write the true mtime (as a 32-bit field) */ fseek(fp, 4L, 0); - if (mtime >= LONG_MAX) { - fprintf(stderr, "** sizes=(%ld, %ld), mtime=%I64d >= %ld\n", sizeof(time_t), sizeof(srcstat->st_mtime), mtime, LONG_MAX); - assert(0); - /* can't get here */ - } - assert(mtime < LONG_MAX); + assert(mtime <= 0xFFFFFFFF); PyMarshal_WriteLongToFile((long)mtime, fp, Py_MARSHAL_VERSION); fflush(fp); fclose(fp); |