summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikita Sobolev <mail@sobolevn.me>2022-10-05 22:00:13 (GMT)
committerGitHub <noreply@github.com>2022-10-05 22:00:13 (GMT)
commit8c6ced36abb9ccc5dc6c8def1b376484685255c5 (patch)
tree8b783ee98ac092a5f8983daef64451cf24d04cab
parenta8d50aeada9b6e2be1a4b6e498002c11b783a32a (diff)
downloadcpython-8c6ced36abb9ccc5dc6c8def1b376484685255c5.zip
cpython-8c6ced36abb9ccc5dc6c8def1b376484685255c5.tar.gz
cpython-8c6ced36abb9ccc5dc6c8def1b376484685255c5.tar.bz2
[3.11] gh-96587: Raise `SyntaxError` for PEP654 on older `feature_version` (GH-96588) (#96591)
(cherry picked from commit 2c7d2e8d46164efb6e27a64081d8e949f6876515) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
-rw-r--r--Grammar/python.gram4
-rw-r--r--Lib/test/test_ast.py9
-rw-r--r--Misc/NEWS.d/next/Core and Builtins/2022-09-05-19-20-44.gh-issue-96587.bVxhX2.rst2
-rw-r--r--Parser/parser.c2
4 files changed, 15 insertions, 2 deletions
diff --git a/Grammar/python.gram b/Grammar/python.gram
index d4df78b..51f846a 100644
--- a/Grammar/python.gram
+++ b/Grammar/python.gram
@@ -412,7 +412,9 @@ try_stmt[stmt_ty]:
| invalid_try_stmt
| 'try' &&':' b=block f=finally_block { _PyAST_Try(b, NULL, NULL, f, EXTRA) }
| 'try' &&':' b=block ex[asdl_excepthandler_seq*]=except_block+ el=[else_block] f=[finally_block] { _PyAST_Try(b, ex, el, f, EXTRA) }
- | 'try' &&':' b=block ex[asdl_excepthandler_seq*]=except_star_block+ el=[else_block] f=[finally_block] { _PyAST_TryStar(b, ex, el, f, EXTRA) }
+ | 'try' &&':' b=block ex[asdl_excepthandler_seq*]=except_star_block+ el=[else_block] f=[finally_block] {
+ CHECK_VERSION(stmt_ty, 11, "Exception groups are",
+ _PyAST_TryStar(b, ex, el, f, EXTRA)) }
# Except statement
diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py
index 7275e15..90ad6af 100644
--- a/Lib/test/test_ast.py
+++ b/Lib/test/test_ast.py
@@ -771,6 +771,15 @@ class AST_Tests(unittest.TestCase):
with self.assertRaises(SyntaxError):
ast.parse('(x := 0)', feature_version=(3, 7))
+ def test_exception_groups_feature_version(self):
+ code = dedent('''
+ try: ...
+ except* Exception: ...
+ ''')
+ ast.parse(code)
+ with self.assertRaises(SyntaxError):
+ ast.parse(code, feature_version=(3, 10))
+
def test_constant_as_name(self):
for constant in "True", "False", "None":
expr = ast.Expression(ast.Name(constant, ast.Load()))
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-09-05-19-20-44.gh-issue-96587.bVxhX2.rst b/Misc/NEWS.d/next/Core and Builtins/2022-09-05-19-20-44.gh-issue-96587.bVxhX2.rst
new file mode 100644
index 0000000..37e9dcb
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2022-09-05-19-20-44.gh-issue-96587.bVxhX2.rst
@@ -0,0 +1,2 @@
+Correctly raise ``SyntaxError`` on exception groups (:pep:`654`) on python
+versions prior to 3.11
diff --git a/Parser/parser.c b/Parser/parser.c
index e13dbe0..3fc12e5 100644
--- a/Parser/parser.c
+++ b/Parser/parser.c
@@ -6970,7 +6970,7 @@ try_stmt_rule(Parser *p)
UNUSED(_end_lineno); // Only used by EXTRA macro
int _end_col_offset = _token->end_col_offset;
UNUSED(_end_col_offset); // Only used by EXTRA macro
- _res = _PyAST_TryStar ( b , ex , el , f , EXTRA );
+ _res = CHECK_VERSION ( stmt_ty , 11 , "Exception groups are" , _PyAST_TryStar ( b , ex , el , f , EXTRA ) );
if (_res == NULL && PyErr_Occurred()) {
p->error_indicator = 1;
p->level--;