summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Curtin <brian.curtin@gmail.com>2010-03-31 03:14:27 (GMT)
committerBrian Curtin <brian.curtin@gmail.com>2010-03-31 03:14:27 (GMT)
commita5d9679ef3ef6cd5d09a17904ce5bf60d3fe247f (patch)
tree9ee5308cdb9d48a019e4c64be47eb2323e04053c
parent65014f151a6018ba469ef8c8a9161294228b9304 (diff)
downloadcpython-a5d9679ef3ef6cd5d09a17904ce5bf60d3fe247f.zip
cpython-a5d9679ef3ef6cd5d09a17904ce5bf60d3fe247f.tar.gz
cpython-a5d9679ef3ef6cd5d09a17904ce5bf60d3fe247f.tar.bz2
Merged revisions 79518 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk ........ r79518 | brian.curtin | 2010-03-30 22:10:21 -0500 (Tue, 30 Mar 2010) | 2 lines Fix #8225. xml.etree was displaying an incorrect link when viewed in help. ........
-rwxr-xr-xLib/pydoc.py3
-rw-r--r--Lib/test/test_pydoc.py6
2 files changed, 8 insertions, 1 deletions
diff --git a/Lib/pydoc.py b/Lib/pydoc.py
index e983212..03c0d09 100755
--- a/Lib/pydoc.py
+++ b/Lib/pydoc.py
@@ -356,7 +356,8 @@ class Doc:
'marshal', 'posix', 'signal', 'sys',
'thread', 'zipimport') or
(file.startswith(basedir) and
- not file.startswith(os.path.join(basedir, 'site-packages'))))):
+ not file.startswith(os.path.join(basedir, 'site-packages')))) and
+ object.__name__ not in ('xml.etree')):
if docloc.startswith("http://"):
docloc = "%s/%s" % (docloc.rstrip("/"), object.__name__)
else:
diff --git a/Lib/test/test_pydoc.py b/Lib/test/test_pydoc.py
index 168c4d1..d23de74 100644
--- a/Lib/test/test_pydoc.py
+++ b/Lib/test/test_pydoc.py
@@ -7,6 +7,7 @@ import re
import pydoc
import inspect
import unittest
+import xml.etree
import test.test_support
from contextlib import contextmanager
from test.test_support import TESTFN, forget, rmtree, EnvironmentVarGuard
@@ -236,6 +237,11 @@ class PyDocDocTest(unittest.TestCase):
print_diffs(expected_text, result)
self.fail("outputs are not equal, see diff above")
+ def test_issue8225(self):
+ # Test issue8225 to ensure no doc link appears for xml.etree
+ result, doc_loc = get_pydoc_text(xml.etree)
+ self.assertEqual(doc_loc, "", "MODULE DOCS incorrectly includes a link")
+
def test_not_here(self):
missing_module = "test.i_am_not_here"
result = run_pydoc(missing_module)