summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIrit Katriel <1055913+iritkatriel@users.noreply.github.com>2024-08-28 17:41:22 (GMT)
committerGitHub <noreply@github.com>2024-08-28 17:41:22 (GMT)
commitd379a92ddce55d3b89956fb556fb9ed654de0bf0 (patch)
tree0f585f730e109ef1fe9a0b9dc4af1ea000b199a5
parent19a1f187402f557cf193c408ebba3ede1ce9f893 (diff)
downloadcpython-d379a92ddce55d3b89956fb556fb9ed654de0bf0.zip
cpython-d379a92ddce55d3b89956fb556fb9ed654de0bf0.tar.gz
cpython-d379a92ddce55d3b89956fb556fb9ed654de0bf0.tar.bz2
[3.13] gh-123142: fix too wide source location of GET_ITER/GET_AITER (GH-123420). (#123435)
(cherry picked from commit 61bef6245c4a32bf430d684ede8603f423d63284)
-rw-r--r--Lib/test/support/__init__.py5
-rw-r--r--Lib/test/test_dictcomps.py7
-rw-r--r--Lib/test/test_iter.py8
-rw-r--r--Lib/test/test_listcomps.py7
-rw-r--r--Lib/test/test_setcomps.py7
-rw-r--r--Python/compile.c15
6 files changed, 40 insertions, 9 deletions
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py
index 6dd0e9d..e00d3f8 100644
--- a/Lib/test/support/__init__.py
+++ b/Lib/test/support/__init__.py
@@ -2676,14 +2676,17 @@ def initialized_with_pyrepl():
class BrokenIter:
- def __init__(self, init_raises=False, next_raises=False):
+ def __init__(self, init_raises=False, next_raises=False, iter_raises=False):
if init_raises:
1/0
self.next_raises = next_raises
+ self.iter_raises = iter_raises
def __next__(self):
if self.next_raises:
1/0
def __iter__(self):
+ if self.iter_raises:
+ 1/0
return self
diff --git a/Lib/test/test_dictcomps.py b/Lib/test/test_dictcomps.py
index e9df296..26b56da 100644
--- a/Lib/test/test_dictcomps.py
+++ b/Lib/test/test_dictcomps.py
@@ -145,8 +145,15 @@ class DictComprehensionTest(unittest.TestCase):
except Exception as e:
return e
+ def iter_raises():
+ try:
+ {x:x for x in BrokenIter(iter_raises=True)}
+ except Exception as e:
+ return e
+
for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
+ (iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
diff --git a/Lib/test/test_iter.py b/Lib/test/test_iter.py
index 502856e..1b9f3cf 100644
--- a/Lib/test/test_iter.py
+++ b/Lib/test/test_iter.py
@@ -1163,8 +1163,16 @@ class TestCase(unittest.TestCase):
except Exception as e:
return e
+ def iter_raises():
+ try:
+ for x in BrokenIter(iter_raises=True):
+ pass
+ except Exception as e:
+ return e
+
for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
+ (iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
diff --git a/Lib/test/test_listcomps.py b/Lib/test/test_listcomps.py
index 467e0c5..45644d6 100644
--- a/Lib/test/test_listcomps.py
+++ b/Lib/test/test_listcomps.py
@@ -730,8 +730,15 @@ class ListComprehensionTest(unittest.TestCase):
except Exception as e:
return e
+ def iter_raises():
+ try:
+ [x for x in BrokenIter(iter_raises=True)]
+ except Exception as e:
+ return e
+
for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
+ (iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
diff --git a/Lib/test/test_setcomps.py b/Lib/test/test_setcomps.py
index ba4173c..0bb02ef 100644
--- a/Lib/test/test_setcomps.py
+++ b/Lib/test/test_setcomps.py
@@ -168,8 +168,15 @@ class SetComprehensionTest(unittest.TestCase):
except Exception as e:
return e
+ def iter_raises():
+ try:
+ {x for x in BrokenIter(iter_raises=True)}
+ except Exception as e:
+ return e
+
for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
+ (iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
diff --git a/Python/compile.c b/Python/compile.c
index a8b4bf1..c331271 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -3160,7 +3160,7 @@ compiler_async_for(struct compiler *c, stmt_ty s)
NEW_JUMP_TARGET_LABEL(c, end);
VISIT(c, expr, s->v.AsyncFor.iter);
- ADDOP(c, loc, GET_AITER);
+ ADDOP(c, LOC(s->v.AsyncFor.iter), GET_AITER);
USE_LABEL(c, start);
RETURN_IF_ERROR(compiler_push_fblock(c, loc, FOR_LOOP, start, end, NULL));
@@ -5484,7 +5484,7 @@ compiler_async_comprehension_generator(struct compiler *c, location loc,
else {
/* Sub-iter - calculate on the fly */
VISIT(c, expr, gen->iter);
- ADDOP(c, loc, GET_AITER);
+ ADDOP(c, LOC(gen->iter), GET_AITER);
}
}
@@ -5774,15 +5774,14 @@ pop_inlined_comprehension_state(struct compiler *c, location loc,
}
static inline int
-compiler_comprehension_iter(struct compiler *c, location loc,
- comprehension_ty comp)
+compiler_comprehension_iter(struct compiler *c, comprehension_ty comp)
{
VISIT(c, expr, comp->iter);
if (comp->is_async) {
- ADDOP(c, loc, GET_AITER);
+ ADDOP(c, LOC(comp->iter), GET_AITER);
}
else {
- ADDOP(c, loc, GET_ITER);
+ ADDOP(c, LOC(comp->iter), GET_ITER);
}
return SUCCESS;
}
@@ -5808,7 +5807,7 @@ compiler_comprehension(struct compiler *c, expr_ty e, int type,
outermost = (comprehension_ty) asdl_seq_GET(generators, 0);
if (is_inlined) {
- if (compiler_comprehension_iter(c, loc, outermost)) {
+ if (compiler_comprehension_iter(c, outermost)) {
goto error;
}
if (push_inlined_comprehension_state(c, loc, entry, &inline_state)) {
@@ -5894,7 +5893,7 @@ compiler_comprehension(struct compiler *c, expr_ty e, int type,
}
Py_CLEAR(co);
- if (compiler_comprehension_iter(c, loc, outermost)) {
+ if (compiler_comprehension_iter(c, outermost)) {
goto error;
}