summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2022-04-20 01:20:03 (GMT)
committerGitHub <noreply@github.com>2022-04-20 01:20:03 (GMT)
commite08d32381d749bc4f3e4302e067076fa8c4e0661 (patch)
tree011d0d716589373c978f7ec7f18fdf39da9c5e62
parent68caef8f8e4c127c188a741fbebdf4cf077b0f93 (diff)
downloadcpython-e08d32381d749bc4f3e4302e067076fa8c4e0661.zip
cpython-e08d32381d749bc4f3e4302e067076fa8c4e0661.tar.gz
cpython-e08d32381d749bc4f3e4302e067076fa8c4e0661.tar.bz2
gh-87497: Document that urllib.request sends headers in camel case (GH-24661) (#91517)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 325d6f50357474c7d9fd2475be0e2481f7ae0476) Co-authored-by: Alix Lourme <alix.lourme@gmail.com>
-rw-r--r--Doc/library/urllib.request.rst1
-rw-r--r--Lib/test/test_urllib2_localnet.py9
2 files changed, 10 insertions, 0 deletions
diff --git a/Doc/library/urllib.request.rst b/Doc/library/urllib.request.rst
index 659a363..9573683 100644
--- a/Doc/library/urllib.request.rst
+++ b/Doc/library/urllib.request.rst
@@ -218,6 +218,7 @@ The following classes are provided:
(X11; U; Linux i686) Gecko/20071127 Firefox/2.0.0.11"``, while
:mod:`urllib`'s default user agent string is
``"Python-urllib/2.6"`` (on Python 2.6).
+ All header keys are sent in camel case.
An appropriate ``Content-Type`` header should be included if the *data*
argument is present. If this header has not been provided and *data*
diff --git a/Lib/test/test_urllib2_localnet.py b/Lib/test/test_urllib2_localnet.py
index 1b2baf2..fe2ff81 100644
--- a/Lib/test/test_urllib2_localnet.py
+++ b/Lib/test/test_urllib2_localnet.py
@@ -614,6 +614,15 @@ class TestUrlopen(unittest.TestCase):
pass
self.assertEqual(handler.headers_received["Range"], "bytes=20-39")
+ def test_sending_headers_camel(self):
+ handler = self.start_server()
+ req = urllib.request.Request("http://localhost:%s/" % handler.port,
+ headers={"X-SoMe-hEader": "foobar"})
+ with urllib.request.urlopen(req):
+ pass
+ self.assertIn("X-Some-Header", handler.headers_received.keys())
+ self.assertNotIn("X-SoMe-hEader", handler.headers_received.keys())
+
def test_basic(self):
handler = self.start_server()
with urllib.request.urlopen("http://localhost:%s" % handler.port) as open_url: