diff options
| author | Benjamin Peterson <benjamin@python.org> | 2012-05-08 13:22:24 (GMT) |
|---|---|---|
| committer | Benjamin Peterson <benjamin@python.org> | 2012-05-08 13:22:24 (GMT) |
| commit | f1ae5cf5c7f17e1103735060457fccd5844d21c9 (patch) | |
| tree | 0565592e8c1681d71830eb648d4b92a6d83ffefa | |
| parent | f1aeef27b3e948564b84ec212bfbe7e753de4212 (diff) | |
| download | cpython-f1ae5cf5c7f17e1103735060457fccd5844d21c9.zip cpython-f1ae5cf5c7f17e1103735060457fccd5844d21c9.tar.gz cpython-f1ae5cf5c7f17e1103735060457fccd5844d21c9.tar.bz2 | |
fix possible refleak (closes #14752)
| -rw-r--r-- | Objects/typeobject.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 08e5775..3bb0459 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -3565,6 +3565,7 @@ add_methods(PyTypeObject *type, PyMethodDef *meth) for (; meth->ml_name != NULL; meth++) { PyObject *descr; + int err; if (PyDict_GetItemString(dict, meth->ml_name) && !(meth->ml_flags & METH_COEXIST)) continue; @@ -3588,9 +3589,10 @@ add_methods(PyTypeObject *type, PyMethodDef *meth) } if (descr == NULL) return -1; - if (PyDict_SetItemString(dict, meth->ml_name, descr) < 0) - return -1; + err = PyDict_SetItemString(dict, meth->ml_name, descr); Py_DECREF(descr); + if (err < 0) + return -1; } return 0; } |