summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorQuincey Koziol <koziol@hdfgroup.org>2017-03-22 17:54:25 (GMT)
committerQuincey Koziol <koziol@hdfgroup.org>2017-03-22 17:54:25 (GMT)
commit46c9ab600de491657520897322b75659c3bdfb5f (patch)
treeec3ba075637c098d0354b173c711cc4a3163cbb5
parent161a3b95165957b772e56b6f84fe7923fd3ddd11 (diff)
downloadhdf5-46c9ab600de491657520897322b75659c3bdfb5f.zip
hdf5-46c9ab600de491657520897322b75659c3bdfb5f.tar.gz
hdf5-46c9ab600de491657520897322b75659c3bdfb5f.tar.bz2
Minor style cleanups
-rw-r--r--src/H5AC.c3
-rw-r--r--src/H5Cquery.c5
-rw-r--r--src/H5F.c7
-rw-r--r--tools/src/misc/h5clear.c1
4 files changed, 9 insertions, 7 deletions
diff --git a/src/H5AC.c b/src/H5AC.c
index 38d2aa7..e2271c5 100644
--- a/src/H5AC.c
+++ b/src/H5AC.c
@@ -3330,8 +3330,9 @@ H5AC_get_mdc_image_info(H5AC_t *cache_ptr, haddr_t *image_addr, hsize_t *image_l
FUNC_ENTER_NOAPI(FAIL)
if(H5C_get_mdc_image_info((H5C_t *)cache_ptr, image_addr, image_len) < 0)
- HGOTO_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, "H5C_get_mdc_image_info() failed")
+ HGOTO_ERROR(H5E_CACHE, H5E_CANTGET, FAIL, "can't retrieve cache image info")
done:
FUNC_LEAVE_NOAPI(ret_value)
} /* H5AC_get_mdc_image_info() */
+
diff --git a/src/H5Cquery.c b/src/H5Cquery.c
index 1ae70e2..5108013 100644
--- a/src/H5Cquery.c
+++ b/src/H5Cquery.c
@@ -473,9 +473,9 @@ H5C_get_mdc_image_info(H5C_t * cache_ptr, haddr_t *image_addr, hsize_t *image_le
FUNC_ENTER_NOAPI(FAIL)
if((cache_ptr == NULL) || (cache_ptr->magic != H5C__H5C_T_MAGIC))
- HGOTO_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, "Bad cache_ptr on entry.")
+ HGOTO_ERROR(H5E_CACHE, H5E_BADVALUE, FAIL, "bad cache_ptr on entry")
if(image_addr == NULL || image_len == NULL)
- HGOTO_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, "Bad image_addr or image_len on entry.")
+ HGOTO_ERROR(H5E_CACHE, H5E_BADVALUE, FAIL, "bad image_addr or image_len on entry")
*image_addr = cache_ptr->image_addr;
*image_len = cache_ptr->image_len;
@@ -483,3 +483,4 @@ H5C_get_mdc_image_info(H5C_t * cache_ptr, haddr_t *image_addr, hsize_t *image_le
done:
FUNC_LEAVE_NOAPI(ret_value)
} /* H5C_get_mdc_image_info() */
+
diff --git a/src/H5F.c b/src/H5F.c
index 01fb58e..aef9d1d 100644
--- a/src/H5F.c
+++ b/src/H5F.c
@@ -2073,10 +2073,8 @@ H5Fget_page_buffering_stats(hid_t file_id, unsigned accesses[2], unsigned hits[2
/* Check args */
if(NULL == (file = (H5F_t *)H5I_object_verify(file_id, H5I_FILE)))
HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "not a file ID")
-
if(NULL == file->shared->page_buf)
HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "page buffering not enabled on file")
-
if(NULL == accesses || NULL == hits || NULL == misses || NULL == evictions || NULL == bypasses)
HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "NULL input parameters for stats")
@@ -2087,6 +2085,7 @@ H5Fget_page_buffering_stats(hid_t file_id, unsigned accesses[2], unsigned hits[2
done:
FUNC_LEAVE_API(ret_value)
} /* H5Fget_page_buffering_stats() */
+
/*-------------------------------------------------------------------------
* Function: H5Fget_mdc_image_info
@@ -2116,14 +2115,14 @@ H5Fget_mdc_image_info(hid_t file_id, haddr_t *image_addr, hsize_t *image_len)
/* Check args */
if(NULL == (file = (H5F_t *)H5I_object_verify(file_id, H5I_FILE)))
HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "not a file ID")
-
if(NULL == image_addr || NULL == image_len)
HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "NULL image addr or image len")
/* Go get the address and size of the cache image */
if(H5AC_get_mdc_image_info(file->shared->cache, image_addr, image_len) < 0)
- HGOTO_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, "H5AC_get_mdc_image_info() failed.")
+ HGOTO_ERROR(H5E_CACHE, H5E_CANTGET, FAIL, "can't retrieve cache image info")
done:
FUNC_LEAVE_API(ret_value)
} /* H5Fget_mdc_image_info() */
+
diff --git a/tools/src/misc/h5clear.c b/tools/src/misc/h5clear.c
index 9ec562e..5c33b72 100644
--- a/tools/src/misc/h5clear.c
+++ b/tools/src/misc/h5clear.c
@@ -269,3 +269,4 @@ done:
leave(h5tools_getstatus());
} /* main() */
+