diff options
| author | Quincey Koziol <quincey@koziol.cc> | 2023-04-11 14:41:32 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-11 14:41:32 (GMT) |
| commit | 49a71463a064a80aec7f67d6de008d892954febf (patch) | |
| tree | 4e0d432ab31655d169ce88a14dff70f2d0cefc2a | |
| parent | 1ad030f6696159c498880a4d785f9a2f7ae6fd32 (diff) | |
| download | hdf5-49a71463a064a80aec7f67d6de008d892954febf.zip hdf5-49a71463a064a80aec7f67d6de008d892954febf.tar.gz hdf5-49a71463a064a80aec7f67d6de008d892954febf.tar.bz2 | |
Comment cleanup (#2689)
* Clean up content and redundant logging in comments.
126 files changed, 154 insertions, 2959 deletions
diff --git a/c++/test/dsets.cpp b/c++/test/dsets.cpp index 5c3ce81..1a23f5e 100644 --- a/c++/test/dsets.cpp +++ b/c++/test/dsets.cpp @@ -1375,14 +1375,6 @@ test_operator(H5File &file) * * Failure: -1 * - * Modifications: - * Nov 12, 01: - * - moved h5_cleanup to outside of try block because - * dataset.h5 cannot be removed until "file" is out of - * scope and dataset.h5 is closed. - * Feb 20, 05: - * - cleanup_dsets took care of the cleanup now. - * *------------------------------------------------------------------------- */ extern "C" void diff --git a/c++/test/tfile.cpp b/c++/test/tfile.cpp index 5677449..d683797 100644 --- a/c++/test/tfile.cpp +++ b/c++/test/tfile.cpp @@ -65,13 +65,6 @@ const H5std_string FILE4("tfile4.h5"); * Programmer Binh-Minh Ribler (use C version) * January, 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hsize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void @@ -274,13 +267,6 @@ test_file_create() * Programmer Binh-Minh Ribler (use C version) * January, 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hsize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void diff --git a/c++/test/tfilter.cpp b/c++/test/tfilter.cpp index 2d7dbb8..34078a7 100644 --- a/c++/test/tfilter.cpp +++ b/c++/test/tfilter.cpp @@ -96,8 +96,6 @@ filter_bogus(unsigned int flags, size_t cd_nelmts, const unsigned int *cd_values * Programmer Binh-Minh Ribler (use C version, from dsets.c/test_filters) * January, 2007 * - * Modifications: - * Note: H5Z interface is not implemented yet. *------------------------------------------------------------------------- */ const hsize_t chunk_size[2] = {FILTER_CHUNK_DIM1, FILTER_CHUNK_DIM2}; @@ -145,8 +143,6 @@ test_null_filter() * Programmer Binh-Minh Ribler (partly from dsets.c/test_filters) * January, 2007 * - * Modifications: - * Note: H5Z interface is not implemented yet. *------------------------------------------------------------------------- */ const H5std_string DSET_SZIP_NAME("szipped dataset"); diff --git a/c++/test/th5s.cpp b/c++/test/th5s.cpp index 3651aa3..b9a84e1 100644 --- a/c++/test/th5s.cpp +++ b/c++/test/th5s.cpp @@ -87,16 +87,6 @@ int space5_data = 7; * Programmer Binh-Minh Ribler (using C version) * Mar 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hssize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. - * April 12, 2011: Raymond Lu - * Starting from the 1.8.7 release, we allow dimension - * size to be zero. So I took out the test against it. *------------------------------------------------------------------------- */ static void @@ -223,13 +213,6 @@ test_h5s_basic() * Programmer Binh-Minh Ribler (using C version) * Mar 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hssize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void @@ -287,13 +270,6 @@ test_h5s_scalar_write() * Programmer Binh-Minh Ribler (using C version) * Mar 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hssize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void @@ -348,13 +324,6 @@ test_h5s_scalar_read() * Programmer Raymond Lu (using C version) * May 18, 2004 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hssize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void @@ -402,13 +371,6 @@ test_h5s_null() * Programmer Binh-Minh Ribler (using C version) * Mar 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hssize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void @@ -470,13 +432,6 @@ test_h5s_compound_scalar_write() * Programmer Binh-Minh Ribler (using C version) * Mar 2001 * - * Modifications: - * January, 2005: C tests' macro VERIFY casts values to 'long' for all - * cases. Since there are no operator<< for 'long long' - * or int64 in VS C++ ostream, I casted the hssize_t values - * passed to verify_val to 'long' as well. If problems - * arises later, this will have to be specifically handled - * with a special routine. *------------------------------------------------------------------------- */ static void diff --git a/fortran/src/H5If.c b/fortran/src/H5If.c index ef0128a..ffc6e08 100644 --- a/fortran/src/H5If.c +++ b/fortran/src/H5If.c @@ -273,7 +273,6 @@ done: * Returns: 0 on success, -1 on failure * Programmer: Elena Pourmal * Tuesday, August 24, 2004 - * Modifications: *---------------------------------------------------------------------------*/ int_f h5iis_valid_c(hid_t_f *obj_id, int_f *c_valid) diff --git a/fortran/src/H5Pf.c b/fortran/src/H5Pf.c index 7371814..38eba37 100644 --- a/fortran/src/H5Pf.c +++ b/fortran/src/H5Pf.c @@ -1802,10 +1802,6 @@ h5pget_nfilters_c(hid_t_f *prp_id, int_f *nfilters) * Returns: 0 on success, -1 on failure * Programmer: Xiangyang Su * Friday, February 25, 2000 - * Modifications: - * Since cd_nelmts has IN/OUT attributes, fixed the input and - * returned value of cd_nelmnts to satisfy this specification. - * MSB January 27, 2009 *---------------------------------------------------------------------------*/ int_f h5pget_filter_c(hid_t_f *prp_id, int_f *filter_number, int_f *flags, size_t_f *cd_nelmts, int_f *cd_values, @@ -5262,7 +5258,6 @@ h5pget_create_inter_group_c(hid_t_f *lcpl_id, int_f *crt_intermed_group) * Returns: 0 on success, -1 on failure * Programmer: M. Scot Breitenfeld * April 13, 2009 - * Modifications: *---------------------------------------------------------------------------*/ int_f @@ -5295,7 +5290,6 @@ h5pset_chunk_cache_c(hid_t_f *dapl_id, size_t_f *rdcc_nslots, size_t_f *rdcc_nby * Returns: 0 on success, -1 on failure * Programmer: M. Scot Breitenfeld * April 13, 2009 - * Modifications: *---------------------------------------------------------------------------*/ int_f diff --git a/fortran/test/t.c b/fortran/test/t.c index f6bc0f9..b89e8ae 100644 --- a/fortran/test/t.c +++ b/fortran/test/t.c @@ -36,7 +36,6 @@ * Returns: 0 on success, -1 on failure * Programmer: Elena Pourmal * Friday, September 13, 2002 - * Modifications: *---------------------------------------------------------------------------*/ int_f nh5_fixname_c(_fcd base_name, size_t_f *base_namelen, hid_t_f *fapl, _fcd full_name, size_t_f *full_namelen) @@ -78,7 +77,6 @@ done: * Returns: 0 on success, -1 on failure * Programmer: Elena Pourmal * Thursday, September 19, 2002 - * Modifications: *---------------------------------------------------------------------------*/ int_f nh5_cleanup_c(_fcd base_name, size_t_f *base_namelen, hid_t_f *fapl) @@ -128,7 +126,6 @@ DONE: * Returns: none * Programmer: Quincey Koziol * Tuesday, December 14, 2004 - * Modifications: *---------------------------------------------------------------------------*/ void nh5_exit_c(int_f *status) @@ -145,7 +142,6 @@ nh5_exit_c(int_f *status) * Returns: none * Programmer: M.S. Breitenfeld * September 30, 2008 - * Modifications: *---------------------------------------------------------------------------*/ void nh5_env_nocleanup_c(int_f *status) diff --git a/fortran/test/tH5G_1_8.F90 b/fortran/test/tH5G_1_8.F90 index 755c96d..a4b25f2 100644 --- a/fortran/test/tH5G_1_8.F90 +++ b/fortran/test/tH5G_1_8.F90 @@ -639,8 +639,6 @@ SUBROUTINE group_info(cleanup, fapl, total_error) ! * Programmer: Adapted from C test by: ! * M.S. Breitenfeld ! * -! * Modifications: -! * ! *------------------------------------------------------------------------- ! @@ -732,8 +730,6 @@ SUBROUTINE group_info(cleanup, fapl, total_error) ! * Programmer: M.S. Breitenfeld ! * March 3, 2008 ! * -! * Modifications: -! * ! *------------------------------------------------------------------------- ! @@ -1080,8 +1076,6 @@ SUBROUTINE lifecycle(cleanup, fapl2, total_error) ! * Programmer: M.S. Breitenfeld ! * April 14, 2008 ! * -! * Modifications: Modified original C code -! * ! *------------------------------------------------------------------------- ! @@ -1488,8 +1482,6 @@ SUBROUTINE link_info_by_idx_check(group_id, linkname, n, & ! * Modified C routine ! * March 12, 2008 ! * -! * Modifications: -! * ! *------------------------------------------------------------------------- ! @@ -1858,8 +1850,6 @@ END SUBROUTINE objcopy ! * Programmer: James Laird ! * Tuesday, June 6, 2006 ! * -! * Modifications: -! * ! *------------------------------------------------------------------------- ! diff --git a/fortran/test/tH5MISC_1_8.F90 b/fortran/test/tH5MISC_1_8.F90 index 2eea6ba..5413169 100644 --- a/fortran/test/tH5MISC_1_8.F90 +++ b/fortran/test/tH5MISC_1_8.F90 @@ -341,8 +341,6 @@ END SUBROUTINE test_h5s_encode ! Programmer: M. Scot Breitenfeld ! Decemeber 11, 2010 ! -! Modifications: -! !------------------------------------------------------------------------- ! diff --git a/fortran/test/tH5P_F03.F90 b/fortran/test/tH5P_F03.F90 index ad505d4..0875b81 100644 --- a/fortran/test/tH5P_F03.F90 +++ b/fortran/test/tH5P_F03.F90 @@ -85,8 +85,6 @@ CONTAINS ! * Programmer: M. Scot Breitenfeld ! * June 24, 2008 ! * -! * Modifications: -! * ! *------------------------------------------------------------------------- ! diff --git a/fortran/test/tH5T.F90 b/fortran/test/tH5T.F90 index 82a908e..1fee036 100644 --- a/fortran/test/tH5T.F90 +++ b/fortran/test/tH5T.F90 @@ -953,8 +953,6 @@ CONTAINS ! * Fortran Programmer: M.S. Breitenfeld ! * September 9, 2008 ! * -! * Modifications: -! * ! *------------------------------------------------------------------------- ! diff --git a/fortran/test/tH5T_F03.F90 b/fortran/test/tH5T_F03.F90 index 9535d3a..2256b50 100644 --- a/fortran/test/tH5T_F03.F90 +++ b/fortran/test/tH5T_F03.F90 @@ -2917,13 +2917,6 @@ END SUBROUTINE setup_buffer ! Programmer: M. Scot Breitenfeld ! Decemeber 7, 2010 ! -! Modifications: Moved this subroutine from the 1.8 test file and -! modified it to use F2003 features. -! This routine requires 4 byte reals, so we use F2003 features to -! ensure the requirement is satisfied in a portable way. -! The need for this arises when a user specifies the default real is 8 bytes. -! MSB 7/31/12 -! !------------------------------------------------------------------------- ! diff --git a/hl/fortran/src/H5IMcc.c b/hl/fortran/src/H5IMcc.c index 6e812f8..2084826 100644 --- a/hl/fortran/src/H5IMcc.c +++ b/hl/fortran/src/H5IMcc.c @@ -37,8 +37,6 @@ herr_t H5IM_get_palette(hid_t loc_id, const char *image_name, int pal_number, hi * The memory datatype is H5T_NATIVE_INT. It is supposed to be called from * the FORTRAN interface where the image buffer is defined as type "integer" * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -134,8 +132,6 @@ H5IMmake_image_8bitf(hid_t loc_id, const char *dset_name, hsize_t width, hsize_t * INTERLACE_PLANE [pixel components][height][width] * * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -244,8 +240,6 @@ H5IMmake_image_24bitf(hid_t loc_id, const char *dset_name, hsize_t width, hsize_ * The memory datatype is H5T_NATIVE_INT. It is supposed to be called from * the FORTRAN interface where the image buffer is defined as type "integer" * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -302,8 +296,6 @@ out: * * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -395,8 +387,6 @@ H5IMmake_palettef(hid_t loc_id, const char *pal_name, const hsize_t *pal_dims, i * * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -434,8 +424,6 @@ H5IMget_palettef(hid_t loc_id, const char *image_name, int pal_number, int_f *pa * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t diff --git a/hl/fortran/src/H5IMfc.c b/hl/fortran/src/H5IMfc.c index 30b70dc..cead871 100644 --- a/hl/fortran/src/H5IMfc.c +++ b/hl/fortran/src/H5IMfc.c @@ -29,9 +29,6 @@ * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -84,9 +81,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -134,9 +128,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -197,9 +188,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -274,9 +262,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -320,9 +305,6 @@ h5imis_image_c(hid_t_f *loc_id, size_t_f *namelen, _fcd name) * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -370,9 +352,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -430,9 +409,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -490,9 +466,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -546,9 +519,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -605,9 +575,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -658,9 +625,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ diff --git a/hl/fortran/src/H5LTfc.c b/hl/fortran/src/H5LTfc.c index 2819f1b..c888eec 100644 --- a/hl/fortran/src/H5LTfc.c +++ b/hl/fortran/src/H5LTfc.c @@ -29,9 +29,6 @@ * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -93,9 +90,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -148,9 +142,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -208,9 +199,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -261,9 +249,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -361,9 +346,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -443,9 +425,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -513,9 +492,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -568,9 +544,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -614,9 +587,6 @@ h5ltfind_dataset_c(hid_t_f *loc_id, size_t_f *namelen, _fcd name) * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -687,9 +657,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -750,9 +717,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -830,9 +794,6 @@ done: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ diff --git a/hl/fortran/src/H5LTff.F90 b/hl/fortran/src/H5LTff.F90 index 8ced874..fe54627 100644 --- a/hl/fortran/src/H5LTff.F90 +++ b/hl/fortran/src/H5LTff.F90 @@ -615,8 +615,6 @@ CONTAINS ! ! Comments: ! - ! Modifications: - ! !------------------------------------------------------------------------- SUBROUTINE h5ltmake_dataset_int_f_1 (loc_id,& @@ -790,8 +788,6 @@ CONTAINS ! ! Comments: ! - ! Modifications: - ! !------------------------------------------------------------------------- SUBROUTINE h5ltread_dataset_int_f_1(loc_id,& @@ -953,8 +949,6 @@ CONTAINS ! ! Comments: ! - ! Modifications: - ! !------------------------------------------------------------------------- SUBROUTINE h5ltmake_dataset_string_f(loc_id,& @@ -1003,8 +997,6 @@ CONTAINS ! ! Comments: ! - ! Modifications: - ! !------------------------------------------------------------------------- SUBROUTINE h5ltread_dataset_string_f(loc_id,& diff --git a/hl/src/H5IM.c b/hl/src/H5IM.c index 43e5bed..25381fd 100644 --- a/hl/src/H5IM.c +++ b/hl/src/H5IM.c @@ -27,8 +27,6 @@ * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -83,9 +81,6 @@ H5IMmake_image_8bit(hid_t loc_id, const char *dset_name, hsize_t width, hsize_t * INTERLACE_PIXEL [height][width][pixel components] * INTERLACE_PLANE [pixel components][height][width] * - * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -154,8 +149,6 @@ H5IMmake_image_24bit(hid_t loc_id, const char *dset_name, hsize_t width, hsize_t * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -197,8 +190,6 @@ find_palette(H5_ATTR_UNUSED hid_t loc_id, const char *name, H5_ATTR_UNUSED const * Comments: * The function uses H5Aiterate2 with the operator function find_palette * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -223,8 +214,6 @@ H5IM_find_palette(hid_t loc_id) * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -390,8 +379,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -437,8 +424,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -493,8 +478,6 @@ H5IMmake_palette(hid_t loc_id, const char *pal_name, const hsize_t *pal_dims, co * palettes to be viewed with. The dataset will have an attribute * which contains an array of object reference pointers which refer to palettes in the file. * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -660,8 +643,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -756,8 +737,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -842,8 +821,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -951,8 +928,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -1053,8 +1028,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -1154,8 +1127,6 @@ out: * Comments: * based on HDF5 Image and Palette Specification * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/hl/src/H5LT.c b/hl/src/H5LT.c index 6a4975f..4c61aa8 100644 --- a/hl/src/H5LT.c +++ b/hl/src/H5LT.c @@ -559,9 +559,6 @@ out: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -585,9 +582,6 @@ H5LTmake_dataset(hid_t loc_id, const char *dset_name, int rank, const hsize_t *d * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -610,9 +604,6 @@ H5LTmake_dataset_char(hid_t loc_id, const char *dset_name, int rank, const hsize * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -635,9 +626,6 @@ H5LTmake_dataset_short(hid_t loc_id, const char *dset_name, int rank, const hsiz * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -660,9 +648,6 @@ H5LTmake_dataset_int(hid_t loc_id, const char *dset_name, int rank, const hsize_ * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -685,9 +670,6 @@ H5LTmake_dataset_long(hid_t loc_id, const char *dset_name, int rank, const hsize * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -710,9 +692,6 @@ H5LTmake_dataset_float(hid_t loc_id, const char *dset_name, int rank, const hsiz * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -736,9 +715,6 @@ H5LTmake_dataset_double(hid_t loc_id, const char *dset_name, int rank, const hsi * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -1293,8 +1269,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -1380,8 +1354,6 @@ H5_GCC_CLANG_DIAG_ON("cast-qual") * * Comments: If the attribute already exists, it is overwritten * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -2034,8 +2006,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ hid_t @@ -2083,8 +2053,6 @@ out: * * Date: 29 September 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ static char * @@ -2155,8 +2123,6 @@ out: * * Date: December 6, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static char * @@ -2189,8 +2155,6 @@ out: * * Programmer: Raymond Lu * - * Modifications: - * *-----------------------------------------------------------------------*/ static char * print_enum(hid_t type, char *str, size_t *str_len, hbool_t no_ubuf, size_t indt) @@ -2323,8 +2287,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -2374,8 +2336,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ char * @@ -2984,8 +2944,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3031,8 +2989,6 @@ H5LTget_attribute_string(hid_t loc_id, const char *obj_name, const char *attr_na * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3058,8 +3014,6 @@ H5LTget_attribute_char(hid_t loc_id, const char *obj_name, const char *attr_name * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3085,8 +3039,6 @@ H5LTget_attribute_uchar(hid_t loc_id, const char *obj_name, const char *attr_nam * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3112,8 +3064,6 @@ H5LTget_attribute_short(hid_t loc_id, const char *obj_name, const char *attr_nam * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3139,8 +3089,6 @@ H5LTget_attribute_ushort(hid_t loc_id, const char *obj_name, const char *attr_na * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3166,8 +3114,6 @@ H5LTget_attribute_int(hid_t loc_id, const char *obj_name, const char *attr_name, * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3193,8 +3139,6 @@ H5LTget_attribute_uint(hid_t loc_id, const char *obj_name, const char *attr_name * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3220,8 +3164,6 @@ H5LTget_attribute_long(hid_t loc_id, const char *obj_name, const char *attr_name * * Comments: This function was added to support INTEGER*8 Fortran types * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3247,8 +3189,6 @@ H5LTget_attribute_long_long(hid_t loc_id, const char *obj_name, const char *attr * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3274,8 +3214,6 @@ H5LTget_attribute_ulong(hid_t loc_id, const char *obj_name, const char *attr_nam * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -3301,8 +3239,6 @@ H5LTget_attribute_ullong(hid_t loc_id, const char *obj_name, const char *attr_na * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3329,8 +3265,6 @@ H5LTget_attribute_float(hid_t loc_id, const char *obj_name, const char *attr_nam * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3357,8 +3291,6 @@ H5LTget_attribute_double(hid_t loc_id, const char *obj_name, const char *attr_na * * Comments: Private function * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3390,8 +3322,6 @@ H5LTget_attribute(hid_t loc_id, const char *obj_name, const char *attr_name, hid * * Comments: Private function * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3451,8 +3381,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3500,8 +3428,6 @@ out: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t diff --git a/hl/src/H5PT.c b/hl/src/H5PT.c index 8f0b323..9d5d627 100644 --- a/hl/src/H5PT.c +++ b/hl/src/H5PT.c @@ -58,13 +58,6 @@ static herr_t H5PT_get_index(htbl_t *table_id, hsize_t *pt_index); * currently. Fill data is not necessary because the * table is initially of size 0. * - * Modifications: - * Mar 1, 2016 - * This function is added to replace H5PTcreate_fl and it differs - * from H5PTcreate_fl only because its last argument is plist_id - * instead of compression; this is to allow flexible compression. - * -BMR - * *------------------------------------------------------------------------- */ hid_t @@ -183,8 +176,6 @@ error: * currently. Fill data is not necessary because the * table is initially of size 0. * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -297,13 +288,6 @@ error: * * Comments: * - * Modifications: - * - * John Mainzer -- 4/23/08 - * Added error check on malloc of table, initialized fields - * in table to keep lower level code from choking on bogus - * data in error cases. - * *------------------------------------------------------------------------- */ hid_t @@ -422,8 +406,6 @@ H5PT_free_id(void *id, void H5_ATTR_UNUSED **_ctx) * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -470,8 +452,6 @@ error: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -524,8 +504,6 @@ error: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -574,9 +552,6 @@ error: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ herr_t @@ -618,9 +593,6 @@ error: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ herr_t @@ -667,8 +639,6 @@ error: * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -720,8 +690,6 @@ H5PT_get_index(htbl_t *table, hsize_t *pt_index) * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t @@ -781,9 +749,6 @@ H5PTget_index(hid_t table_id, hsize_t *pt_index) * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ herr_t @@ -818,9 +783,6 @@ error: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ herr_t @@ -848,9 +810,6 @@ H5PTis_valid(hid_t table_id) * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ herr_t @@ -898,9 +857,6 @@ error: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -956,9 +912,6 @@ error: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ hid_t @@ -991,9 +944,6 @@ error: * * Comments: * - * Modifications: - * - * *------------------------------------------------------------------------- */ hid_t diff --git a/hl/tools/gif2h5/writehdf.c b/hl/tools/gif2h5/writehdf.c index 17d864b..0a90870 100644 --- a/hl/tools/gif2h5/writehdf.c +++ b/hl/tools/gif2h5/writehdf.c @@ -25,9 +25,6 @@ * * Programmer: Unknown * - * Modifications: pvn - * Use the HDF5 IMAGE API to write the HDF5 image and palette - * * Date: January, 31, 2006 * *------------------------------------------------------------------------- @@ -413,14 +413,6 @@ done: * Programmer: Robb Matzke * Jul 9 1997 * - * Changes: - * - * In the parallel case, added code to setup the MDC slist - * before the call to H5AC__flush_entries() and take it down - * afterwards. - * - * JRM -- 7/29/20 - * *------------------------------------------------------------------------- */ herr_t @@ -1191,13 +1183,12 @@ done: * * Function: H5AC_prep_for_file_flush * - * Purpose: This function should be called just prior to the first - * call to H5AC_flush() during a file flush. + * Purpose: Handle any setup required prior to metadata cache flush. * - * Its purpose is to handly any setup required prior to - * metadata cache flush. + * This function should be called just prior to the first + * call to H5AC_flush() during a file flush. * - * Initially, this means setting up the slist prior to the + * Initially, this means setting up the skip list prior to the * flush. We do this in a separate call because * H5F__flush_phase2() make repeated calls to H5AC_flush(). * Handling this detail in separate calls allows us to avoid @@ -1209,8 +1200,6 @@ done: * Programmer: John Mainzer * 5/5/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -1242,9 +1231,6 @@ done: * Purpose: This function should be called just after the last * call to H5AC_flush() during a file flush. * - * Its purpose is to perform any necessary cleanup after the - * metadata cache flush. - * * The objective of the call is to allow the metadata cache * to do any necessary necessary cleanup work after a cache * flush. @@ -1261,8 +1247,6 @@ done: * Programmer: John Mainzer * 5/5/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -1474,24 +1458,6 @@ H5AC_resize_entry(void *thing, size_t new_size) * amounts of dirty metadata creation in other areas -- which will * cause aux_ptr->dirty_bytes to be incremented. * - * The bottom line is that this code is probably OK, but the above - * points should be kept in mind. - * - * One final observation: This comment is occasioned by a bug caused - * by moving the call to H5AC__log_dirtied_entry() after the call to - * H5C_resize_entry(), and then only calling H5AC__log_dirtied_entry() - * if entry_ptr->is_dirty was false. - * - * Since H5C_resize_entry() marks the target entry dirty unless there - * is not change in size, this had the effect of not calling - * H5AC__log_dirtied_entry() when it should be, and corrupting - * the cleaned and dirtied lists used by rank 0 in the parallel - * version of the metadata cache. - * - * The point here is that you should be very careful when working with - * this code, and not modify it unless you fully understand it. - * - * JRM -- 2/28/22 */ if ((!entry_ptr->is_dirty) && (entry_ptr->size != new_size)) { diff --git a/src/H5ACmpio.c b/src/H5ACmpio.c index 197cc3c..40e68fd 100644 --- a/src/H5ACmpio.c +++ b/src/H5ACmpio.c @@ -1860,8 +1860,6 @@ done: * Programmer: John Mainzer * April 28, 2010 * - * Changes: None. - * *------------------------------------------------------------------------- */ static herr_t @@ -185,82 +185,6 @@ H5FL_SEQ_DEFINE_STATIC(H5C_cache_entry_ptr_t); * Programmer: John Mainzer * 6/2/04 * - * Modifications: - * - * JRM -- 7/20/04 - * Updated for the addition of the hash table. - * - * JRM -- 10/5/04 - * Added call to H5C_reset_cache_hit_rate_stats(). Also - * added initialization for cache_is_full flag and for - * resize_ctl. - * - * JRM -- 11/12/04 - * Added initialization for the new size_decreased field. - * - * JRM -- 11/17/04 - * Added/updated initialization for the automatic cache - * size control data structures. - * - * JRM -- 6/24/05 - * Added support for the new write_permitted field of - * the H5C_t structure. - * - * JRM -- 7/5/05 - * Added the new log_flush parameter and supporting code. - * - * JRM -- 9/21/05 - * Added the new aux_ptr parameter and supporting code. - * - * JRM -- 1/20/06 - * Added initialization of the new prefix field in H5C_t. - * - * JRM -- 3/16/06 - * Added initialization for the pinned entry related fields. - * - * JRM -- 5/31/06 - * Added initialization for the trace_file_ptr field. - * - * JRM -- 8/19/06 - * Added initialization for the flush_in_progress field. - * - * JRM -- 8/25/06 - * Added initialization for the slist_len_increase and - * slist_size_increase fields. These fields are used - * for sanity checking in the flush process, and are not - * compiled in unless H5C_DO_SANITY_CHECKS is TRUE. - * - * JRM -- 3/28/07 - * Added initialization for the new is_read_only and - * ro_ref_count fields. - * - * JRM -- 7/27/07 - * Added initialization for the new evictions_enabled - * field of H5C_t. - * - * JRM -- 12/31/07 - * Added initialization for the new flash cache size increase - * related fields of H5C_t. - * - * JRM -- 11/5/08 - * Added initialization for the new clean_index_size and - * dirty_index_size fields of H5C_t. - * - * - * Missing entries? - * - * - * JRM -- 4/20/20 - * Added initialization for the slist_enabled field. Recall - * that the slist is used to flush metadata cache entries - * in (roughly) increasing address order. While this is - * needed at flush and close, it is not used elsewhere. - * The slist_enabled field exists to allow us to construct - * the slist when needed, and leave it empty otherwise -- thus - * avoiding the overhead of maintaining it. - * - * JRM -- 4/29/20 - * *------------------------------------------------------------------------- */ H5C_t * @@ -691,10 +615,7 @@ H5C_prep_for_file_close(H5F_t *f) HDassert(cache_ptr); HDassert(cache_ptr->magic == H5C__H5C_T_MAGIC); - /* For now at least, it is possible to receive the - * close warning more than once -- the following - * if statement handles this. - */ + /* It is possible to receive the close warning more than once */ if (cache_ptr->close_warning_received) HGOTO_DONE(SUCCEED) cache_ptr->close_warning_received = TRUE; @@ -759,27 +680,13 @@ done: * This function fails if any object are protected since the * resulting file might not be consistent. * - * Note that *cache_ptr has been freed upon successful return. + * Note: *cache_ptr has been freed upon successful return. * * Return: Non-negative on success/Negative on failure * * Programmer: John Mainzer * 6/2/04 * - * Modifications: - * - * JRM -- 5/15/20 - * - * Updated the function to enable the slist prior to the - * call to H5C__flush_invalidate_cache(). - * - * Arguably, it shouldn't be necessary to re-enable the - * slist after the call to H5C__flush_invalidate_cache(), as - * the metadata cache should be discarded. However, in the - * test code, we make multiple calls to H5C_dest(). Thus - * we re-enable the slist on failure if it and the cache - * still exist. - * *------------------------------------------------------------------------- */ herr_t @@ -859,9 +766,12 @@ H5C_dest(H5F_t *f) done: if ((ret_value < 0) && (cache_ptr) && (cache_ptr->slist_ptr)) { - - /* need this for test code -- see change note for details */ - + /* Arguably, it shouldn't be necessary to re-enable the slist after + * the call to H5C__flush_invalidate_cache(), as the metadata cache + * should be discarded. However, in the test code, we make multiple + * calls to H5C_dest(). Thus we re-enable the slist on failure if it + * and the cache still exist. JRM -- 5/15/20 + */ if (H5C_set_slist_enabled(f->shared->cache, FALSE, FALSE) < 0) HDONE_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, "disable slist on flush dest failure failed") @@ -881,14 +791,6 @@ done: * Programmer: Vailin Choi * Dec 2013 * - * Modifications: - * - * JRM -- 5/5/20 - * - * Added code to enable the skip list prior to the call - * to H5C__flush_invalidate_cache(), and disable it - * afterwards. - * *------------------------------------------------------------------------- */ herr_t @@ -923,9 +825,9 @@ done: /*------------------------------------------------------------------------- * Function: H5C_expunge_entry * - * Purpose: Use this function to tell the cache to expunge an entry - * from the cache without writing it to disk even if it is - * dirty. The entry may not be either pinned or protected. + * Purpose: Expunge an entry from the cache without writing it to disk + * even if it is dirty. The entry may not be either pinned or + * protected. * * Return: Non-negative on success/Negative on failure * @@ -1007,39 +909,11 @@ done: * function returns failure. * * Return: Non-negative on success/Negative on failure or if there was - * a request to flush all items and something was protected. + * a request to flush all items and an entry was protected. * * Programmer: John Mainzer * 6/2/04 * - * Changes: Modified function to test for slist chamges in - * pre_serialize and serialize callbacks, and re-start - * scans through the slist when such changes occur. - * - * This has been a potential problem for some time, - * and there has been code in this function to deal - * with elements of this issue. However the shift - * to the V3 cache in combination with the activities - * of some of the cache clients (in particular the - * free space manager and the fractal heap) have - * made this re-work necessary. - * - * JRM -- 12/13/14 - * - * Modified function to support rings. Basic idea is that - * every entry in the cache is assigned to a ring. Entries - * in the outermost ring are flushed first, followed by - * those in the next outermost ring, and so on until the - * innermost ring is flushed. See header comment on - * H5C_ring_t in H5Cprivate.h for a more detailed - * discussion. - * - * JRM -- 8/30/15 - * - * Modified function to call the free space manager - * settling functions. - * JRM -- 6/9/16 - * *------------------------------------------------------------------------- */ herr_t @@ -1226,8 +1100,6 @@ done: * exist on disk yet, but it must have an address and disk * space reserved. * - * Observe that this function cannot occasion a read. - * * Return: Non-negative on success/Negative on failure * * Programmer: John Mainzer @@ -1443,9 +1315,6 @@ H5C_insert_entry(H5F_t *f, const H5C_class_t *type, haddr_t addr, void *thing, u * oversized at the end of an unprotect. As a result, it is * possible to have a vastly oversized cache with no protected * entries as long as all the protects precede the unprotects. - * - * Since items 1 and 2 are not changing any time soon, I see - * no point in worrying about the third. */ if (H5C__make_space_in_cache(f, space_needed, write_permitted) < 0) @@ -1531,12 +1400,6 @@ done: * Programmer: John Mainzer * 5/15/06 * - * JRM -- 11/5/08 - * Added call to H5C__UPDATE_INDEX_FOR_ENTRY_DIRTY() to - * update the new clean_index_size and dirty_index_size - * fields of H5C_t in the case that the entry was clean - * prior to this call, and is pinned and not protected. - * *------------------------------------------------------------------------- */ herr_t @@ -2092,9 +1955,6 @@ done: * Programmer: John Mainzer * 4/26/06 * - * Changes: Added extreme sanity checks on entry and exit. - * JRM -- 4/26/14 - * *------------------------------------------------------------------------- */ herr_t @@ -2242,14 +2102,14 @@ H5C_protect(H5F_t *f, const H5C_class_t *type, haddr_t addr, void *udata, unsign if (entry_ptr->type != type) HGOTO_ERROR(H5E_CACHE, H5E_BADTYPE, NULL, "incorrect cache entry type") - /* if this is a collective metadata read, the entry is not - marked as collective, and is clean, it is possible that - other processes will not have it in its cache and will - expect a bcast of the entry from process 0. So process 0 - will bcast the entry to all other ranks. Ranks that _do_ have - the entry in their cache still have to participate in the - bcast. */ #ifdef H5_HAVE_PARALLEL + /* If this is a collective metadata read, the entry is not marked as + * collective, and is clean, it is possible that other processes will + * not have it in its cache and will expect a bcast of the entry from + * process 0. So process 0 will bcast the entry to all other ranks. + * Ranks that _do_ have the entry in their cache still have to + * participate in the bcast. + */ if (coll_access) { if (!(entry_ptr->is_dirty) && !(entry_ptr->coll_access)) { MPI_Comm comm; /* File MPI Communicator */ @@ -2415,24 +2275,16 @@ H5C_protect(H5F_t *f, const H5C_class_t *type, haddr_t addr, void *udata, unsign * oversized at the end of an unprotect. As a result, it is * possible to have a vastly oversized cache with no protected * entries as long as all the protects precede the unprotects. - * - * Since items 1, 2, and 3 are not changing any time soon, I - * see no point in worrying about the fourth. */ - if (H5C__make_space_in_cache(f, space_needed, write_permitted) < 0) HGOTO_ERROR(H5E_CACHE, H5E_CANTPROTECT, NULL, "H5C__make_space_in_cache failed") } /* end if */ - /* Insert the entry in the hash table. It can't be dirty yet, so - * we don't even check to see if it should go in the skip list. - * - * This is no longer true -- due to a bug fix, we may modify - * data on load to repair a file. + /* Insert the entry in the hash table. * * ******************************************* * - * Set the flush_last field + * Set the flush_me_last field * of the newly loaded entry before inserting it into the * index. Must do this, as the index tracked the number of * entries with the flush_last field set, but assumes that @@ -2531,7 +2383,6 @@ H5C_protect(H5F_t *f, const H5C_class_t *type, haddr_t addr, void *udata, unsign * should also call H5C__make_space_in_cache() to bring us * into compliance. */ - if (cache_ptr->index_size >= cache_ptr->max_cache_size) empty_space = 0; else @@ -2689,7 +2540,7 @@ H5C_set_cache_auto_resize_config(H5C_t *cache_ptr, H5C_auto_size_ctl_t *config_p HGOTO_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, "Unknown incr_mode?!?!?") } /* end switch */ - /* logically, this is were configuration for flash cache size increases + /* logically, this is where configuration for flash cache size increases * should go. However, this configuration depends on max_cache_size, so * we wait until the end of the function, when this field is set. */ @@ -2842,8 +2693,7 @@ H5C_set_evictions_enabled(H5C_t *cache_ptr, hbool_t evictions_enabled) /* There is no fundamental reason why we should not permit * evictions to be disabled while automatic resize is enabled. - * However, I can't think of any good reason why one would - * want to, and allowing it would greatly complicate testing + * However, allowing it would greatly complicate testing * the feature. Hence the following: */ if ((evictions_enabled != TRUE) && ((cache_ptr->resize_ctl.incr_mode != H5C_incr__off) || @@ -2912,10 +2762,6 @@ done: * Programmer: John Mainzer * 5/1/20 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ herr_t @@ -3035,9 +2881,6 @@ done: * Programmer: John Mainzer * 3/22/06 * - * Changes: Added extreme sanity checks on entry and exit. - * JRM -- 4/26/14 - * *------------------------------------------------------------------------- */ herr_t @@ -3098,81 +2941,6 @@ done: * Programmer: John Mainzer * 6/2/04 * - * Modifications: - * - * JRM -- 7/21/04 - * Updated for the addition of the hash table. - * - * JRM -- 10/28/04 - * Added code to set cache_full to TRUE whenever we try to - * make space in the cache. - * - * JRM -- 11/12/04 - * Added code to call to H5C_make_space_in_cache() after the - * call to H5C__auto_adjust_cache_size() if that function - * sets the size_decreased flag is TRUE. - * - * JRM -- 4/25/05 - * The size_decreased flag can also be set to TRUE in - * H5C_set_cache_auto_resize_config() if a new configuration - * forces an immediate reduction in cache size. Modified - * the code to deal with this eventuallity. - * - * JRM -- 6/24/05 - * Added support for the new write_permitted field of H5C_t. - * - * JRM -- 10/22/05 - * Hand optimizations. - * - * JRM -- 5/3/06 - * Added code to set the new dirtied field in - * H5C_cache_entry_t to FALSE prior to return. - * - * JRM -- 6/23/06 - * Modified code to allow dirty entries to be loaded from - * disk. This is necessary as a bug fix in the object - * header code requires us to modify a header as it is read. - * - * JRM -- 3/28/07 - * Added the flags parameter and supporting code. At least - * for now, this parameter is used to allow the entry to - * be protected read only, thus allowing multiple protects. - * - * Also added code to allow multiple read only protects - * of cache entries. - * - * JRM -- 7/27/07 - * Added code supporting the new evictions_enabled field - * in H5C_t. - * - * JRM -- 1/3/08 - * Added to do a flash cache size increase if appropriate - * when a large entry is loaded. - * - * JRM -- 11/13/08 - * Modified function to call H5C_make_space_in_cache() when - * the min_clean_size is violated, not just when there isn't - * enough space for and entry that has just been loaded. - * - * The purpose of this modification is to avoid "metadata - * blizzards" in the write only case. In such instances, - * the cache was allowed to fill with dirty metadata. When - * we finally needed to evict an entry to make space, we had - * to flush out a whole cache full of metadata -- which has - * interesting performance effects. We hope to avoid (or - * perhaps more accurately hide) this effect by maintaining - * the min_clean_size, which should force us to start flushing - * entries long before we actually have to evict something - * to make space. - * - * - * Missing entries? - * - * - * JRM -- 5/8/20 - * Updated for the possibility that the slist will be - * disabled. - * *------------------------------------------------------------------------- */ herr_t @@ -3427,14 +3195,10 @@ H5C_unprotect(H5F_t *f, haddr_t addr, void *thing, unsigned flags) } } /* end if */ - /* this implementation of the "deleted" option is a bit inefficient, as + /* This implementation of the "deleted" option is a bit inefficient, as * we re-insert the entry to be deleted into the replacement policy * data structures, only to remove them again. Depending on how often * we do this, we may want to optimize a bit. - * - * On the other hand, this implementation is reasonably clean, and - * makes good use of existing code. - * JRM - 5/19/04 */ if (deleted) { @@ -3476,8 +3240,7 @@ H5C_unprotect(H5F_t *f, haddr_t addr, void *thing, unsigned flags) } /* end if */ #ifdef H5_HAVE_PARALLEL else if (clear_entry) { - - /* verify that the target entry is in the cache. */ + /* Verify that the target entry is in the cache. */ H5C__SEARCH_INDEX(cache_ptr, addr, test_entry_ptr, FAIL) if (test_entry_ptr == NULL) @@ -4704,8 +4467,6 @@ done: * will be re-calculated, and will be enforced the next time * we have to make space in the cache. * - * Observe that this function cannot occasion a read. - * * Return: Non-negative on success/Negative on failure. * * Programmer: John Mainzer, 11/22/04 @@ -5138,8 +4899,6 @@ H5C__flash_increase_cache_size(H5C_t *cache_ptr, size_t old_entry_size, size_t n if (((cache_ptr->index_size + space_needed) > cache_ptr->max_cache_size) && (cache_ptr->max_cache_size < (cache_ptr->resize_ctl).max_size)) { - /* we have work to do */ - switch ((cache_ptr->resize_ctl).flash_incr_mode) { case H5C_flash_incr__off: HGOTO_ERROR(H5E_CACHE, H5E_SYSTEM, FAIL, @@ -5259,52 +5018,7 @@ done: * a request to flush all items and something was protected. * * Programmer: John Mainzer - * 3/24/065 - * - * Modifications: - * - * To support the fractal heap, the cache must now deal with - * entries being dirtied, resized, and/or renamed inside - * flush callbacks. Updated function to support this. - * - * -- JRM 8/27/06 - * - * Added code to detect and manage the case in which a - * flush callback changes the s-list out from under - * the function. The only way I can think of in which this - * can happen is if a flush function loads an entry - * into the cache that isn't there already. Quincey tells - * me that this will never happen, but I'm not sure I - * believe him. - * - * Note that this is a pretty bad scenario if it ever - * happens. The code I have added should allow us to - * handle the situation under all but the worst conditions, - * but one can argue that we should just scream and die if - * we ever detect the condition. - * - * -- JRM 10/13/07 - * - * Missing entries? - * - * - * Added support for the H5C__EVICT_ALLOW_LAST_PINS_FLAG. - * This flag is used to flush and evict all entries in - * the metadata cache that are not pinned -- typically, - * everything other than the superblock. - * - * ??? -- ??/??/?? - * - * Added sanity checks to verify that the skip list is - * enabled on entry. On the face of it, it would make - * sense to enable the slist on entry, and disable it - * on exit, as this function is not called repeatedly. - * However, since this function can be called from - * H5C_flush_cache(), this would create cases in the test - * code where we would have to check the flags to determine - * whether we must setup and take down the slist. - * - * JRM -- 5/5/20 + * 3/24/05 * *------------------------------------------------------------------------- */ @@ -5472,20 +5186,6 @@ done: * Programmer: John Mainzer * 9/1/15 * - * Changes: Added support for the H5C__EVICT_ALLOW_LAST_PINS_FLAG. - * This flag is used to flush and evict all entries in - * the metadata cache that are not pinned -- typically, - * everything other than the superblock. - * - * ??? -- ??/??/?? - * - * A recent optimization turns off the slist unless a flush - * is in progress. This should not effect this function, as - * it is only called during a flush. Added an assertion to - * verify this. - * - * JRM -- 5/6/20 - * *------------------------------------------------------------------------- */ static herr_t @@ -5546,13 +5246,11 @@ H5C__flush_invalidate_ring(H5F_t *f, H5C_ring_t ring, unsigned flags) * for some other cache entry), we can no longer promise to flush * the cache entries in increasing address order. * - * Instead, we just do the best we can -- making a pass through + * Instead, we make a pass through * the skip list, and then a pass through the "clean" entries, and * then repeating as needed. Thus it is quite possible that an * entry will be evicted from the cache only to be re-loaded later - * in the flush process (From what Quincey tells me, the pin - * mechanism makes this impossible, but even it it is true now, - * we shouldn't count on it in the future.) + * in the flush process. * * The bottom line is that entries will probably be flushed in close * to increasing address order, but there are no guarantees. @@ -5706,8 +5404,7 @@ H5C__flush_invalidate_ring(H5F_t *f, H5C_ring_t ring, unsigned flags) (entry_ptr->flush_dep_nchildren == 0) && (entry_ptr->ring == ring)) { if (entry_ptr->is_protected) { - - /* we have major problems -- but lets flush + /* We have major problems -- but lets flush * everything we can before we flag an error. */ protected_entries++; @@ -5792,7 +5489,7 @@ H5C__flush_invalidate_ring(H5F_t *f, H5C_ring_t ring, unsigned flags) * Writes to disk are possible here. */ - /* reset the counters so that we can detect insertions, loads, + /* Reset the counters so that we can detect insertions, loads, * and moves caused by the pre_serialize and serialize calls. */ cache_ptr->entries_loaded_counter = 0; @@ -6000,14 +5697,6 @@ done: * Programmer: John Mainzer * 9/1/15 * - * Changes: A recent optimization turns off the slist unless a flush - * is in progress. This should not effect this function, as - * it is only called during a flush. Added an assertion to - * verify this. - * - * JRM -- 5/6/20 - * - * *------------------------------------------------------------------------- */ static herr_t @@ -6158,7 +5847,7 @@ H5C__flush_ring(H5F_t *f, H5C_ring_t ring, unsigned flags) * dirty, resize, or take ownership of other entries * in the cache. * - * To deal with this, I have inserted code to detect any + * To deal with this, there is code to detect any * change in the skip list not directly under the control * of this function. If such modifications are detected, * we must re-start the scan of the skip list to avoid @@ -6310,69 +5999,6 @@ done: * * Programmer: John Mainzer, 5/5/04 * - * Modifications: - * - * JRM -- 7/21/04 - * Updated function for the addition of the hash table. - * - * QAK -- 11/26/04 - * Updated function for the switch from TBBTs to skip lists. - * - * JRM -- 1/6/05 - * Updated function to reset the flush_marker field. - * Also replace references to H5F_FLUSH_INVALIDATE and - * H5F_FLUSH_CLEAR_ONLY with references to - * H5C__FLUSH_INVALIDATE_FLAG and H5C__FLUSH_CLEAR_ONLY_FLAG - * respectively. - * - * JRM -- 6/24/05 - * Added code to remove dirty entries from the slist after - * they have been flushed. Also added a sanity check that - * will scream if we attempt a write when writes are - * completely disabled. - * - * JRM -- 7/5/05 - * Added code to call the new log_flush callback whenever - * a dirty entry is written to disk. Note that the callback - * is not called if the H5C__FLUSH_CLEAR_ONLY_FLAG is set, - * as there is no write to file in this case. - * - * JRM -- 8/21/06 - * Added code maintaining the flush_in_progress and - * destroy_in_progress fields in H5C_cache_entry_t. - * - * Also added flush_flags parameter to the call to - * type_ptr->flush() so that the flush routine can report - * whether the entry has been resized or renamed. Added - * code using the flush_flags variable to detect the case - * in which the target entry is resized during flush, and - * update the caches data structures accordingly. - * - * JRM -- 3/29/07 - * Added sanity checks on the new is_read_only and - * ro_ref_count fields. - * - * QAK -- 2/07/08 - * Separated "destroy entry" concept from "remove entry from - * cache" concept, by adding the 'take_ownership' flag and - * the "destroy_entry" variable. - * - * JRM -- 11/5/08 - * Added call to H5C__UPDATE_INDEX_FOR_ENTRY_CLEAN() to - * maintain the new clean_index_size and clean_index_size - * fields of H5C_t. - * - * - * Missing entries?? - * - * - * JRM -- 5/8/20 - * Updated sanity checks for the possibility that the slist - * is disabled. - * - * Also updated main comment to conform more closely with - * the current state of the code. - * *------------------------------------------------------------------------- */ herr_t @@ -6741,8 +6367,6 @@ H5C__flush_single_entry(H5F_t *f, H5C_cache_entry_t *entry_ptr, unsigned flags) * A clear and a flush are the same from the point of * view of the replacement policy and the slist. * Hence no differentiation between them. - * - * JRM -- 7/7/07 */ H5C__UPDATE_RP_FOR_FLUSH(cache_ptr, entry_ptr, FAIL) @@ -6942,9 +6566,8 @@ H5C__flush_single_entry(H5F_t *f, H5C_cache_entry_t *entry_ptr, unsigned flags) HDassert(take_ownership); - /* client is taking ownership of the entry. - * set bad magic here too so the cache will choke - * unless the entry is re-inserted properly + /* Client is taking ownership of the entry. Set bad magic here too + * so the cache will choke unless the entry is re-inserted properly */ entry_ptr->magic = H5C__H5C_CACHE_ENTRY_T_BAD_MAGIC; @@ -8002,15 +7625,6 @@ H5C_entry_in_skip_list(H5C_t *cache_ptr, H5C_cache_entry_t *target_ptr) * Programmer: Mike McGreevy * November 3, 2010 * - * Changes: Modified function to setup the slist before calling - * H%C_flush_cache(), and take it down afterwards. Note - * that the slist need not be empty after the call to - * H5C_flush_cache() since we are only flushing marked - * entries. Thus must set the clear_slist parameter - * of H5C_set_slist_enabled to TRUE. - * - * JRM -- 5/6/20 - * *------------------------------------------------------------------------- */ @@ -8412,8 +8026,6 @@ H5C__assert_flush_dep_nocycle(const H5C_cache_entry_t *entry, const H5C_cache_en * The initial need for this routine is to settle all entries * in the cache prior to construction of the metadata cache * image so that the size of the cache image can be calculated. - * However, I gather that other uses for the routine are - * under consideration. * * Return: Non-negative on success/Negative on failure or if there was * a request to flush all items and something was protected. @@ -8582,16 +8194,16 @@ done: * If the cache contains protected entries in the specified * ring, the function will fail, as protected entries cannot * be serialized. However all unprotected entries in the - * target ring should be serialized before the function - * returns failure. + * target ring should be serialized before the function + * returns failure. * * If flush dependencies appear in the target ring, the * function makes repeated passes through the index list - * serializing entries in flush dependency order. + * serializing entries in flush dependency order. * - * All entries outside the H5C_RING_SBE are marked for - * inclusion in the cache image. Entries in H5C_RING_SBE - * and below are marked for exclusion from the image. + * All entries outside the H5C_RING_SBE are marked for + * inclusion in the cache image. Entries in H5C_RING_SBE + * and below are marked for exclusion from the image. * * Return: Non-negative on success/Negative on failure or if there was * a request to flush all items and something was protected. @@ -8910,10 +8522,6 @@ done: * Programmer: Mohamad Chaarawi * 2/10/16 * - * Changes: Updated sanity checks for the possibility that the skip - * list is disabled. - * JRM 5/16/20 - * *------------------------------------------------------------------------- */ static herr_t @@ -8975,13 +8583,6 @@ H5C__generate_image(H5F_t *f, H5C_t *cache_ptr, H5C_cache_entry_t *entry_ptr) * in the parallel case, it will not detect an * entry that dirties, resizes, and/or moves * other entries during its flush. - * - * From what Quincey tells me, this test is - * sufficient for now, as any flush routine that - * does the latter will also do the former. - * - * If that ceases to be the case, further - * tests will be necessary. */ if (cache_ptr->aux_ptr != NULL) diff --git a/src/H5Cdbg.c b/src/H5Cdbg.c index 4d74a0a..0dc9756 100644 --- a/src/H5Cdbg.c +++ b/src/H5Cdbg.c @@ -259,12 +259,6 @@ H5C_dump_cache_LRU(H5C_t *cache_ptr, const char *cache_name) * Programmer: John Mainzer * 11/15/14 * - * Changes: Updated function for the slist_enabled field in H5C_t. - * Recall that to minimize slist overhead, the slist is - * empty and not maintained if cache_ptr->slist_enabled is - * false. - * JRM -- 5/6/20 - * *------------------------------------------------------------------------- */ #ifndef NDEBUG diff --git a/src/H5Cepoch.c b/src/H5Cepoch.c index f6de3ff..1b55080 100644 --- a/src/H5Cepoch.c +++ b/src/H5Cepoch.c @@ -45,7 +45,7 @@ * * As a strategy for automatic cache size reduction, the cache may insert * marker entries in the LRU list at the end of each epoch. These markers - * are then used to identify entries that have not been accessed for n + * are then used to identify entries that have not been accessed for 'n' * epochs so that they can be evicted from the cache. * ****************************************************************************/ @@ -98,7 +98,6 @@ const H5AC_class_t H5AC_EPOCH_MARKER[1] = { * * None of these functions should ever be called, so there is no point in * documenting them separately. - * JRM - 11/16/04 * ***************************************************************************/ diff --git a/src/H5Cimage.c b/src/H5Cimage.c index 6fbd936..70944be 100644 --- a/src/H5Cimage.c +++ b/src/H5Cimage.c @@ -452,10 +452,6 @@ done: * * Programmer: John Mainzer, 8/10/15 * - * Changes: Updated sanity checks for possibility that the slist - * is disabled. - * JRM -- 5/17/20 - * *------------------------------------------------------------------------- */ herr_t @@ -1579,7 +1575,6 @@ H5C_set_cache_image_config(const H5F_t *f, H5C_t *cache_ptr, H5C_cache_image_ctl /* The collective metadata write code is not currently compatible * with cache image. Until this is fixed, suppress cache image silently * if there is more than one process. - * JRM -- 11/8/16 */ if (cache_ptr->aux_ptr) { H5C_cache_image_ctl_t default_image_ctl = H5C__DEFAULT_CACHE_IMAGE_CTL; @@ -2296,22 +2291,7 @@ done: /*------------------------------------------------------------------------- * Function: H5C__prep_for_file_close__compute_fd_heights * - * Purpose: Recent modifications to flush dependency support in the - * metadata cache have removed the notion of flush dependency - * height. This is a problem for the cache image feature, - * as flush dependency height is used to order entries in the - * cache image so that flush dependency parents appear before - * flush dependency children. (Recall that the flush dependency - * height of an entry in a flush dependency relationship is the - * length of the longest path from the entry to a leaf entry -- - * that is an entry with flush dependency parents, but no - * flush dependency children. With the introduction of the - * possibility of multiple flush dependency parents, we have - * a flush partial dependency latice, not a flush dependency - * tree. But since the partial latice is acyclic, the concept - * of flush dependency height still makes sense. - * - * The purpose of this function is to compute the flush + * Purpose: The purpose of this function is to compute the flush * dependency height of all entries that appear in the cache * image. * diff --git a/src/H5Cmpio.c b/src/H5Cmpio.c index cfd0780..f154c8a 100644 --- a/src/H5Cmpio.c +++ b/src/H5Cmpio.c @@ -402,22 +402,11 @@ done: * shouldn't be used elsewhere. * * Return: Success: SUCCEED - * * Failure: FAIL * * Programmer: John Mainzer * 3/17/10 * - * Changes: With the slist optimization, the slist is not maintained - * unless a flush is in progress. Thus we can not longer use - * cache_ptr->slist_size to determine the total size of - * the entries we must insert in the candidate list. - * - * To address this, we now use cache_ptr->dirty_index_size - * instead. - * - * JRM -- 7/27/20 - * *------------------------------------------------------------------------- */ herr_t @@ -440,15 +429,14 @@ H5C_construct_candidate_list__clean_cache(H5C_t *cache_ptr) HDassert((!cache_ptr->slist_enabled) || (space_needed == cache_ptr->slist_size)); - /* Recall that while we shouldn't have any protected entries at this - * point, it is possible that some dirty entries may reside on the - * pinned list at this point. + /* We shouldn't have any protected entries at this point, but it is + * possible that some dirty entries may reside on the pinned list. */ HDassert(cache_ptr->dirty_index_size <= (cache_ptr->dLRU_list_size + cache_ptr->pel_size)); HDassert((!cache_ptr->slist_enabled) || (cache_ptr->slist_len <= (cache_ptr->dLRU_list_len + cache_ptr->pel_len))); - if (space_needed > 0) { /* we have work to do */ + if (space_needed > 0) { H5C_cache_entry_t *entry_ptr; unsigned nominated_entries_count = 0; @@ -545,12 +533,6 @@ done: * Programmer: John Mainzer * 3/17/10 * - * Changes: With the slist optimization, the slist is not maintained - * unless a flush is in progress. Updated sanity checks to - * reflect this. - * - * JRM -- 7/27/20 - * *------------------------------------------------------------------------- */ herr_t @@ -785,14 +767,8 @@ H5C_mark_entries_as_clean(H5F_t *f, unsigned ce_array_len, haddr_t *ce_array_ptr * resizes, or removals of other entries can occur as * a side effect of the flush. Hence, there is no need * for the checks for entry removal / status change - * that I ported to H5C_apply_candidate_list(). + * that are in H5C_apply_candidate_list(). * - * However, if (in addition to allowing such operations - * in the parallel case), we allow such operations outside - * of the pre_serialize / serialize routines, this may - * cease to be the case -- requiring a review of this - * point. - * JRM -- 4/7/15 */ entries_cleared = 0; entries_examined = 0; @@ -1086,8 +1062,6 @@ done: * Programmer: John Mainzer * 2/10/17 * - * Changes: None. - * *------------------------------------------------------------------------- */ static herr_t @@ -1464,12 +1438,8 @@ H5C__flush_candidates_in_ring(H5F_t *f, H5C_ring_t ring, unsigned entries_to_flu cache_ptr->entries_removed_counter = 0; cache_ptr->last_entry_removed_ptr = NULL; - /* Add this entry to the list of entries to collectively write - * - * This comment is misleading -- the entry will be added to the - * collective write list only if said list exists. - * - * JRM -- 2/9/17 + /* Add this entry to the list of entries to collectively + * write, if the list exists. */ if (H5C__flush_single_entry(f, op_ptr, op_flags) < 0) HGOTO_ERROR(H5E_CACHE, H5E_CANTFLUSH, FAIL, "can't flush entry") @@ -1491,12 +1461,6 @@ H5C__flush_candidates_in_ring(H5F_t *f, H5C_ring_t ring, unsigned entries_to_flu entry_ptr->is_protected || !entry_ptr->is_pinned)) { /* Something has happened to the pinned entry list -- start * over from the head. - * - * Recall that this code should be un-reachable at present, - * as all the operations by entries on flush that could cause - * it to be reachable are disallowed in the parallel case at - * present. Hence the following assertion which should be - * removed if the above changes. */ HDassert(!restart_scan); @@ -1505,7 +1469,13 @@ H5C__flush_candidates_in_ring(H5F_t *f, H5C_ring_t ring, unsigned entries_to_flu HDassert(!entry_ptr->is_protected); HDassert(entry_ptr->is_pinned); - HDassert(FALSE); /* see comment above */ + /* This code should be un-reachable at present, + * as all the operations by entries on flush that could cause + * it to be reachable are disallowed in the parallel case at + * present. Hence the following assertion which should be + * removed if the above changes. + */ + HDassert(FALSE); restart_scan = FALSE; diff --git a/src/H5Cpkg.h b/src/H5Cpkg.h index 23c2b78..24c0263 100644 --- a/src/H5Cpkg.h +++ b/src/H5Cpkg.h @@ -83,89 +83,6 @@ * to the HGOTO_ERROR macro, which may not be appropriate in all cases. * If so, we will need versions of the insertion and deletion macros which * do not reference the sanity checking macros. - * JRM - 5/5/04 - * - * Changes: - * - * - Removed the line: - * - * ( ( (Size) == (entry_ptr)->size ) && ( (len) != 1 ) ) || - * - * from the H5C__DLL_PRE_REMOVE_SC macro. With the addition of the - * epoch markers used in the age out based cache size reduction algorithm, - * this invariant need not hold, as the epoch markers are of size 0. - * - * One could argue that I should have given the epoch markers a positive - * size, but this would break the index_size = LRU_list_size + pl_size - * + pel_size invariant. - * - * Alternatively, I could pass the current decr_mode in to the macro, - * and just skip the check whenever epoch markers may be in use. - * - * However, any size errors should be caught when the cache is flushed - * and destroyed. Until we are tracking such an error, this should be - * good enough. - * JRM - 12/9/04 - * - * - * - In the H5C__DLL_PRE_INSERT_SC macro, replaced the lines: - * - * ( ( (len) == 1 ) && - * ( ( (head_ptr) != (tail_ptr) ) || ( (Size) <= 0 ) || - * ( (head_ptr) == NULL ) || ( (head_ptr)->size != (Size) ) - * ) - * ) || - * - * with: - * - * ( ( (len) == 1 ) && - * ( ( (head_ptr) != (tail_ptr) ) || - * ( (head_ptr) == NULL ) || ( (head_ptr)->size != (Size) ) - * ) - * ) || - * - * Epoch markers have size 0, so we can now have a non-empty list with - * zero size. Hence the "( (Size) <= 0 )" clause cause false failures - * in the sanity check. Since "Size" is typically a size_t, it can't - * take on negative values, and thus the revised clause "( (Size) < 0 )" - * caused compiler warnings. - * JRM - 12/22/04 - * - * - In the H5C__DLL_SC macro, replaced the lines: - * - * ( ( (len) == 1 ) && - * ( ( (head_ptr) != (tail_ptr) ) || ( (cache_ptr)->size <= 0 ) || - * ( (head_ptr) == NULL ) || ( (head_ptr)->size != (Size) ) - * ) - * ) || - * - * with - * - * ( ( (len) == 1 ) && - * ( ( (head_ptr) != (tail_ptr) ) || - * ( (head_ptr) == NULL ) || ( (head_ptr)->size != (Size) ) - * ) - * ) || - * - * Epoch markers have size 0, so we can now have a non-empty list with - * zero size. Hence the "( (Size) <= 0 )" clause cause false failures - * in the sanity check. Since "Size" is typically a size_t, it can't - * take on negative values, and thus the revised clause "( (Size) < 0 )" - * caused compiler warnings. - * JRM - 1/10/05 - * - * - Added the H5C__DLL_UPDATE_FOR_SIZE_CHANGE macro and the associated - * sanity checking macros. These macro are used to update the size of - * a DLL when one of its entries changes size. - * - * JRM - 9/8/05 - * - * - Added macros supporting the index list -- a doubly liked list of - * all entries in the index. This list is necessary to reduce the - * cost of visiting all entries in the cache, which was previously - * done via a scan of the hash table. - * - * JRM - 10/15/15 * ****************************************************************************/ @@ -966,28 +883,6 @@ if ( ( ( ( (head_ptr) == NULL ) || ( (tail_ptr) == NULL ) ) && \ * When modifying these macros, remember to modify the similar macros * in tst/cache.c * - * Changes: - * - * - Updated existing index macros and sanity check macros to maintain - * the clean_index_size and dirty_index_size fields of H5C_t. Also - * added macros to allow us to track entry cleans and dirties. - * - * JRM -- 11/5/08 - * - * - Updated existing index macros and sanity check macros to maintain - * the index_ring_len, index_ring_size, clean_index_ring_size, and - * dirty_index_ring_size fields of H5C_t. - * - * JRM -- 9/1/15 - * - * - Updated existing index macros and sanity checks macros to - * maintain an doubly linked list of all entries in the index. - * This is necessary to reduce the computational cost of visiting - * all entries in the index, which used to be done by scanning - * the hash table. - * - * JRM -- 10/15/15 - * ***********************************************************************/ /* H5C__HASH_TABLE_LEN is defined in H5Cpkg.h. It mut be a power of two. */ @@ -1518,9 +1413,6 @@ if ( ( (cache_ptr)->index_size != \ * * Skip list insertion and deletion macros: * - * These used to be functions, but I converted them to macros to avoid some - * function call overhead. - * **************************************************************************/ /*------------------------------------------------------------------------- @@ -1535,56 +1427,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/10/04 * - * Modifications: - * - * JRM -- 7/21/04 - * Updated function to set the in_tree flag when inserting - * an entry into the tree. Also modified the function to - * update the tree size and len fields instead of the similar - * index fields. - * - * All of this is part of the modifications to support the - * hash table. - * - * JRM -- 7/27/04 - * Converted the function H5C_insert_entry_in_tree() into - * the macro H5C__INSERT_ENTRY_IN_TREE in the hopes of - * wringing a little more speed out of the cache. - * - * Note that we don't bother to check if the entry is already - * in the tree -- if it is, H5SL_insert() will fail. - * - * QAK -- 11/27/04 - * Switched over to using skip list routines. - * - * JRM -- 6/27/06 - * Added fail_val parameter. - * - * JRM -- 8/25/06 - * Added the H5C_DO_SANITY_CHECKS version of the macro. - * - * This version maintains the slist_len_increase and - * slist_size_increase fields that are used in sanity - * checks in the flush routines. - * - * All this is needed as the fractal heap needs to be - * able to dirty, resize and/or move entries during the - * flush. - * - * JRM -- 12/13/14 - * Added code to set cache_ptr->slist_changed to TRUE - * when an entry is inserted in the slist. - * - * JRM -- 9/1/15 - * Added code to maintain the cache_ptr->slist_ring_len - * and cache_ptr->slist_ring_size arrays. - * - * JRM -- 4/29/20 - * Reworked macro to support the slist_enabled field - * of H5C_t. If slist_enabled == TRUE, the macro - * functions as before. Otherwise, the macro is a no-op, - * and the slist must be empty. - * *------------------------------------------------------------------------- */ @@ -1716,33 +1558,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/10/04 * - * Modifications: - * - * JRM -- 7/21/04 - * Updated function for the addition of the hash table. - * - * JRM - 7/27/04 - * Converted from the function H5C_remove_entry_from_tree() - * to the macro H5C__REMOVE_ENTRY_FROM_TREE in the hopes of - * wringing a little more performance out of the cache. - * - * QAK -- 11/27/04 - * Switched over to using skip list routines. - * - * JRM -- 3/28/07 - * Updated sanity checks for the new is_read_only and - * ro_ref_count fields in H5C_cache_entry_t. - * - * JRM -- 12/13/14 - * Added code to set cache_ptr->slist_changed to TRUE - * when an entry is removed from the slist. - * - * JRM -- 4/29/20 - * Reworked macro to support the slist_enabled field - * of H5C_t. If slist_enabled == TRUE, the macro - * functions as before. Otherwise, the macro is a no-op, - * and the slist must be empty. - * *------------------------------------------------------------------------- */ @@ -1853,33 +1668,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 9/07/05 * - * Modifications: - * - * JRM -- 8/27/06 - * Added the H5C_DO_SANITY_CHECKS version of the macro. - * - * This version maintains the slist_size_increase field - * that are used in sanity checks in the flush routines. - * - * All this is needed as the fractal heap needs to be - * able to dirty, resize and/or move entries during the - * flush. - * - * JRM -- 12/13/14 - * Note that we do not set cache_ptr->slist_changed to TRUE - * in this case, as the structure of the slist is not - * modified. - * - * JRM -- 9/1/15 - * Added code to maintain the cache_ptr->slist_ring_len - * and cache_ptr->slist_ring_size arrays. - * - * JRM -- 4/29/20 - * Reworked macro to support the slist_enabled field - * of H5C_t. If slist_enabled == TRUE, the macro - * functions as before. Otherwise, the macro is a no-op, - * and the slist must be empty. - * *------------------------------------------------------------------------- */ @@ -1976,9 +1764,6 @@ if ( ( (cache_ptr)->index_size != \ * * Replacement policy update macros: * - * These used to be functions, but I converted them to macros to avoid some - * function call overhead. - * **************************************************************************/ /*------------------------------------------------------------------------- @@ -2000,18 +1785,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 10/13/05 * - * Modifications: - * - * JRM -- 3/20/06 - * Modified macro to ignore pinned entries. Pinned entries - * do not appear in the data structures maintained by the - * replacement policy code, and thus this macro has nothing - * to do if called for such an entry. - * - * JRM -- 3/28/07 - * Added sanity checks using the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -2130,30 +1903,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/10/04 * - * Modifications: - * - * JRM - 7/27/04 - * Converted the function H5C_update_rp_for_eviction() to the - * macro H5C__UPDATE_RP_FOR_EVICTION in an effort to squeeze - * a bit more performance out of the cache. - * - * At least for the first cut, I am leaving the comments and - * white space in the macro. If they cause difficulties with - * the pre-processor, I'll have to remove them. - * - * JRM - 7/28/04 - * Split macro into two version, one supporting the clean and - * dirty LRU lists, and the other not. Yet another attempt - * at optimization. - * - * JRM - 3/20/06 - * Pinned entries can't be evicted, so this entry should never - * be called on a pinned entry. Added assert to verify this. - * - * JRM -- 3/28/07 - * Added sanity checks for the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -2241,32 +1990,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/6/04 * - * Modifications: - * - * JRM - 7/27/04 - * Converted the function H5C_update_rp_for_flush() to the - * macro H5C__UPDATE_RP_FOR_FLUSH in an effort to squeeze - * a bit more performance out of the cache. - * - * At least for the first cut, I am leaving the comments and - * white space in the macro. If they cause difficulties with - * pre-processor, I'll have to remove them. - * - * JRM - 7/28/04 - * Split macro into two versions, one supporting the clean and - * dirty LRU lists, and the other not. Yet another attempt - * at optimization. - * - * JRM - 3/20/06 - * While pinned entries can be flushed, they don't reside in - * the replacement policy data structures when unprotected. - * Thus I modified this macro to do nothing if the entry is - * pinned. - * - * JRM - 3/28/07 - * Added sanity checks based on the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -2499,34 +2222,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/17/04 * - * Modifications: - * - * JRM - 7/27/04 - * Converted the function H5C_update_rp_for_insertion() to the - * macro H5C__UPDATE_RP_FOR_INSERTION in an effort to squeeze - * a bit more performance out of the cache. - * - * At least for the first cut, I am leaving the comments and - * white space in the macro. If they cause difficulties with - * pre-processor, I'll have to remove them. - * - * JRM - 7/28/04 - * Split macro into two version, one supporting the clean and - * dirty LRU lists, and the other not. Yet another attempt - * at optimization. - * - * JRM - 3/10/06 - * This macro should never be called on a pinned entry. - * Inserted an assert to verify this. - * - * JRM - 8/9/06 - * Not any more. We must now allow insertion of pinned - * entries. Updated macro to support this. - * - * JRM - 3/28/07 - * Added sanity checks using the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -2637,31 +2332,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/17/04 * - * Modifications: - * - * JRM - 7/27/04 - * Converted the function H5C_update_rp_for_protect() to the - * macro H5C__UPDATE_RP_FOR_PROTECT in an effort to squeeze - * a bit more performance out of the cache. - * - * At least for the first cut, I am leaving the comments and - * white space in the macro. If they cause difficulties with - * pre-processor, I'll have to remove them. - * - * JRM - 7/28/04 - * Split macro into two version, one supporting the clean and - * dirty LRU lists, and the other not. Yet another attempt - * at optimization. - * - * JRM - 3/17/06 - * Modified macro to attempt to remove pinned entriese from - * the pinned entry list instead of from the data structures - * maintained by the replacement policy. - * - * JRM - 3/28/07 - * Added sanity checks based on the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -2927,12 +2597,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 8/23/06 * - * Modifications: - * - * JRM -- 3/28/07 - * Added sanity checks based on the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -3060,12 +2724,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 3/22/06 * - * Modifications: - * - * JRM -- 3/28/07 - * Added sanity checks based on the new is_read_only and - * ro_ref_count fields of struct H5C_cache_entry_t. - * *------------------------------------------------------------------------- */ @@ -3181,27 +2839,6 @@ if ( ( (cache_ptr)->index_size != \ * * Programmer: John Mainzer, 5/19/04 * - * Modifications: - * - * JRM - 7/27/04 - * Converted the function H5C_update_rp_for_unprotect() to - * the macro H5C__UPDATE_RP_FOR_UNPROTECT in an effort to - * squeeze a bit more performance out of the cache. - * - * At least for the first cut, I am leaving the comments and - * white space in the macro. If they cause difficulties with - * pre-processor, I'll have to remove them. - * - * JRM - 7/28/04 - * Split macro into two version, one supporting the clean and - * dirty LRU lists, and the other not. Yet another attempt - * at optimization. - * - * JRM - 3/17/06 - * Modified macro to put pinned entries on the pinned entry - * list instead of inserting them in the data structures - * maintained by the replacement policy. - * *------------------------------------------------------------------------- */ @@ -3608,24 +3245,9 @@ typedef struct H5C_tag_info_t { * While the cache was designed with multiple replacement policies in mind, * at present only a modified form of LRU is supported. * - * JRM - 4/26/04 - * - * Profiling has indicated that searches in the instance of H5TB_TREE are - * too expensive. To deal with this issue, I have augmented the cache - * with a hash table in which all entries will be stored. Given the - * advantages of flushing entries in increasing address order, the TBBT - * is retained, but only dirty entries are stored in it. At least for - * now, we will leave entries in the TBBT after they are flushed. - * - * Note that index_size and index_len now refer to the total size of - * and number of entries in the hash table. - * - * JRM - 7/19/04 - * - * The TBBT has since been replaced with a skip list. This change - * greatly predates this note. - * - * JRM - 9/26/05 + * The cache has a hash table in which all entries are stored. Given the + * advantages of flushing entries in increasing address order, a skip list + * is used to track dirty entries. * * magic: Unsigned 32 bit integer always set to H5C__H5C_T_MAGIC. * This field is used to validate pointers to instances of @@ -3719,13 +3341,8 @@ typedef struct H5C_tag_info_t { * The cache requires an index to facilitate searching for entries. The * following fields support that index. * - * Addendum: JRM -- 10/14/15 - * - * We sometimes need to visit all entries in the cache. In the past, this - * was done by scanning the hash table. However, this is expensive, and - * we have come to scan the hash table often enough that it has become a - * performance issue. To repair this, I have added code to maintain a - * list of all entries in the index -- call this list the index list. + * We sometimes need to visit all entries in the cache, they are stored in + * the index list. * * The index list is maintained by the same macros that maintain the * index, and must have the same length and size as the index proper. @@ -3759,12 +3376,10 @@ typedef struct H5C_tag_info_t { * dirty_index_size == index_size. * * WARNING: - * - * The value of the clean_index_size must not be mistaken - * for the current clean size of the cache. Rather, the - * clean size of the cache is the current value of - * clean_index_size plus the amount of empty space (if any) - * in the cache. + * The value of the clean_index_size must not be mistaken for + * the current clean size of the cache. Rather, the clean size + * of the cache is the current value of clean_index_size plus + * the amount of empty space (if any) in the cache. * * clean_index_ring_size: Array of size_t of length H5C_RING_NTYPES used to * maintain the sum of the sizes of all clean entries in the @@ -3786,7 +3401,7 @@ typedef struct H5C_tag_info_t { * H5C__HASH_TABLE_LEN. At present, this value is a power * of two, not the usual prime number. * - * I hope that the variable size of cache elements, the large + * Hopefully the variable size of cache elements, the large * hash table size, and the way in which HDF5 allocates space * will combine to avoid problems with periodicity. If so, we * can use a trivial hash function (a bit-and and a 3 bit left @@ -3827,11 +3442,10 @@ typedef struct H5C_tag_info_t { * This field is NULL if the index is empty. * * - * With the addition of the take ownership flag, it is possible that - * an entry may be removed from the cache as the result of the flush of - * a second entry. In general, this causes little trouble, but it is - * possible that the entry removed may be the next entry in the scan of - * a list. In this case, we must be able to detect the fact that the + * It is possible that an entry may be removed from the cache as the result + * of the flush of a second entry. In general, this causes little trouble, + * but it is possible that the entry removed may be the next entry in the + * scan of a list. In this case, we must be able to detect the fact that the * entry has been removed, so that the scan doesn't attempt to proceed with * an entry that is no longer in the cache. * @@ -3859,29 +3473,19 @@ typedef struct H5C_tag_info_t { * one. * * entry_watched_for_removal: Pointer to an instance of H5C_cache_entry_t - * which contains the 'next' entry for an iteration. Removing - * this entry must trigger a rescan of the iteration, so each - * entry removed from the cache is compared against this pointer - * and the pointer is reset to NULL if the watched entry is - * removed. - * (This functions similarly to a "dead man's switch") + * which contains the 'next' entry for an iteration. Removing + * this entry must trigger a rescan of the iteration, so each + * entry removed from the cache is compared against this pointer + * and the pointer is reset to NULL if the watched entry is + * removed. (This functions similarly to a "dead man's switch") * * * When we flush the cache, we need to write entries out in increasing * address order. An instance of a skip list is used to store dirty entries in - * sorted order. Whether it is cheaper to sort the dirty entries as needed, - * or to maintain the list is an open question. At a guess, it depends - * on how frequently the cache is flushed. We will see how it goes. - * - * For now at least, I will not remove dirty entries from the list as they - * are flushed. (this has been changed -- dirty entries are now removed from - * the skip list as they are flushed. JRM - 10/25/05) - * - * Update 4/21/20: + * sorted order. * - * Profiling indicates that the cost of maintaining the skip list is - * significant. As it is only used on flush and close, maintaining it - * only when needed is an obvious optimization. + * The cost of maintaining the skip list is significant. As it is only used + * on flush and close, it is maintained only when needed. * * To do this, we add a flag to control maintenanace of the skip list. * This flag is initially set to FALSE, which disables all operations @@ -3940,30 +3544,21 @@ typedef struct H5C_tag_info_t { * order, which results in significant savings. * * b) It facilitates checking for adjacent dirty entries when - * attempting to evict entries from the cache. While we - * don't use this at present, I hope that this will allow - * some optimizations when I get to it. + * attempting to evict entries from the cache. * * num_last_entries: The number of entries in the cache that can only be * flushed after all other entries in the cache have - * been flushed. At this time, this will only ever be - * one entry (the superblock), and the code has been - * protected with HDasserts to enforce this. This restraint - * can certainly be relaxed in the future if the need for - * multiple entries being flushed last arises, though - * explicit tests for that case should be added when said - * HDasserts are removed. - * - * Update: There are now two possible last entries - * (superblock and file driver info message). This - * number will probably increase as we add superblock - * messages. JRM -- 11/18/14 - * - * With the addition of the fractal heap, the cache must now deal with - * the case in which entries may be dirtied, moved, or have their sizes - * changed during a flush. To allow sanity checks in this situation, the - * following two fields have been added. They are only compiled in when - * H5C_DO_SANITY_CHECKS is TRUE. + * been flushed. + * + * Note: At this time, the this field will only be applied to + * two types of entries: the superblock and the file driver info + * message. The code utilizing these flags is protected with + * HDasserts to enforce this. + * + * The cache must deal with the case in which entries may be dirtied, moved, + * or have their sizes changed during a flush. To allow sanity checks in this + * situation, the following two fields have been added. They are only + * compiled in when H5C_DO_SANITY_CHECKS is TRUE. * * slist_len_increase: Number of entries that have been added to the * slist since the last time this field was set to zero. @@ -4020,8 +3615,8 @@ typedef struct H5C_tag_info_t { * * * For very frequently used entries, the protect/unprotect overhead can - * become burdensome. To avoid this overhead, I have modified the cache - * to allow entries to be "pinned". A pinned entry is similar to a + * become burdensome. To avoid this overhead, the cache + * allows entries to be "pinned". A pinned entry is similar to a * protected entry, in the sense that it cannot be evicted, and that * the entry can be modified at any time. * @@ -4072,29 +3667,15 @@ typedef struct H5C_tag_info_t { * The cache must have a replacement policy, and the fields supporting this * policy must be accessible from this structure. * - * While there has been interest in several replacement policies for - * this cache, the initial development schedule is tight. Thus I have - * elected to support only a modified LRU (least recently used) policy - * for the first cut. - * - * To further simplify matters, I have simply included the fields needed - * by the modified LRU in this structure. When and if we add support for - * other policies, it will probably be easiest to just add the necessary - * fields to this structure as well -- we only create one instance of this - * structure per file, so the overhead is not excessive. - * - * * Fields supporting the modified LRU policy: * - * See most any OS text for a discussion of the LRU replacement policy. - * * When operating in parallel mode, we must ensure that a read does not * cause a write. If it does, the process will hang, as the write will * be collective and the other processes will not know to participate. * - * To deal with this issue, I have modified the usual LRU policy by adding + * To deal with this issue, the usual LRU policy has been modified by adding * clean and dirty LRU lists to the usual LRU list. In general, these - * lists are only exist in parallel builds. + * lists only exist in parallel builds. * * The clean LRU list is simply the regular LRU list with all dirty cache * entries removed. @@ -4191,7 +3772,7 @@ typedef struct H5C_tag_info_t { * While the default cache size is adequate for most cases, we can run into * cases where the default is too small. Ideally, we will let the user * adjust the cache size as required. However, this is not possible in all - * cases. Thus I have added automatic cache size adjustment code. + * cases, so the cache has automatic cache size adjustment code. * * The configuration for the automatic cache size adjustment is stored in * the structure described below: @@ -4222,10 +3803,9 @@ typedef struct H5C_tag_info_t { * * resize_enabled: This is another convenience flag which is set whenever * a new set of values for resize_ctl are provided. Very - * simply, + * simply: * - * resize_enabled = size_increase_possible || - * size_decrease_possible; + * resize_enabled = size_increase_possible || size_decrease_possible; * * cache_full: Boolean flag used to keep track of whether the cache is * full, so we can refrain from increasing the size of a @@ -4248,11 +3828,6 @@ typedef struct H5C_tag_info_t { * and to prevent the infinite recursion that would otherwise * occur. * - * Note that this issue is not hypothetical -- this field - * was added 12/29/15 to fix a bug exposed in the testing - * of changes to the file driver info superblock extension - * management code needed to support rings. - * * msic_in_progress: As the metadata cache has become re-entrant, and as * the free space manager code has become more tightly * integrated with the metadata cache, it is possible that @@ -4265,11 +3840,6 @@ typedef struct H5C_tag_info_t { * and prevent the infinite regression that would otherwise * occur. * - * Note that this is issue is not hypothetical -- this field - * was added 2/16/17 to address this issue when it was - * exposed by modifications to test/fheap.c to cause it to - * use paged allocation. - * * resize_ctl: Instance of H5C_auto_size_ctl_t containing configuration * data for automatic cache resizing. * @@ -4362,8 +3932,8 @@ typedef struct H5C_tag_info_t { * call to H5C_protect(). * * image_loaded: Boolean flag indicating that the metadata cache has - * loaded the metadata cache image as directed by the - * MDC cache image superblock extension message. + * loaded the metadata cache image as directed by the + * MDC cache image superblock extension message. * * delete_image: Boolean flag indicating whether the metadata cache image * superblock message should be deleted and the cache image @@ -4476,11 +4046,11 @@ typedef struct H5C_tag_info_t { * free space manager metadata. * * mdfsm_settled: Boolean flag indicating whether the meta data free space - * manager is settled -- i.e. whether the correct space has - * been allocated for it in the file. + * manager is settled -- i.e. whether the correct space has + * been allocated for it in the file. * - * Note that the name of this field is deceptive. In the - * multi file case, the flag applies only to free space + * Note that the name of this field is deceptive. In the + * multi-file case, the flag applies only to free space * managers that are involved in allocating space for free * space managers. * @@ -4699,16 +4269,16 @@ typedef struct H5C_tag_info_t { * close, this field should only be set at that time. * * images_read: Integer field containing the number of cache images - * read from file. Note that reading an image is different - * from loading it -- reading the image means just that, - * while loading the image refers to decoding it and loading - * it into the metadata cache. + * read from file. Note that reading an image is different + * from loading it -- reading the image means just that, + * while loading the image refers to decoding it and loading + * it into the metadata cache. * - * In the serial case, image_read should always equal - * images_loaded. However, in the parallel case, the - * image should only be read by process 0. All other - * processes should receive the cache image via a broadcast - * from process 0. + * In the serial case, image_read should always equal + * images_loaded. However, in the parallel case, the + * image should only be read by process 0. All other + * processes should receive the cache image via a broadcast + * from process 0. * * images_loaded: Integer field containing the number of cache images * loaded since the last time statistics were reset. @@ -4719,21 +4289,19 @@ typedef struct H5C_tag_info_t { * should only change on those events. * * last_image_size: Size of the most recently loaded metadata cache image - * loaded into the cache, or zero if no image has been - * loaded. + * loaded into the cache, or zero if no image has been loaded. * - * At present, at most one cache image can be loaded into - * the metadata cache for any given file, and this image - * will be loaded either on the first protect, or on file - * close if no entry is protected before then. + * At present, at most one cache image can be loaded into + * the metadata cache for any given file, and this image + * will be loaded either on the first protect, or on file + * close if no entry is protected before then. * * * Fields for tracking prefetched entries. Note that flushes and evictions * of prefetched entries are tracked in the flushes and evictions arrays * discussed above. * - * prefetches: Number of prefetched entries that are loaded to the - * cache. + * prefetches: Number of prefetched entries that are loaded to the cache. * * dirty_prefetches: Number of dirty prefetched entries that are loaded * into the cache. @@ -4741,9 +4309,9 @@ typedef struct H5C_tag_info_t { * prefetch_hits: Number of prefetched entries that are actually used. * * - * As entries are now capable of moving, loading, dirtying, and deleting - * other entries in their pre_serialize and serialize callbacks, it has - * been necessary to insert code to restart scans of lists so as to avoid + * Entries may move, load, dirty, and delete + * other entries in their pre_serialize and serialize callbacks, there is + * code to restart scans of lists so as to avoid * improper behavior if the next entry in the list is the target of one on * these operations. * @@ -4757,9 +4325,9 @@ typedef struct H5C_tag_info_t { * entry in the scan. * * LRU_scan_restarts: Number of times a scan of the LRU list (that contains - * calls to H5C__flush_single_entry()) has been restarted to - * avoid potential issues with change of status of the next - * entry in the scan. + * calls to H5C__flush_single_entry()) has been restarted to + * avoid potential issues with change of status of the next + * entry in the scan. * * index_scan_restarts: Number of times a scan of the index has been * restarted to avoid potential issues with load, insertion @@ -4794,14 +4362,14 @@ typedef struct H5C_tag_info_t { * flushed in the current epoch. * * max_size: Array of size_t of length H5C__MAX_NUM_TYPE_IDS + 1. The cells - * are used to record the maximum size of any single entry + * are used to record the maximum size of any single entry * with type id equal to the array index that has resided in * the cache in the current epoch. * * max_pins: Array of size_t of length H5C__MAX_NUM_TYPE_IDS + 1. The cells - * are used to record the maximum number of times that any single - * entry with type id equal to the array index that has been - * marked as pinned in the cache in the current epoch. + * are used to record the maximum number of times that any single + * entry with type id equal to the array index that has been + * marked as pinned in the cache in the current epoch. * * * Fields supporting testing: @@ -4811,9 +4379,9 @@ typedef struct H5C_tag_info_t { * the processes mpi rank. * * get_entry_ptr_from_addr_counter: Counter used to track the number of - * times the H5C_get_entry_ptr_from_addr() function has been - * called successfully. This field is only defined when - * NDEBUG is not #defined. + * times the H5C_get_entry_ptr_from_addr() function has been + * called successfully. This field is only defined when + * NDEBUG is not #defined. * ****************************************************************************/ diff --git a/src/H5Cprivate.h b/src/H5Cprivate.h index 6a661d2..949c3e1 100644 --- a/src/H5Cprivate.h +++ b/src/H5Cprivate.h @@ -42,8 +42,6 @@ /* This sanity checking constant was picked out of the air. Increase * or decrease it if appropriate. Its purposes is to detect corrupt * object sizes, so it probably doesn't matter if it is a bit big. - * - * JRM - 5/17/04 */ #define H5C_MAX_ENTRY_SIZE ((size_t)(32 * 1024 * 1024)) @@ -978,8 +976,6 @@ typedef int H5C_ring_t; * * The fields of this structure are discussed individually below: * - * JRM - 4/26/04 - * * magic: Unsigned 32 bit integer that must always be set to * H5C__H5C_CACHE_ENTRY_T_MAGIC when the entry is valid. * The field must be set to H5C__H5C_CACHE_ENTRY_T_BAD_MAGIC @@ -1100,15 +1096,9 @@ typedef int H5C_ring_t; * be unpinned (and possibly unprotected) during the * flush. * - * JRM -- 3/16/06 - * * in_slist: Boolean flag indicating whether the entry is in the skip list - * As a general rule, entries are placed in the list when they - * are marked dirty. However they may remain in the list after - * being flushed. - * - * Update: Dirty entries are now removed from the skip list - * when they are flushed. + * As a general rule, entries are placed in the list when they are + * marked dirty. * * flush_marker: Boolean flag indicating that the entry is to be flushed * the next time H5C_flush_cache() is called with the @@ -1116,24 +1106,13 @@ typedef int H5C_ring_t; * the entry is flushed for whatever reason. * * flush_me_last: Boolean flag indicating that this entry should not be - * flushed from the cache until all other entries without - * the flush_me_last flag set have been flushed. - * - * Note: + * flushed from the cache until all other entries without the + * flush_me_last flag set have been flushed. * - * At this time, the flush_me_last - * flag will only be applied to one entry, the superblock, - * and the code utilizing these flags is protected with HDasserts - * to enforce this. This restraint can certainly be relaxed in - * the future if the need for multiple entries getting flushed - * last or collectively arises, though the code allowing for that - * will need to be expanded and tested appropriately if that - * functionality is desired. - * - * Update: There are now two possible last entries - * (superblock and file driver info message). This - * number will probably increase as we add superblock - * messages. JRM -- 11/18/14 + * Note: At this time, the flush_me_last flag will only be applied to + * two types of entries: the superblock and the file driver info + * message. The code utilizing these flags is protected with + * HDasserts to enforce this. * * clear_on_unprotect: Boolean flag used only in PHDF5. When H5C is used * to implement the metadata cache In the parallel case, only @@ -1228,8 +1207,6 @@ typedef int H5C_ring_t; * If there are multiple entries in any hash bin, they are stored in a doubly * linked list. * - * Addendum: JRM -- 10/14/15 - * * We have come to scan all entries in the cache frequently enough that * the cost of doing so by scanning the hash table has become unacceptable. * To reduce this cost, the index now also maintains a doubly linked list @@ -1691,8 +1668,6 @@ typedef struct H5C_cache_entry_t { * * The fields of this structure are discussed individually below: * - * JRM - 8/5/15 - * * magic: Unsigned 32 bit integer that must always be set to * H5C_IMAGE_ENTRY_T_MAGIC when the entry is valid. * The field must be set to H5C_IMAGE_ENTRY_T_BAD_MAGIC @@ -1855,7 +1830,7 @@ typedef struct H5C_image_entry_t { * H5C_auto_size_ctl_t passed to the cache must have a known * version number, or an error will be flagged. * - * report_fcn: Pointer to the function that is to be called to report + * rpt_fcn: Pointer to the function that is to be called to report * activities each time the auto cache resize code is executed. If the * field is NULL, no call is made. * @@ -1978,10 +1953,6 @@ typedef struct H5C_image_entry_t { * performance, however the above flash increment algorithm will not be * triggered. * - * Hopefully, the add space algorithm detailed above will be sufficient - * for the performance problems encountered to date. However, we should - * expect to revisit the issue. - * * flash_multiple: Double containing the multiple described above in the * H5C_flash_incr__add_space section of the discussion of the * flash_incr_mode section. This field is ignored unless flash_incr_mode @@ -2048,8 +2019,8 @@ typedef struct H5C_image_entry_t { * The field is a double containing the multiplier used to derive the * new cache size from the old if a cache size decrement is triggered. * The decrement must be in the range 0.0 (in which case the cache will - * try to contract to its minimum size) to 1.0 (in which case the - * cache will never shrink). + * try to contract to its minimum size) to 1.0 (in which case the + * cache will never shrink). * * apply_max_decrement: Boolean flag used to determine whether decrements * in cache size are to be limited by the max_decrement field. @@ -1501,8 +1501,6 @@ done: * * Programmer: JRM -- 6/10/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -1581,8 +1579,6 @@ done: * * Programmer: JRM -- 6/10/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -1678,8 +1674,6 @@ done: * * Programmer: NAF -- 5/19/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -1779,8 +1773,6 @@ done: * * Programmer: NAF -- 5/14/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t diff --git a/src/H5FDint.c b/src/H5FDint.c index e1cb5ff..c5b8713 100644 --- a/src/H5FDint.c +++ b/src/H5FDint.c @@ -346,8 +346,6 @@ done: * * Programmer: JRM -- 6/10/20 * - * Changes: None - * *------------------------------------------------------------------------- */ herr_t @@ -558,8 +556,6 @@ done: * * Programmer: JRM -- 6/10/20 * - * Changes: None - * *------------------------------------------------------------------------- */ herr_t @@ -742,8 +738,6 @@ done: * * Programmer: NAF -- 5/13/21 * - * Changes: None - * *------------------------------------------------------------------------- */ static herr_t @@ -1066,8 +1060,6 @@ done: * * Programmer: NAF -- 3/29/21 * - * Changes: None - * *------------------------------------------------------------------------- */ herr_t @@ -1232,8 +1224,6 @@ done: * * Programmer: NAF -- 5/19/21 * - * Changes: None - * *------------------------------------------------------------------------- */ herr_t @@ -1387,8 +1377,6 @@ done: * * Programmer: NAF -- 5/13/21 * - * Changes: None - * *------------------------------------------------------------------------- */ static herr_t @@ -1709,8 +1697,6 @@ done: * * Programmer: NAF -- 3/29/21 * - * Changes: None - * *------------------------------------------------------------------------- */ herr_t @@ -1867,8 +1853,6 @@ done: * * Programmer: NAF -- 5/19/21 * - * Changes: None - * *------------------------------------------------------------------------- */ herr_t diff --git a/src/H5FDmpi.c b/src/H5FDmpi.c index e71c739..b7b7489 100644 --- a/src/H5FDmpi.c +++ b/src/H5FDmpi.c @@ -40,16 +40,6 @@ * Programmer: Quincey Koziol * Friday, January 30, 2004 * - * Changes: Reworked function to use the ctl callback so we can get - * rid of H5FD_class_mpi_t. Since there are no real limits - * on what the ctl callback can do, its file parameter can't - * be constant. Thus, I had to remove the const qualifier - * on this functions file parameter as well. Note also the - * circumlocution required to use the ctl callbacks output - * parameter to pass back the rank without introducing - * compiler warnings. - * JRM -- 8/13/21 - * *------------------------------------------------------------------------- */ int @@ -92,16 +82,6 @@ done: * Programmer: Quincey Koziol * Friday, January 30, 2004 * - * Changes: Reworked function to use the ctl callback so we can get - * rid of H5FD_class_mpi_t. Since there are no real limits - * on what the ctl callback can do, its file parameter can't - * be constant. Thus, I had to remove the const qualifier - * on this functions file parameter as well. Note also the - * circumlocution required to use the ctl callbacks output - * parameter to pass back the rank without introducing - * compiler warnings. - * JRM -- 8/13/21 - * *------------------------------------------------------------------------- */ int @@ -145,16 +125,6 @@ done: * Programmer: Quincey Koziol * Friday, January 30, 2004 * - * Changes: Reworked function to use the ctl callback so we can get - * rid of H5FD_class_mpi_t. Since there are no real limits - * on what the ctl callback can do, its file parameter can't - * be constant. Thus, I had to remove the const qualifier - * on this functions file parameter as well. Note also the - * circumlocution required to use the ctl callbacks output - * parameter to pass back the rank without introducing - * compiler warnings. - * JRM -- 8/13/21 - * *------------------------------------------------------------------------- */ MPI_Comm diff --git a/src/H5FDsubfiling/H5FDioc_int.c b/src/H5FDsubfiling/H5FDioc_int.c index 42f088e..ce5a000 100644 --- a/src/H5FDsubfiling/H5FDioc_int.c +++ b/src/H5FDsubfiling/H5FDioc_int.c @@ -91,7 +91,6 @@ cast_to_void(const void *data) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ herr_t @@ -263,7 +262,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ herr_t diff --git a/src/H5FDsubfiling/H5FDioc_threads.c b/src/H5FDsubfiling/H5FDioc_threads.c index fd6fc01..abf816d 100644 --- a/src/H5FDsubfiling/H5FDioc_threads.c +++ b/src/H5FDsubfiling/H5FDioc_threads.c @@ -105,8 +105,6 @@ static void ioc_io_queue_add_entry(ioc_data_t *ioc_data, sf_work_request_t *wk_r * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ int @@ -264,8 +262,6 @@ finalize_ioc_threads(void *_sf_context) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static HG_THREAD_RETURN_TYPE @@ -339,7 +335,6 @@ ioc_thread_main(void *arg) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ static int @@ -493,8 +488,6 @@ translate_opcode(io_op_t op) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static HG_THREAD_RETURN_TYPE @@ -591,8 +584,6 @@ handle_work_request(void *arg) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ void @@ -612,8 +603,6 @@ H5FD_ioc_begin_thread_exclusive(void) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ void @@ -679,8 +668,6 @@ from the thread pool threads... * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static int @@ -870,8 +857,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static int @@ -1217,8 +1202,6 @@ done: * Programmer: John Mainzer * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ @@ -1283,8 +1266,6 @@ done: * * Programmer: JRM -- 11/6/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ static ioc_io_queue_entry_t * @@ -1338,8 +1319,6 @@ ioc_io_queue_alloc_entry(void) * * Programmer: JRM -- 11/7/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ static void @@ -1461,8 +1440,6 @@ ioc_io_queue_add_entry(ioc_data_t *ioc_data, sf_work_request_t *wk_req_ptr) * * Programmer: JRM -- 11/7/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ /* TODO: Keep an eye on statistics and optimize this algorithm if necessary. While it is O(N) @@ -1629,8 +1606,6 @@ ioc_io_queue_dispatch_eligible_entries(ioc_data_t *ioc_data, hbool_t try_lock) * * Programmer: JRM -- 11/7/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ static void @@ -1715,8 +1690,6 @@ ioc_io_queue_complete_entry(ioc_data_t *ioc_data, ioc_io_queue_entry_t *entry_pt * * Programmer: JRM -- 11/6/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ static void diff --git a/src/H5FDsubfiling/H5FDsubfile_int.c b/src/H5FDsubfiling/H5FDsubfile_int.c index d4aef35..4c583e8 100644 --- a/src/H5FDsubfiling/H5FDsubfile_int.c +++ b/src/H5FDsubfiling/H5FDsubfile_int.c @@ -65,8 +65,6 @@ * * Programmer: JRM -- 12/13/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -280,8 +278,6 @@ done: * * Programmer: JRM -- 1/18/22 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t diff --git a/src/H5FDsubfiling/H5FDsubfiling.c b/src/H5FDsubfiling/H5FDsubfiling.c index afdf073..e086190 100644 --- a/src/H5FDsubfiling/H5FDsubfiling.c +++ b/src/H5FDsubfiling/H5FDsubfiling.c @@ -429,8 +429,6 @@ done: * Programmer: John Mainzer * 9/10/17 * - * Changes: None. - * *------------------------------------------------------------------------- */ herr_t @@ -945,8 +943,6 @@ done: * Programmer: John Mainzer * 9/8/17 * - * Modifications: - * *------------------------------------------------------------------------- */ static void * @@ -1028,8 +1024,6 @@ done: * Programmer: John Mainzer * 9/8/17 * - * Modifications: - * *------------------------------------------------------------------------- */ static void * @@ -1072,8 +1066,6 @@ done: * Programmer: John Mainzer * 9/8/17 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2055,8 +2047,6 @@ done: * * Programmer: RAW -- ??/??/21 * - * Changes: None. - * * Notes: Thus function doesn't actually implement vector read. * Instead, it comverts the vector read call into a series * of scalar read calls. Fix this when time permits. @@ -2219,8 +2209,6 @@ done: * * Programmer: RAW -- ??/??/21 * - * Changes: None. - * * Notes: Thus function doesn't actually implement vector write. * Instead, it comverts the vector write call into a series * of scalar read calls. Fix this when time permits. diff --git a/src/H5FDsubfiling/H5subfiling_common.c b/src/H5FDsubfiling/H5subfiling_common.c index e4dcf25..58f3643 100644 --- a/src/H5FDsubfiling/H5subfiling_common.c +++ b/src/H5FDsubfiling/H5subfiling_common.c @@ -596,7 +596,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ herr_t @@ -1709,7 +1708,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ static herr_t @@ -1898,7 +1896,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ static herr_t @@ -1961,8 +1958,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static herr_t @@ -2038,8 +2033,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static void @@ -2091,8 +2084,6 @@ clear_fid_map_entry(uint64_t file_id, int64_t sf_context_id) * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ static herr_t @@ -2653,7 +2644,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ /*------------------------------------------------------------------------- @@ -2678,7 +2668,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. *------------------------------------------------------------------------- */ herr_t @@ -2980,8 +2969,6 @@ done: * Programmer: Richard Warren * 7/17/2020 * - * Changes: Initial Version/None. - * *------------------------------------------------------------------------- */ int64_t diff --git a/src/H5detect.c b/src/H5detect.c index a491343..daf7708 100644 --- a/src/H5detect.c +++ b/src/H5detect.c @@ -839,7 +839,7 @@ bit.\n"; fprintf(rawoutstream, " *\t\t\t"); } - fprintf(rawoutstream, " *\n * Modifications:\n *\n"); + fprintf(rawoutstream, " *\n"); fprintf(rawoutstream, " *\tDO NOT MAKE MODIFICATIONS TO THIS FILE!\n"); fprintf(rawoutstream, " *\tIt was generated by code in `H5detect.c'.\n"); diff --git a/src/H5make_libsettings.c b/src/H5make_libsettings.c index a428062..88a6d7d 100644 --- a/src/H5make_libsettings.c +++ b/src/H5make_libsettings.c @@ -230,7 +230,7 @@ information about the library build configuration\n"; HDfprintf(rawoutstream, " *\t\t\t"); } - HDfprintf(rawoutstream, " *\n * Modifications:\n *\n"); + HDfprintf(rawoutstream, " *\n"); HDfprintf(rawoutstream, " *\tDO NOT MAKE MODIFICATIONS TO THIS FILE!\n"); HDfprintf(rawoutstream, " *\tIt was generated by code in `H5make_libsettings.c'.\n"); @@ -105,8 +105,6 @@ static hsize_t values_used[WRT_N]; * Programmer: Robb Matzke * Tuesday, November 24, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static hsize_t @@ -153,8 +151,6 @@ randll(hsize_t limit, int current_index) * Programmer: Robb Matzke * Wednesday, July 15, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -196,8 +192,6 @@ is_sparse(void) * Programmer: Raymond Lu * Wednesday, April 18, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ static fsizes_t @@ -266,8 +260,6 @@ error: * Programmer: Robb Matzke * Thursday, August 6, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ /* Disable warning for "format not a string literal" here -QAK */ @@ -332,10 +324,6 @@ H5_GCC_CLANG_DIAG_ON("format-nonliteral") * Programmer: Robb Matzke * Wednesday, April 8, 1998 * - * Modifications: - * Robb Matzke, 15 Jul 1998 - * Addresses are written to the file DNAME instead of stdout. - * *------------------------------------------------------------------------- */ static int @@ -485,8 +473,6 @@ error: * Programmer: Robb Matzke * Friday, April 10, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -591,8 +577,6 @@ error: * Programmer: Albert Chent * Mar 28, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -757,15 +741,6 @@ error: * Programmer: Robb Matzke * Friday, April 10, 1998 * - * Modifications: - * Albert Cheng, 2002/03/28 - * Added command option -fsize. - * Albert Cheng, 2002/04/19 - * Added command option -c. - * - * Raymond Lu, 2007/05/25 - * Added similar tests for SEC2 and STDIO drivers. - * *------------------------------------------------------------------------- */ int diff --git a/test/bittests.c b/test/bittests.c index 3fbd096..285f404 100644 --- a/test/bittests.c +++ b/test/bittests.c @@ -37,8 +37,6 @@ * Programmer: Robb Matzke * Tuesday, June 16, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -154,8 +152,6 @@ failed: * Programmer: Robb Matzke * Tuesday, June 16, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -280,8 +276,6 @@ failed: * Programmer: Raymond Lu * Monday, April 12, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -419,8 +413,6 @@ failed: * Programmer: Raymond Lu * Monday, April 12, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -510,8 +502,6 @@ failed: * Programmer: Raymond Lu * Monday, April 12, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -584,8 +574,6 @@ failed: * Programmer: Raymond Lu * Monday, April 12, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -688,8 +676,6 @@ failed: * Programmer: Robb Matzke * Tuesday, June 16, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -808,8 +794,6 @@ failed: * Programmer: Robb Matzke * Tuesday, June 16, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t diff --git a/test/cache.c b/test/cache.c index 666615b..3c107f2 100644 --- a/test/cache.c +++ b/test/cache.c @@ -1969,10 +1969,6 @@ smoke_check_8(int express_test, unsigned paged) * Programmer: John Mainzer * 8/1/07 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2287,10 +2283,6 @@ smoke_check_9(int express_test, unsigned paged) * Programmer: John Mainzer * 8/1/07 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2600,8 +2592,6 @@ smoke_check_10(int express_test, unsigned paged) * Programmer: John Mainzer * 6/24/04 * - * Modifications: - * *------------------------------------------------------------------------- */ static unsigned @@ -2812,12 +2802,6 @@ write_permitted_check(int * Programmer: John Mainzer * 8/10/06 * - * Modifications: - * - * Updated tests to accommodate the case in which the - * slist is disabled. - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -3093,8 +3077,6 @@ check_insert_entry(unsigned paged) * Programmer: John Mainzer * 1/10/05 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -3183,14 +3165,6 @@ check_flush_cache(unsigned paged) * Programmer: John Mainzer * 1/12/05 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -3252,11 +3226,6 @@ check_flush_cache__empty_cache(H5F_t *file_ptr) * Programmer: John Mainzer * 1/14/05 * - * Modifications: - * - * JRM -- 4/5/06 - * Added pinned entry tests. - * *------------------------------------------------------------------------- */ @@ -4452,14 +4421,6 @@ check_flush_cache__multi_entry(H5F_t *file_ptr) * Programmer: John Mainzer * 1/13/05 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -4637,14 +4598,6 @@ check_flush_cache__multi_entry_test(H5F_t *file_ptr, int test_num, unsigned int * Programmer: John Mainzer * 4/5/06 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/16/20 - * *------------------------------------------------------------------------- */ @@ -4835,8 +4788,6 @@ check_flush_cache__pe_multi_entry_test(H5F_t *file_ptr, int test_num, unsigned i * Programmer: John Mainzer * 9/3/06 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -8202,14 +8153,6 @@ check_flush_cache__flush_ops(H5F_t *file_ptr) * Programmer: John Mainzer * 9/3/06 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/16/20 - * *------------------------------------------------------------------------- */ @@ -8592,19 +8535,6 @@ check_flush_cache__flush_op_test(H5F_t *file_ptr, int test_num, unsigned int flu * Programmer: John Mainzer * 10/3/06 * - * Modifications: - * - * Updated test for minor changes in the behaviour - * of H5C__flush_single_entry(). - * - * JRM -- 2/16/15 - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/16/20 - * *------------------------------------------------------------------------- */ @@ -9854,15 +9784,6 @@ check_flush_cache__flush_op_eviction_test(H5F_t *file_ptr) * Programmer: John Mainzer * 1/12/05 * - * Modifications: - * - * JRM -- 3/29/06 - * Added tests for pinned entries. - * - * JRM -- 5/17/06 - * Complete rewrite of pinned entry tests to accommodate - * the new H5C_mark_entry_dirty() call. - * *------------------------------------------------------------------------- */ @@ -11047,14 +10968,6 @@ check_flush_cache__single_entry(H5F_t *file_ptr) * Programmer: John Mainzer * 1/12/05 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -11186,21 +11099,6 @@ check_flush_cache__single_entry_test(H5F_t *file_ptr, int test_num, int entry_ty * Programmer: John Mainzer * 3/28/06 * - * Modifications: - * - * JRM -- 5/17/06 - * Added the pop_mark_dirty_prot and pop_mark_dirty_pinned - * flags and supporting code to allow us to test the - * H5C_mark_entry_dirty() call. Use the - * call to mark the entry dirty while the entry is protected - * if pop_mark_dirty_prot is TRUE, and to mark the entry - * dirty while it is pinned if pop_mark_dirty_pinned is TRUE. - * - * JRM -- 5/14/20 - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * *------------------------------------------------------------------------- */ @@ -11361,8 +11259,6 @@ check_flush_cache__pinned_single_entry_test(H5F_t *file_ptr, int test_num, int e * Programmer: John Mainzer * 4/28/06 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -11581,9 +11477,6 @@ check_get_entry_status(unsigned paged) * Programmer: John Mainzer * 7/5/06 * - * Modifications: - * - * *------------------------------------------------------------------------- */ @@ -11863,10 +11756,6 @@ check_expunge_entry(unsigned paged) * Programmer: John Mainzer * 4/1/07 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ static unsigned @@ -12353,10 +12242,6 @@ check_move_entry(unsigned paged) * Programmer: John Mainzer * 4/27/06 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -12509,8 +12394,6 @@ check_move_entry__run_test(H5F_t *file_ptr, unsigned test_num, struct move_entry * Programmer: John Mainzer * 4/28/06 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -12612,12 +12495,6 @@ check_pin_protected_entry(unsigned paged) * Programmer: John Mainzer * 7/7/06 * - * Modifications: - * - * Updated function to allow for disabling of the slist. - * - * JRM -- 5/18/20 - * *------------------------------------------------------------------------- */ @@ -13480,12 +13357,6 @@ check_resize_entry(unsigned paged) * Programmer: John Mainzer * 8/2/07 * - * Modifications: - * - * Updated function to allow for disabling of the slist. - * - * JRM -- 5/18/20 - * *------------------------------------------------------------------------- */ @@ -14130,13 +14001,6 @@ check_evictions_enabled(unsigned paged) * Programmer: John Mainzer * 6/24/04 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -14229,9 +14093,6 @@ check_flush_protected_err(unsigned paged) * Programmer: John Mainzer * 4/7/06 * - * Modifications: - * - * *------------------------------------------------------------------------- */ static unsigned @@ -14316,8 +14177,6 @@ check_destroy_pinned_err(unsigned paged) * Programmer: John Mainzer * 6/24/04 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -14412,8 +14271,6 @@ check_destroy_protected_err(unsigned paged) * Programmer: John Mainzer * 6/24/04 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -14494,10 +14351,6 @@ check_duplicate_insert_err(unsigned paged) * Programmer: John Mainzer * 4/24/06 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -14583,10 +14436,6 @@ check_double_pin_err(unsigned paged) * Programmer: John Mainzer * 4/24/06 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -14681,10 +14530,6 @@ check_double_unpin_err(unsigned paged) * Programmer: John Mainzer * 4/24/06 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -15035,10 +14880,6 @@ check_mark_entry_dirty_errs(unsigned paged) * Programmer: John Mainzer * 7/6/06 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -15490,10 +15331,6 @@ check_unprotect_ro_dirty_err(unsigned paged) * Programmer: John Mainzer * 4/9/07 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -15706,10 +15543,6 @@ check_protect_retries(unsigned paged) * Programmer: John Mainzer * 8/3/07 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -19710,12 +19543,6 @@ check_auto_cache_resize(hbool_t cork_ageout, unsigned paged) * Programmer: John Mainzer * 12/16/04 * - * Modifications: - * - * Added code to include the flash cache size increment - * code in this test. - * JRM -- 1/10/08 - * *------------------------------------------------------------------------- */ @@ -22312,8 +22139,6 @@ check_auto_cache_resize_disable(unsigned paged) * Programmer: John Mainzer * 12/16/04 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -22999,13 +22824,6 @@ check_auto_cache_resize_epoch_markers(unsigned paged) * Programmer: John Mainzer * 10/29/04 * - * Modifications: - * - * Added code to verify that errors in the flash cache size - * increment related fields are caught as well. - * - * JRM -- 1/17/08 - * *------------------------------------------------------------------------- */ @@ -25236,8 +25054,6 @@ check_auto_cache_resize_input_errs(unsigned paged) * Programmer: John Mainzer * 11/4/04 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -25738,8 +25554,6 @@ check_auto_cache_resize_aux_fcns(unsigned paged) * Programmer: Mike McGreevy * 12/16/08 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -28650,14 +28464,6 @@ done: * Programmer: Quincey Koziol * 3/17/09 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -32207,10 +32013,6 @@ check_metadata_cork(hbool_t fill_via_insertion, unsigned paged) * Programmer: John Mainzer * 4/3/15 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ static unsigned @@ -32304,14 +32106,6 @@ check_entry_deletions_during_scans(unsigned paged) * Programmer: John Mainzer * 4/4/15 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -32544,14 +32338,6 @@ cedds__expunge_dirty_entry_in_flush_test(H5F_t *file_ptr) * Programmer: John Mainzer * 4/4/15 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -32906,14 +32692,6 @@ cedds__H5C_make_space_in_cache(H5F_t *file_ptr) * Programmer: John Mainzer * 4/4/15 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -33366,14 +33144,6 @@ cedds__H5C__autoadjust__ageout__evict_aged_out_entries(H5F_t *file_ptr) * Programmer: John Mainzer * 4/9/15 * - * Modifications: - * - * Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -33673,8 +33443,6 @@ cedds__H5C_flush_invalidate_cache__bucket_scan(H5F_t *file_ptr) * Programmer: John Mainzer * 4/12/15 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -33755,18 +33523,6 @@ check_stats(unsigned paged) * Programmer: John Mainzer * 4/22/15 * - * Modifications: - * - * Modified slist stats checks to allow for the case that - * the slist is disabled. - * - * Also added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via the - * H5C_FLUSH_CACHE macro. - * - * JRM -- 5/14/20 - * - * *------------------------------------------------------------------------- */ #if H5C_COLLECT_CACHE_STATS diff --git a/test/cache_common.c b/test/cache_common.c index df08e25..d4bab3b 100644 --- a/test/cache_common.c +++ b/test/cache_common.c @@ -2664,11 +2664,6 @@ verify_unprotected(void) * Programmer: John Mainzer * 7/6/06 * - * Changes: Added code to set entry_ptr->expunged to TRUE if - * H5C_expunge_entry() returns without error. - * - * JRM -- 8/21/14 - * *------------------------------------------------------------------------- */ @@ -2727,19 +2722,6 @@ expunge_entry(H5F_t *file_ptr, int32_t type, int32_t idx) * Programmer: John Mainzer * 6/23/04 * - * Changes: Added code to setup and take down the skip list before - * and after calls to H5C_flush_cache(). Do this via calls - * to the H5C_FLUSH_CACHE macro. - * - * This is necessary, as H5C_flush() is called repeatedly - * during file flush. If we setup and took down the - * skip list on H5C_flush_cache(), we would find ourselves - * doing this repeatedly -- which is contrary to the - * objective of the exercise (avoiding as many skip list - * operations as possible). - * - * JRM -- 5/14/20 - * *------------------------------------------------------------------------- */ @@ -3512,11 +3494,6 @@ unprotect_entry(H5F_t *file_ptr, int32_t type, int32_t idx, unsigned int flags) * Programmer: John Mainzer * 6/12/04 * - * Changes: Updated slist size == dirty index size checks to - * bypass the test if cache_ptr->slist_enabled is FALSE. - * - * JRM -- 5/8/20 - * *------------------------------------------------------------------------- */ void diff --git a/test/cache_common.h b/test/cache_common.h index 28d3a65..bdeeded 100644 --- a/test/cache_common.h +++ b/test/cache_common.h @@ -141,8 +141,6 @@ * Programmer: John Mainzer * 5/14/20 * - * Changes: None. - * ***********************************************************************/ #define H5C_FLUSH_CACHE(file, flags, fail_mssg) \ diff --git a/test/cmpd_dset.c b/test/cmpd_dset.c index 9f4072e..73d0459 100644 --- a/test/cmpd_dset.c +++ b/test/cmpd_dset.c @@ -127,13 +127,6 @@ typedef struct { * Programmer: Robb Matzke * Friday, January 23, 1998 * - * Modifications: - * Robb Matzke, 1999-06-23 - * If the command line switch `--noopt' is present then the fast - * compound datatype conversion is turned off. - * - * Raymond Lu, 15 June 2007 - * Moved this part of code from MAIN to TEST_COMPOUND function. *------------------------------------------------------------------------- */ static unsigned @@ -820,7 +813,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static void @@ -862,7 +854,6 @@ initialize_stype1(unsigned char *buf, size_t num) * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static void @@ -908,7 +899,6 @@ initialize_stype2(unsigned char *buf, size_t num) * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static void @@ -938,7 +928,6 @@ initialize_stype3(unsigned char *buf, size_t num) * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static void @@ -990,7 +979,6 @@ initialize_stype4(unsigned char *buf, size_t num) * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static hid_t @@ -1045,7 +1033,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static hid_t @@ -1103,7 +1090,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static hid_t @@ -1145,7 +1131,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static hid_t @@ -1206,7 +1191,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static int @@ -1289,7 +1273,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static unsigned @@ -1496,7 +1479,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ static unsigned @@ -1705,7 +1687,6 @@ error: * Programmer: Neil Fortner * Thursday, 22 January 2009 * - * Modifications: *------------------------------------------------------------------------- */ static unsigned @@ -1981,7 +1962,6 @@ error: * Programmer: Neil Fortner * Monday, 19 October 2009 * - * Modifications: *------------------------------------------------------------------------- */ static unsigned @@ -2222,7 +2202,6 @@ error: * Programmer: Raymond Lu * Friday, 15 June 2007 * - * Modifications: *------------------------------------------------------------------------- */ int diff --git a/test/dangle.c b/test/dangle.c index 660b54f..36984b8 100644 --- a/test/dangle.c +++ b/test/dangle.c @@ -39,8 +39,6 @@ const char *FILENAME[] = {"dangle", NULL}; * Programmer: Quincey Koziol * Tuesday, May 13, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -138,8 +136,6 @@ error: * Programmer: Quincey Koziol * Tuesday, May 13, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -233,8 +229,6 @@ error: * Programmer: Quincey Koziol * Tuesday, May 13, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -331,8 +325,6 @@ error: * Programmer: Quincey Koziol * Thursday, August 25, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -418,8 +410,6 @@ error: * Programmer: Quincey Koziol * Wednesday, June 18, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -652,8 +642,6 @@ error: * Programmer: Quincey Koziol * Tuesday, May 13, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/dt_arith.c b/test/dt_arith.c index 6d6cb4c..aa0115e 100644 --- a/test/dt_arith.c +++ b/test/dt_arith.c @@ -403,8 +403,6 @@ static int my_isinf(int endian, const unsigned char *val, size_t size, size_t mp * Programmer: Robb Matzke * Monday, July 6, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -430,8 +428,6 @@ fpe_handler(int H5_ATTR_UNUSED signo) * Programmer: Robb Matzke * Monday, November 16, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -472,8 +468,6 @@ reset_hdf5(void) * Programmer: Raymond Lu * April 19, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static H5T_conv_ret_t @@ -518,8 +512,6 @@ except_func(H5T_conv_except_t except_type, hid_t H5_ATTR_UNUSED src_id, hid_t H5 * Programmer: Raymond Lu * Friday, Sept 2, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -582,8 +574,6 @@ error: * Programmer: Raymond Lu * Sept 7, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static H5T_conv_ret_t @@ -803,8 +793,6 @@ error: * Programmer: Raymond Lu * Thursday, Jan 6, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1254,8 +1242,6 @@ error: * Programmer: Raymond Lu * Saturday, Jan 29, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1575,8 +1561,6 @@ error: * Programmer: Robb Matzke * Monday, November 16, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2628,8 +2612,6 @@ error: * Programmer: Robb Matzke * Friday, April 30, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2680,8 +2662,6 @@ test_conv_int_2(void) * Programmer: Robb Matzke * Monday, July 6, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2756,8 +2736,6 @@ my_isnan(dtype_t type, void *val) * Programmer: Raymond Lu * Monday, June 20, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2796,13 +2774,6 @@ my_isinf(int endian, const unsigned char *val, size_t size, size_t mpos, size_t * Programmer: Robb Matzke * Tuesday, June 23, 1998 * - * Modifications: - * Albert Cheng, Apr 16, 2004 - * Check for underflow condition. If the src number is - * smaller than the dst MIN float number, consider it okay - * if the converted sw and hw dst are both less than or - * equal to the dst MIN float number. - * *------------------------------------------------------------------------- */ static int @@ -3404,8 +3375,6 @@ error: * Programmer: Raymond Lu * Thursday, November 6, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4606,8 +4575,6 @@ error: * Programmer: Raymond Lu * Monday, Nov 17, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static hbool_t @@ -4692,8 +4659,6 @@ done: * Programmer: Robb Matzke * Tuesday, November 24, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4854,8 +4819,6 @@ run_integer_tests(const char *name) * Programmer: Raymond Lu * Tuesday, March 22, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4939,8 +4902,6 @@ done: * Programmer: Raymond Lu * Monday, November 10, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -5047,8 +5008,6 @@ run_int_fp_conv(const char *name) * Programmer: Raymond Lu * Monday, November 10, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -5195,12 +5154,6 @@ run_fp_int_conv(const char *name) * Programmer: Robb Matzke * Tuesday, December 9, 1997 * - * Modifications: - * Raymond Lu - * Monday, April 4, 2005 - * These tests were split from dtypes.c because dtypes.c - * has grown too big. - * *------------------------------------------------------------------------- */ int diff --git a/test/dtypes.c b/test/dtypes.c index 2d0dc88..37fc8c7 100644 --- a/test/dtypes.c +++ b/test/dtypes.c @@ -341,11 +341,6 @@ error: * Programmer: Quincey Koziol * Saturday, August 30, 2003 * - * Modifications: - * Raymond Lu - * 8 December 2009 - * I added a field of VL string in the compound type to test - * H5Tdetect_class correctly detect it as string type. *------------------------------------------------------------------------- */ static int @@ -1347,11 +1342,6 @@ error: * Programmer: Quincey Koziol * Tuesday, December 18, 2001 * - * Modifications: - * The size of compound datatype can be expanded now. - * Raymond Lu - * Wednesday, September 10, 2003 - * *------------------------------------------------------------------------- */ static int @@ -1496,11 +1486,6 @@ error: * Programmer: Robb Matzke * Wednesday, January 7, 1998 * - * Modifications: - * Raymond Lu - * 27 June 2008 - * Added verification of compound type size for H5Tpack and - * test for array of nested compound type. *------------------------------------------------------------------------- */ static int @@ -2019,8 +2004,6 @@ error: * Programmer: Raymond Lu * Tuesday, June 15, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2233,8 +2216,6 @@ error: * Programmer: Quincey Koziol * Saturday, August 7, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2516,8 +2497,6 @@ error: * Programmer: Raymond Lu * Wednesday, September 29, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2737,9 +2716,9 @@ error: * Function: test_compound_14 * * Purpose: Tests compound type conversions where a vlen string will - be misaligned in the conversion buffer and the file. The - two compound types are meant to trigger two different - conversion routines. + * be misaligned in the conversion buffer and the file. The + * two compound types are meant to trigger two different + * conversion routines. * * Return: Success: 0 * @@ -2748,8 +2727,6 @@ error: * Programmer: Neil Fortner * Monday, August 25, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3204,8 +3181,6 @@ error: * Programmer: Neil Fortner * Friday, September 19, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3379,8 +3354,6 @@ error: * Programmer: Ray Lu * 14 July 2022 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3507,8 +3480,6 @@ error: * Programmer: Neil Fortner * Friday, October 3, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3621,8 +3592,6 @@ error: * Programmer: Neil Fortner * Tuesday, January 13, 2009 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3927,11 +3896,6 @@ error: * Programmer: Raymond Lu * Thursday, April 4, 2002 * - * Modifications: - * Raymond Lu - * Wednesday, February 9, 2005 - * Added test for H5Tenum_valueof, H5Tenum_nameof, and - * H5Tget_member_value. *------------------------------------------------------------------------- */ static int @@ -4174,8 +4138,6 @@ error: * Programmer: Robb Matzke * Thursday, June 4, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4331,8 +4293,6 @@ error: * Programmer: Robb Matzke * Monday, June 1, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -5285,8 +5245,6 @@ error: * Programmer: Robb Matzke * Tuesday, January 5, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -6014,13 +5972,6 @@ error: * Programmer: Raymond Lu * July 14, 2004 * - * Modifications: Raymond Lu - * July 13, 2009 - * Added the test for VL string types. - * - * Raymond Lu - * 17 February 2011 - * I added the test of reference count for decoded datatypes. *------------------------------------------------------------------------- */ static int @@ -6810,8 +6761,6 @@ conv_except(H5T_conv_except_t except_type, hid_t H5_ATTR_UNUSED src_id, hid_t H5 * make it portable to other architectures, but further * input and changes are welcome. -QAK * - * Modifications: - * *------------------------------------------------------------------------- */ static int diff --git a/test/enum.c b/test/enum.c index 780da74..592236a 100644 --- a/test/enum.c +++ b/test/enum.c @@ -33,8 +33,6 @@ typedef enum { E1_RED, E1_GREEN, E1_BLUE, E1_WHITE, E1_BLACK } c_e1; * Programmer: Robb Matzke * Wednesday, December 23, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -315,8 +313,6 @@ error: * Programmer: Robb Matzke * Monday, January 4, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -419,8 +415,6 @@ error: * Programmer: Robb Matzke * Tuesday, January 5, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -530,8 +524,6 @@ error: * Programmer: Elena Pourmal * Wednesday, June 7, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -622,8 +614,6 @@ error: * Programmer: Raymond Lu * Tuesday, April 4, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -757,8 +747,6 @@ error: * Programmer: Robb Matzke * Tuesday, December 22, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/file_image.c b/test/file_image.c index 0398c15..e9f50c3 100644 --- a/test/file_image.c +++ b/test/file_image.c @@ -699,10 +699,6 @@ error: * Programmer: John Mainzer * Tuesday, November 15, 2011 * - * Modifications: - * Vailin Choi; July 2013 - * Add the creation of user block to the file as indicated by the parameter "user". - * ****************************************************************************** */ /* Disable warning for "format not a string literal" here -QAK */ @@ -1343,10 +1339,6 @@ error: return 1; } /* test_get_file_image_error_rejection() */ -/* - * Modifications: - * Add testing for file image with or without user block in the file. - */ int main(void) { diff --git a/test/fillval.c b/test/fillval.c index 008833d..489aa76 100644 --- a/test/fillval.c +++ b/test/fillval.c @@ -62,8 +62,6 @@ typedef struct { * Programmer: Raymond Lu * Monday, Jan 26, 2001 * - * Modifications: - * *------------------------------------------------------------------------- */ static hid_t @@ -159,8 +157,6 @@ error: * Programmer: Robb Matzke * Thursday, October 1, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -404,10 +400,6 @@ error: * Programmer: Robb Matzke * Thursday, October 1, 1998 * - * Modifications: - * Many new cases have been added to this test since - * the fill value design has been modified. - * *------------------------------------------------------------------------- */ static int @@ -866,10 +858,6 @@ error: * Programmer: Robb Matzke * Thursday, October 1, 1998 * - * Modifications: - * This function is called by test_rdwr to write and read - * dataset for different cases. - * *------------------------------------------------------------------------- */ static int @@ -1207,10 +1195,6 @@ error: * Programmer: Robb Matzke * Thursday, October 1, 1998 * - * Modifications: - * Many new cases have been added to this test since the - * fill value design is modified. - * *------------------------------------------------------------------------- */ static int @@ -2060,8 +2044,6 @@ error: * Programmer: Robb Matzke * Monday, October 5, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2224,8 +2206,6 @@ skip: * Programmer: Raymond Lu * Feb 27, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2379,11 +2359,6 @@ error: * Programmer: Joel Plutchak * April 15, 2013 * - * Modifications: - * This function is called by test_rdwr to write and read - * dataset for different cases of chunked datasets with - * unallocated chunks. - * *------------------------------------------------------------------------- */ diff --git a/test/filter_fail.c b/test/filter_fail.c index d413b07..172027c 100644 --- a/test/filter_fail.c +++ b/test/filter_fail.c @@ -97,11 +97,6 @@ filter_fail(unsigned int flags, size_t H5_ATTR_UNUSED cd_nelmts, const unsigned * Programmer: Raymond Lu * 25 August 2010 * - * Modifications: - * Raymond Lu - * 5 Oct 2010 - * Test when the chunk cache is enable and disabled to make - * sure the library behaves properly. *------------------------------------------------------------------------- */ static herr_t @@ -237,8 +232,6 @@ error: * Programmer: Raymond Lu * 25 August 2010 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t diff --git a/test/gen_cross.c b/test/gen_cross.c index 98c6fd7..c468039 100644 --- a/test/gen_cross.c +++ b/test/gen_cross.c @@ -88,8 +88,6 @@ int create_nbit_dsets_float(hid_t fid, hid_t fsid, hid_t msid); * Programmer: Raymond Lu * Some time ago * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -194,8 +192,6 @@ error: * Programmer: Neil Fortner * 27 January 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -284,8 +280,6 @@ error: * Programmer: Raymond Lu * 21 January 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -374,8 +368,6 @@ error: * Programmer: Neil Fortner * 27 January 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -472,8 +464,6 @@ error: * Programmer: Neil Fortner * 27 January 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -570,8 +560,6 @@ error: * Programmer: Raymond Lu * 21 January 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -669,8 +657,6 @@ error: * Programmer: Neil Fortner * 27 January 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -767,8 +753,6 @@ error: * Programmer: Raymond Lu * 29 March 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -857,8 +841,6 @@ error: * Programmer: Raymond Lu * 29 March 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -958,8 +940,6 @@ error: * Programmer: Raymond Lu * 29 March 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -1049,8 +1029,6 @@ error: * Programmer: Raymond Lu * 29 March 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -1139,8 +1117,6 @@ error: * Programmer: Raymond Lu * 29 March 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_filters.c b/test/gen_filters.c index d82a3eb..c171538 100644 --- a/test/gen_filters.c +++ b/test/gen_filters.c @@ -228,8 +228,6 @@ error: * * Return: Success: * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_new_array.c b/test/gen_new_array.c index e04b71a..1db1c69 100644 --- a/test/gen_new_array.c +++ b/test/gen_new_array.c @@ -50,8 +50,6 @@ * Programmer: Robb Matzke * Monday, October 26, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_new_mtime.c b/test/gen_new_mtime.c index 7632769..87a104a 100644 --- a/test/gen_new_mtime.c +++ b/test/gen_new_mtime.c @@ -39,8 +39,6 @@ * Programmer: Quincey Koziol * Friday, January 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_noencoder.c b/test/gen_noencoder.c index fe9cea6..a0be0ef 100644 --- a/test/gen_noencoder.c +++ b/test/gen_noencoder.c @@ -24,8 +24,6 @@ * Programmer: James Laird and Nat Furrer * Thursday, July 1, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_old_array.c b/test/gen_old_array.c index ab0ea20..2e6e953 100644 --- a/test/gen_old_array.c +++ b/test/gen_old_array.c @@ -49,8 +49,6 @@ * Programmer: Robb Matzke * Monday, October 26, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_old_layout.c b/test/gen_old_layout.c index b7a9b3d..a18e7fb 100644 --- a/test/gen_old_layout.c +++ b/test/gen_old_layout.c @@ -45,8 +45,6 @@ * Programmer: Quincey Koziol * Friday, January 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_old_mtime.c b/test/gen_old_mtime.c index 9645a5e..d67d018 100644 --- a/test/gen_old_mtime.c +++ b/test/gen_old_mtime.c @@ -39,8 +39,6 @@ * Programmer: Quincey Koziol * Friday, January 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/gen_sizes_lheap.c b/test/gen_sizes_lheap.c index dc55d81..c30b811 100644 --- a/test/gen_sizes_lheap.c +++ b/test/gen_sizes_lheap.c @@ -36,8 +36,6 @@ * Programmer: Neil Fortner * Thursday, July 15, 2010 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/h5test.c b/test/h5test.c index 1467e0b..c667ffd 100644 --- a/test/h5test.c +++ b/test/h5test.c @@ -132,8 +132,6 @@ static char *h5_fixname_real(const char *base_name, hid_t fapl, const char *_su * Programmer: Robb Matzke * Wednesday, March 4, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -918,8 +916,6 @@ error: * Programmer: Robb Matzke * Friday, November 20, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void @@ -938,8 +934,6 @@ h5_no_hwconv(void) * Programmer: Albert Cheng * 2002/04/22 * - * Modifications: - * *------------------------------------------------------------------------- */ void @@ -1010,12 +1004,6 @@ h5_show_hostname(void) * object. * Return: 0 if all is fine; otherwise non-zero. * Programmer: Albert Cheng, 2002/05/21. - * Modifications: - * Bill Wendling, 2002/05/31 - * Modified so that the HDF5_MPI_INFO environment variable can - * be a semicolon separated list of "key=value" pairings. Most - * of the code is to remove any whitespaces which might be - * surrounding the "key=value" pairs. */ int h5_set_info_object(void) @@ -1109,7 +1097,6 @@ h5_set_info_object(void) * Purpose: Display content of an MPI Info object * Return: void * Programmer: Albert Cheng 2002/05/21 - * Modifications: */ void h5_dump_info_object(MPI_Info info) @@ -1339,8 +1326,6 @@ print_func(const char *format, ...) * * Programmer: * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -1391,11 +1376,6 @@ h5_szip_can_encode(void) * Programmer: Leon Arber * 4/4/05 * - * Modifications: - * Use original getenv if MPI is not initialized. This happens - * one uses the PHDF5 library to build a serial nature code. - * Albert 2006/04/07 - * *------------------------------------------------------------------------- */ char * @@ -1566,8 +1546,6 @@ h5_verify_cached_stabs_cb(hid_t oid, const char H5_ATTR_UNUSED *name, const H5O_ * Programmer: Neil Fortner * Tuesday, April 12, 2011 * - * Modifications: - * *------------------------------------------------------------------------- */ herr_t diff --git a/test/hdfs.c b/test/hdfs.c index 06cd7cc..bf8e840 100644 --- a/test/hdfs.c +++ b/test/hdfs.c @@ -404,8 +404,6 @@ static H5FD_hdfs_fapl_t default_fa = { * Programmer: Jacob Smith * 2018-04-25 * - * Changes: None. - * *--------------------------------------------------------------------------- */ static int @@ -614,8 +612,6 @@ error: * Programmer: Jacob Smith * 2018-04-25 * - * Changes: None. - * *------------------------------------------------------------------------- */ static int @@ -1383,10 +1379,6 @@ error: * Programmer: Jacob Smith * 2017-11-06 * - * Changes: - * + modify from S3VFD codebase to HDFS; Minor changes, mostly. - * + Jacob Smith 2018-06-08 - * *--------------------------------------------------------------------------- */ static int @@ -1529,10 +1521,6 @@ test_cmp(void) * Programmer: Jacob Smith * 2017-11-07 * - * Changes: - * + modify from S3VFD codebase to HDFS; Minor changes, mostly. - * + Jacob Smith 2018-06-08 - * *--------------------------------------------------------------------------- */ static int diff --git a/test/istore.c b/test/istore.c index 916cf67..b688acd 100644 --- a/test/istore.c +++ b/test/istore.c @@ -94,8 +94,6 @@ is_sparse(void) * Programmer: Robb Matzke * Friday, October 10, 1997 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -137,13 +135,6 @@ print_array(uint8_t *array, size_t nx, size_t ny, size_t nz) * Programmer: Robb Matzke * Wednesday, October 15, 1997 * - * Modifications: - * Converted to use datasets instead of directly messing with - * the istore routines, etc. since the new raw data architecture - * performs hyperslab operations at a higher level than the - * istore routines did and the new istore routines can't handle - * I/O on more than one chunk at a time. QAK - 2003/04/16 - * *------------------------------------------------------------------------- */ static hid_t @@ -198,8 +189,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 15, 1997 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -246,8 +235,6 @@ test_create(hid_t f, const char *prefix) * Programmer: Robb Matzke * Wednesday, October 15, 1997 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -445,8 +432,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 22, 1997 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t diff --git a/test/links.c b/test/links.c index 56912fe..9e4d2e3 100644 --- a/test/links.c +++ b/test/links.c @@ -7815,8 +7815,6 @@ error: * Programmer: Quincey Koziol * Tuesday, July 26, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int diff --git a/test/links_env.c b/test/links_env.c index 0bd2add..27e29ea 100644 --- a/test/links_env.c +++ b/test/links_env.c @@ -48,8 +48,6 @@ static int external_link_env(hid_t fapl, hbool_t new_format); * Programmer: Vailin Choi * Feb. 20, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int diff --git a/test/mount.c b/test/mount.c index c5a04b5..6807f36 100644 --- a/test/mount.c +++ b/test/mount.c @@ -41,8 +41,6 @@ int bm[NX][NY], bm_out[NX][NY]; /* Data buffers */ * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -116,8 +114,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -172,8 +168,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -461,8 +455,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -561,8 +553,6 @@ error: * Programmer: Robb Matzke * Tuesday, October 13, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -650,8 +640,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -720,8 +708,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -790,8 +776,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -859,8 +843,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -934,8 +916,6 @@ error: * Programmer: Robb Matzke * Tuesday, October 13, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1088,8 +1068,6 @@ error: * Programmer: Robb Matzke * Tuesday, October 13, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1151,8 +1129,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1273,8 +1249,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1352,8 +1326,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1442,8 +1414,6 @@ error: * Programmer: Quincey Koziol * Wednesday, May 4, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1677,8 +1647,6 @@ error: * Programmer: Quincey Koziol * Monday, June 6, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1946,8 +1914,6 @@ error: * Programmer: Quincey Koziol * Thursday, June 30, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2098,8 +2064,6 @@ error: * Programmer: Quincey Koziol * Tuesday, July 5, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2228,8 +2192,6 @@ error: * Programmer: Quincey Koziol * Thursday, July 14, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2384,8 +2346,6 @@ error: * Programmer: Quincey Koziol * Tuesday, July 19, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2528,8 +2488,6 @@ error: * Programmer: Quincey Koziol * Tuesday, July 19, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2671,8 +2629,6 @@ error: * Programmer: Quincey Koziol * Tuesday, July 19, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2813,8 +2769,6 @@ error: * Programmer: Quincey Koziol * Tuesday, July 19, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3017,8 +2971,6 @@ error: * Programmer: Quincey Koziol * Monday, July 25, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3240,8 +3192,6 @@ error: * Programmer: Quincey Koziol * Monday, July 25, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3453,8 +3403,6 @@ error: * Programmer: Quincey Koziol * Monday, July 25, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3624,8 +3572,6 @@ error: * Programmer: Quincey Koziol * Monday, July 25, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4016,8 +3962,6 @@ error: * Programmer: Quincey Koziol * Monday, July 25, 2005 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4181,8 +4125,6 @@ error: * Programmer: Neil Fortner * Friday, August 1, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4287,8 +4229,6 @@ error: * Programmer: Neil Fortner * Friday, August 6, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4446,8 +4386,6 @@ error: * Programmer: Neil Fortner * Friday, November 14, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4600,8 +4538,6 @@ error: * Programmer: Robb Matzke * Wednesday, October 7, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/mtime.c b/test/mtime.c index 8391def..882189e 100644 --- a/test/mtime.c +++ b/test/mtime.c @@ -39,13 +39,6 @@ const char *FILENAME[] = {"mtime", NULL}; * Programmer: Robb Matzke * Thursday, July 30, 1998 * - * Modifications: - * Added checks for old and new modification time messages - * in pre-created datafiles (generated with gen_old_mtime.c and - * gen_new_mtime.c). - * Quincey Koziol - * Friday, January 3, 2003 - * *------------------------------------------------------------------------- */ int diff --git a/test/ntypes.c b/test/ntypes.c index b825ecd..92b2896 100644 --- a/test/ntypes.c +++ b/test/ntypes.c @@ -63,8 +63,6 @@ const char *FILENAME[] = {"ntypes", NULL}; * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -314,8 +312,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -644,8 +640,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -857,8 +851,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -1098,8 +1090,6 @@ error: * Programmer: Quincey Koziol * January 31, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -1325,8 +1315,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -1484,8 +1472,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -1672,8 +1658,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -1824,8 +1808,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2030,8 +2012,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2170,8 +2150,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2292,8 +2270,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2465,8 +2441,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2679,8 +2653,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -2778,11 +2750,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * Raymond Lu - * 1 December 2009 - * I added the support for bitfield and changed the test to - * compare the data being read back. *------------------------------------------------------------------------- */ static herr_t @@ -2937,8 +2904,6 @@ error: * Programmer: Pedro Vicente * September 3, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -3145,8 +3110,6 @@ error: * Programmer: Raymond Lu * October 15, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/page_buffer.c b/test/page_buffer.c index d588d30..a6f7f0a 100644 --- a/test/page_buffer.c +++ b/test/page_buffer.c @@ -554,21 +554,8 @@ error: * Programmer: unknown * ?? / ?? / ?? * - * Changes: Added base_page_cnt field as supporting code. This allows - * the test to adjust to the number of page buffer pages - * accessed during file open / create. - * - * The test for the value of base_page_cnt just after file - * open exists detect changes in library behavior. Assuming - * any such change is not indicative of other issues, these - * tests can be modified to reflect the change. - * - * JRM -- 2/23/17 - * *------------------------------------------------------------------------- */ - -/* Changes due to file space page size has a minimum size of 512 */ static unsigned test_raw_data_handling(hid_t orig_fapl, const char *env_h5_drvr) { @@ -832,18 +819,6 @@ error: * Programmer: unknown * ?? / ?? / ?? * - * Changes: Added base_page_cnt field as supporting code. This allows - * the test to adjust to the number of page buffer pages - * accessed during file open / create. - * - * The test for the value of base_page_cnt just after file - * open exists detect changes in library behavior. Assuming - * any such change is not indicative of other issues, these - * tests can be modified to reflect the change. - * - * JRM -- 2/23/17 - * - * *------------------------------------------------------------------------- */ @@ -1086,19 +1061,6 @@ error: * Programmer: unknown * ?? / ?? / ?? * - * Changes: Added the base_raw_cnt and base_meta_cnt fields and - * supporting code. This allows the test to adjust to the - * number of page buffer pages accessed during file open / - * create. - * - * The tests for the values of base_raw_cnt and base_meta_cnt - * just after file open exist detect changes in library - * behavior. Assuming any such change is not indicative of - * other issues, these tests can be modified to reflect the - * change. - * - * JRM -- 2/23/17 - * *------------------------------------------------------------------------- */ @@ -1721,19 +1683,6 @@ error: * Programmer: unknown * ?? / ?? / ?? * - * Changes: Added the base_raw_cnt and base_meta_cnt fields and - * supporting code. This allows the test to adjust to the - * number of page buffer pages accessed during file open / - * create. - * - * The tests for the values of base_raw_cnt and base_meta_cnt - * just after file open exist detect changes in library - * behavior. Assuming any such change is not indicative of - * other issues, these tests can be modified to reflect the - * change. - * - * JRM -- 2/23/17 - * *------------------------------------------------------------------------- */ static unsigned @@ -2024,8 +1973,6 @@ error: * Programmer: John Mainzer * 03/21/17 * - * Changes: None. - * *------------------------------------------------------------------------- */ diff --git a/test/reserved.c b/test/reserved.c index d0e0c85..a820344 100644 --- a/test/reserved.c +++ b/test/reserved.c @@ -30,8 +30,6 @@ const char *FILENAME[] = {"rsrv_heap", "rsrv_ohdr", "rsrv_vlen", NULL}; * Nat Furrer * Friday, May 28, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -165,8 +163,6 @@ error: * Nat Furrer * Friday, May 28, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -309,8 +305,6 @@ error: * Nat Furrer * Thursday, July 1, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -471,8 +465,6 @@ error: * Programmer: Nat Furrer and James Laird * Thursday, July 1, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/s3comms.c b/test/s3comms.c index d68cc84..45978fb 100644 --- a/test/s3comms.c +++ b/test/s3comms.c @@ -1759,8 +1759,6 @@ error: * * Programmer: Jacob Smith 2018-01-24 * - * Changes: None - * *--------------------------------------------------------------------------- */ static herr_t @@ -1813,8 +1811,6 @@ error: * * Programmer: Jacob Smith 2018-01-?? * - * Changes: None - * *--------------------------------------------------------------------------- */ static herr_t diff --git a/test/space_overflow.c b/test/space_overflow.c index 41530fd..d31b52d 100644 --- a/test/space_overflow.c +++ b/test/space_overflow.c @@ -37,8 +37,6 @@ * Programmer: Robb Matzke * Monday, October 26, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/stab.c b/test/stab.c index 26cb015..697bce0 100644 --- a/test/stab.c +++ b/test/stab.c @@ -191,7 +191,6 @@ error: * * Programmer: Robb Matzke 2002-03-28 * - * Modifications: *------------------------------------------------------------------------- */ static int @@ -1405,8 +1404,6 @@ error: * Programmer: Robb Matzke * Tuesday, November 24, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/test/tattr.c b/test/tattr.c index a4ff088..5d82234 100644 --- a/test/tattr.c +++ b/test/tattr.c @@ -11655,8 +11655,6 @@ test_attr(void) * Programmer: Albert Cheng * July 2, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tcheck_version.c b/test/tcheck_version.c index a528f5e..2d5c239 100644 --- a/test/tcheck_version.c +++ b/test/tcheck_version.c @@ -22,8 +22,6 @@ * * Programmer: Albert Cheng * September 20, 2009 - * Modifications: - * Added abort signal intercept. AKC - 2009/10/16 - */ #include "h5test.h" diff --git a/test/tconfig.c b/test/tconfig.c index fdab5ef..ec6bb2c 100644 --- a/test/tconfig.c +++ b/test/tconfig.c @@ -75,8 +75,6 @@ test_configure(void) * Programmer: Albert Cheng * September 25, 2001 * - * Modifications: - * *------------------------------------------------------------------------- */ void @@ -95,10 +93,6 @@ cleanup_configure(void) * Programmer: Albert Cheng * September 25, 2001 * - * Modifications: - * Albert Cheng, 2004/10/14 - * Verified both signed and unsigned int types. - * *------------------------------------------------------------------------- */ void @@ -183,8 +177,6 @@ test_config_ctypes(void) * Programmer: Albert Cheng * October 12, 2009 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tcoords.c b/test/tcoords.c index f2bad20..230db60 100644 --- a/test/tcoords.c +++ b/test/tcoords.c @@ -713,8 +713,6 @@ test_coords(void) * Programmer: Raymond Lu * 20 Dec. 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/test_swmr.pwsh.in b/test/test_swmr.pwsh.in index de7a57a..8f09740 100644 --- a/test/test_swmr.pwsh.in +++ b/test/test_swmr.pwsh.in @@ -85,13 +85,6 @@ function Wait-Message { ############################################################################### ## Main ## -## Modifications: -## Vailin Choi; July 2013 -## Add waiting of message file before launching the reader(s). -## Due to the implementation of file locking, coordination -## is needed in file opening for the writer/reader tests -## to proceed as expected. -## ############################################################################### # Check to see if the VFD specified by the HDF5_DRIVER environment variable diff --git a/test/test_swmr.sh.in b/test/test_swmr.sh.in index aacd575..e4c7546 100644 --- a/test/test_swmr.sh.in +++ b/test/test_swmr.sh.in @@ -83,13 +83,6 @@ WAIT_MESSAGE() { ############################################################################### ## Main ## -## Modifications: -## Vailin Choi; July 2013 -## Add waiting of message file before launching the reader(s). -## Due to the implementation of file locking, coordination -## is needed in file opening for the writer/reader tests -## to proceed as expected. -## ############################################################################### # Check to see if the VFD specified by the HDF5_DRIVER environment variable diff --git a/test/testframe.c b/test/testframe.c index 9bcccd1..f3cf781 100644 --- a/test/testframe.c +++ b/test/testframe.c @@ -126,9 +126,6 @@ AddTest(const char *TheName, void (*TheCall)(void), void (*Cleanup)(void), const * private_parser: Optional routine provided by test program to parse the * private options. Default to NULL which means none is provided. * - * Modifications: - * Albert Cheng 2004/08/17 - * Added the ProgName, private_usage and private_parser arguments. */ void TestInit(const char *ProgName, void (*private_usage)(void), int (*private_parser)(int ac, char *av[])) diff --git a/test/tfile.c b/test/tfile.c index bca3da2..f24b55d 100644 --- a/test/tfile.c +++ b/test/tfile.c @@ -8226,8 +8226,6 @@ test_file(void) * Programmer: Albert Cheng * July 2, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tgenprop.c b/test/tgenprop.c index 46bb0ac..5751ce7 100644 --- a/test/tgenprop.c +++ b/test/tgenprop.c @@ -2188,8 +2188,6 @@ test_genprop(void) * Programmer: Quincey Koziol * June 8, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/th5s.c b/test/th5s.c index 25ab290..40d8b06 100644 --- a/test/th5s.c +++ b/test/th5s.c @@ -3507,8 +3507,6 @@ test_h5s(void) * Programmer: Albert Cheng * July 2, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/titerate.c b/test/titerate.c index defed21..1e23ade 100644 --- a/test/titerate.c +++ b/test/titerate.c @@ -1203,8 +1203,6 @@ test_iterate(void) * Programmer: Quincey Koziol * April 5, 2000 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tmeta.c b/test/tmeta.c index f5c5fc1..d55882d 100644 --- a/test/tmeta.c +++ b/test/tmeta.c @@ -121,8 +121,6 @@ test_metadata(void) * Programmer: Albert Cheng * July 2, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/trefer.c b/test/trefer.c index 26a883b..2c62234 100644 --- a/test/trefer.c +++ b/test/trefer.c @@ -3611,8 +3611,6 @@ test_reference(void) * Programmer: Quincey Koziol * September 8, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/trefer_deprec.c b/test/trefer_deprec.c index 75d441d..8d75fed 100644 --- a/test/trefer_deprec.c +++ b/test/trefer_deprec.c @@ -1853,8 +1853,6 @@ test_reference_deprec(void) * Programmer: Quincey Koziol * September 8, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tsohm.c b/test/tsohm.c index d923efb..7d9964f 100644 --- a/test/tsohm.c +++ b/test/tsohm.c @@ -480,8 +480,6 @@ error: * Programmer: James Laird * Saturday, August 26, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static hid_t @@ -555,8 +553,6 @@ error: * Programmer: James Laird * Wednesday, October 4, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static hid_t @@ -1521,8 +1517,6 @@ size2_verify_plist2(hid_t plist) * Programmer: James Laird * Friday, January 26, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -1565,8 +1559,6 @@ size2_dump_struct(const char *name, size2_helper_struct *sizes) * Programmer: James Laird * Friday, November 17, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2724,8 +2716,6 @@ test_sohm_size2(int close_reopen) * Programmer: James Laird * Tuesday, December 19, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -2763,8 +2753,6 @@ delete_helper_write(hid_t file_id, hid_t *dspace_id, hid_t *dcpl_id, int x) * Programmer: James Laird * Tuesday, December 19, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -2812,8 +2800,6 @@ delete_helper_read(hid_t file_id, hid_t *dspace_id, int x) * Programmer: James Laird * Tuesday, December 19, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -2896,8 +2882,6 @@ delete_helper(hid_t fcpl_id, hid_t *dspace_id, hid_t *dcpl_id) * Programmer: James Laird * Tuesday, December 19, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -3036,8 +3020,6 @@ test_sohm_delete(void) * Programmer: James Laird * Wednesday, January 3, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3137,8 +3119,6 @@ verify_dset_create_and_delete_does_not_grow_file(hid_t fcpl_id) * Programmer: James Laird * Wednesday, January 3, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -3217,8 +3197,6 @@ test_sohm_delete_revert(void) * Programmer: James Laird * Friday, December 22, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -3285,8 +3263,6 @@ verify_dset_create_and_open_through_extlink_with_sohm(hid_t src_fcpl_id, hid_t d * Programmer: James Laird * Friday, December 22, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -3333,8 +3309,6 @@ test_sohm_extlink(void) * Programmer: James Laird * Wednesday, January 10, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -3600,8 +3574,6 @@ verify_dataset_extension(hid_t fcpl_id, hbool_t close_reopen) * Programmer: James Laird * Wednesday, January 10, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -3682,8 +3654,6 @@ test_sohm_extend_dset(void) * Programmer: Raymond Lu * 13 October, 2008 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -3875,8 +3845,6 @@ test_sohm(void) * Programmer: James Laird * October 9, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/ttime.c b/test/ttime.c index 49ddafd..81c5015 100644 --- a/test/ttime.c +++ b/test/ttime.c @@ -220,8 +220,6 @@ test_time(void) * Programmer: Quincey Koziol * October 19, 2000 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tvlstr.c b/test/tvlstr.c index b27b2be..3fcc57d 100644 --- a/test/tvlstr.c +++ b/test/tvlstr.c @@ -995,8 +995,6 @@ test_vlstrings(void) * Programmer: Quincey Koziol * September 10, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/tvltypes.c b/test/tvltypes.c index d14f70d..1e0de1c 100644 --- a/test/tvltypes.c +++ b/test/tvltypes.c @@ -3254,8 +3254,6 @@ test_vltypes(void) * Programmer: Quincey Koziol * June 8, 1999 * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/test/unlink.c b/test/unlink.c index e2cf67f..e18ae73 100644 --- a/test/unlink.c +++ b/test/unlink.c @@ -78,8 +78,6 @@ const char *FILENAME[] = {"unlink", "new_move_a", "new_move_b", * Programmer: Robb Matzke * Friday, September 25, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -155,8 +153,6 @@ error: * Programmer: Robb Matzke * Friday, September 25, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -309,8 +305,6 @@ error: * Programmer: Robb Matzke * Friday, September 25, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -375,8 +369,6 @@ error: * Programmer: Raymond Lu * Thursday, April 25, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -478,8 +470,6 @@ error: * Programmer: Raymond Lu * Thursday, April 25, 2002 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -540,8 +530,6 @@ error: * Programmer: Quincey Koziol * Saturday, March 22, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1480,8 +1468,6 @@ error: * Programmer: Quincey Koziol * Friday, April 11, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1546,8 +1532,6 @@ error: * Programmer: Quincey Koziol * Saturday, August 16, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1627,8 +1611,6 @@ error: * Programmer: Quincey Koziol * Saturday, August 16, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1740,8 +1722,6 @@ delete_node(hid_t pid, hid_t id) * Programmer: Quincey Koziol * Monday, January 19, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1829,8 +1809,6 @@ error: * Programmer: Quincey Koziol * Monday, January 19, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -1921,8 +1899,6 @@ error: * Programmer: Quincey Koziol * Monday, January 19, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2299,8 +2275,6 @@ error: * Programmer: Quincey Koziol * Wednesday, July 14, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2384,8 +2358,6 @@ error: * Programmer: James Laird * Wednesday, July 28, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2466,8 +2438,6 @@ error: * Programmer: James Laird * Wednesday, July 28, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -2545,8 +2515,6 @@ error: * Programmer: Quincey Koziol * Monday, September 27, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -4043,10 +4043,6 @@ error: * Programmer: John Mainzer * 6/21/20 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -4149,10 +4145,6 @@ test_vector_io__setup_v(uint32_t count, H5FD_mem_t types[], haddr_t addrs[], siz * Programmer: John Mainzer * 3/10/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -4286,10 +4278,6 @@ test_vector_io__setup_fixed_size_v(uint32_t count, H5FD_mem_t types[], haddr_t a * Programmer: John Mainzer * 6/21/20 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -4341,10 +4329,6 @@ test_vector_io__read_v_indiv(H5FD_t *lf, uint32_t count, H5FD_mem_t types[], had * Programmer: John Mainzer * 6/21/20 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -4394,8 +4378,6 @@ test_vector_io__write_v_indiv(H5FD_t *lf, uint32_t count, H5FD_mem_t types[], ha * Programmer: John Mainzer * 6/21/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ @@ -4465,8 +4447,6 @@ test_vector_io__verify_v(uint32_t count, H5FD_mem_t types[], size_t sizes[], con * Programmer: John Mainzer * 6/21/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ @@ -4541,8 +4521,6 @@ test_vector_io__dump_test_vectors(uint32_t count, H5FD_mem_t types[], haddr_t ad * Programmer: John Mainzer * 6/20/20 * - * Changes: None. - * *------------------------------------------------------------------------- */ #define VECTOR_LEN 16 @@ -4983,8 +4961,6 @@ error: * Programmer: Neil Fortner * 7/1/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ /* Array dimensions, used for all selection I/O tests. Currently both must be @@ -5030,8 +5006,6 @@ error: * Programmer: Neil Fortner * 7/1/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ static herr_t @@ -5106,8 +5080,6 @@ error: * Programmer: Neil Fortner * 7/1/21 * - * Changes: None. - * *------------------------------------------------------------------------- */ static herr_t diff --git a/testpar/t_bigio.c b/testpar/t_bigio.c index af65cda..ad669d8 100644 --- a/testpar/t_bigio.c +++ b/testpar/t_bigio.c @@ -1296,8 +1296,6 @@ coll_chunk1(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/testpar/t_cache.c b/testpar/t_cache.c index ae47a6f..4d3aff5 100644 --- a/testpar/t_cache.c +++ b/testpar/t_cache.c @@ -475,10 +475,6 @@ static hbool_t trace_file_check(int metadata_write_strategy); * * Programmer: JRM -- 4/17/06 * - * Modifications: - * - * None. - * *****************************************************************************/ static void @@ -507,10 +503,6 @@ print_stats(void) * * Programmer: JRM -- 4/17/06 * - * Modifications: - * - * None. - * *****************************************************************************/ static void @@ -547,10 +539,6 @@ reset_stats(void) * * Programmer: JRM -- 11/16/05 * - * Modifications: - * - * None. - * *****************************************************************************/ static hbool_t @@ -964,10 +952,6 @@ get_max_nerrors(void) * * Programmer: JRM -- 12/22/05 * - * Modifications: - * - * JRM -- 5/10/06 - * Added mssg_tag_offset parameter and supporting code. * *****************************************************************************/ @@ -1043,11 +1027,6 @@ recv_mssg(struct mssg_t *mssg_ptr, int mssg_tag_offset) * * Programmer: JRM -- 12/22/05 * - * Modifications: - * - * JRM -- 5/10/06 - * Added the add_req_to_tag parameter and supporting code. - * *****************************************************************************/ static hbool_t send_mssg(struct mssg_t *mssg_ptr, hbool_t add_req_to_tag) @@ -1300,11 +1279,6 @@ reset_server_counters(void) * * Programmer: JRM -- 12/22/05 * - * Modifications: - * - * JRM -- 5/10/06 - * Updated for sync message. - * *****************************************************************************/ static hbool_t server_main(void) @@ -2876,13 +2850,6 @@ expunge_entry(H5F_t *file_ptr, int32_t idx) * Programmer: John Mainzer * 01/04/06 * - * Modifications: - * - * JRM -- 8/11/06 - * Updated code to reflect the fact that entries can now be - * inserted pinned. Note that since all inserts are dirty, - * any pins must be global pins. - * *****************************************************************************/ static void insert_entry(H5C_t *cache_ptr, H5F_t *file_ptr, int32_t idx, unsigned int flags) @@ -3245,12 +3212,6 @@ lock_and_unlock_random_entry(H5F_t *file_ptr, int min_idx, int max_idx) * Programmer: John Mainzer * 1/4/06 * - * Modifications: - * - * JRM -- 7/11/06 - * Modified asserts to handle the new local_len field in - * datum. - * *****************************************************************************/ static void lock_entry(H5F_t *file_ptr, int32_t idx) @@ -4089,11 +4050,6 @@ verify_writes(unsigned num_writes, haddr_t *written_entries_tbl) * * Programmer: JRM -- 1/12/06 * - * Modifications: - * - * JRM -- 5/9/06 - * Modified function to facilitate setting predefined seeds. - * *****************************************************************************/ static void setup_rand(void) @@ -4617,11 +4573,6 @@ verify_total_writes(unsigned expected_total_writes) * Programmer: John Mainzer * 1/4/06 * - * Modifications: - * - * 7/11/06 - * Updated for the new local_len field in datum. - * *****************************************************************************/ static void unlock_entry(H5F_t *file_ptr, int32_t idx, unsigned int flags) @@ -4692,11 +4643,6 @@ unlock_entry(H5F_t *file_ptr, int32_t idx, unsigned int flags) * Programmer: John Mainzer * 4/12/06 * - * Modifications: - * - * JRM -- 8/15/06 - * Added assertion that entry is pinned on entry. - * *****************************************************************************/ static void unpin_entry(H5F_t *file_ptr, int32_t idx, hbool_t global, hbool_t dirty, hbool_t via_unprotect) diff --git a/testpar/t_cache_image.c b/testpar/t_cache_image.c index 65c892d..1e556d9 100644 --- a/testpar/t_cache_image.c +++ b/testpar/t_cache_image.c @@ -125,10 +125,6 @@ static hbool_t smoke_check_1(MPI_Comm mpi_comm, MPI_Info mpi_info, int mpi_rank, * Programmer: John Mainzer * 1/25/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -390,13 +386,6 @@ construct_test_file(int test_file_index) * Programmer: John Mainzer * 7/15/15 * - * Modifications: - * - * Added min_dset and max_dset parameters and supporting - * code. This allows the caller to specify a range of - * datasets to create. - * JRM -- 8/20/15 - * *------------------------------------------------------------------------- */ @@ -723,11 +712,6 @@ create_data_sets(hid_t file_id, int min_dset, int max_dset) * Programmer: John Mainzer * 10/31/16 * - * Modifications: - * - * None. - * JRM -- 8/20/15 - * *------------------------------------------------------------------------- */ #if 0 @@ -823,14 +807,6 @@ delete_data_sets(hid_t file_id, int min_dset, int max_dset) * Programmer: John Mainzer * 7/14/15 * - * Modifications: - * - * Modified function to handle parallel file creates / opens. - * - * JRM -- 2/1/17 - * - * Modified function to handle - * *------------------------------------------------------------------------- */ @@ -1300,10 +1276,6 @@ open_hdf5_file(const hbool_t create_file, const hbool_t mdci_sbem_expected, cons * Programmer: John Mainzer * 3/4/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -1689,10 +1661,6 @@ par_create_dataset(int dset_num, hid_t file_id, int mpi_rank, int mpi_size) * Programmer: John Mainzer * 3/6/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -1760,10 +1728,6 @@ par_delete_dataset(int dset_num, hid_t file_id, int mpi_rank) * Programmer: John Mainzer * 3/8/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -1809,10 +1773,6 @@ par_insert_cache_image(int file_name_idx, int mpi_rank, int mpi_size) * Programmer: John Mainzer * 3/6/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2067,10 +2027,6 @@ par_verify_dataset(int dset_num, hid_t file_id, int mpi_rank) * Programmer: John Mainzer * 3/8/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2181,10 +2137,6 @@ serial_insert_cache_image(int file_name_idx, int mpi_size) * Programmer: John Mainzer * 3/6/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2413,13 +2365,6 @@ serial_verify_dataset(int dset_num, hid_t file_id, int mpi_size) * Programmer: John Mainzer * 7/15/15 * - * Modifications: - * - * Added min_dset and max_dset parameters and supporting - * code. This allows the caller to specify a range of - * datasets to verify. - * JRM -- 8/20/15 - * *------------------------------------------------------------------------- */ @@ -2677,10 +2622,6 @@ verify_data_sets(hid_t file_id, int min_dset, int max_dset) * Programmer: John Mainzer * 3/11/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2944,10 +2885,6 @@ verify_cache_image_RO(int file_name_id, int md_write_strat, int mpi_rank) * Programmer: John Mainzer * 1/25/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -3614,8 +3551,6 @@ smoke_check_1(MPI_Comm mpi_comm, MPI_Info mpi_info, int mpi_rank, int mpi_size) * Programmer: John Mainzer * 1/25/17 * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/testpar/t_coll_chunk.c b/testpar/t_coll_chunk.c index c6ed9b1..5f853e3 100644 --- a/testpar/t_coll_chunk.c +++ b/testpar/t_coll_chunk.c @@ -46,8 +46,6 @@ static void coll_chunktest(const char *filename, int chunk_factor, int select_fa * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -97,8 +95,6 @@ coll_chunk1(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -148,8 +144,6 @@ coll_chunk2(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -202,8 +196,6 @@ coll_chunk3(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -254,8 +246,6 @@ coll_chunk4(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -308,8 +298,6 @@ coll_chunk5(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -360,8 +348,6 @@ coll_chunk6(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -412,8 +398,6 @@ coll_chunk7(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -464,8 +448,6 @@ coll_chunk8(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -516,8 +498,6 @@ coll_chunk9(void) * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -559,26 +539,16 @@ coll_chunk10(void) * Function: coll_chunktest * * Purpose: The real testing routine for regular selection of collective - chunking storage - testing both write and read, - If anything fails, it may be read or write. There is no - separation test between read and write. + * chunking storage testing both write and read, + * If anything fails, it may be read or write. There is no + * separation test between read and write. * * Return: Success: 0 - * * Failure: -1 * - * Modifications: - * Remove invalid temporary property checkings for API_LINK_HARD and - * API_LINK_TRUE cases. - * Programmer: Jonathan Kim - * Date: 2012-10-10 - * * Programmer: Unknown * July 12th, 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/testpar/t_filter_read.c b/testpar/t_filter_read.c index 0781594..8895c15 100644 --- a/testpar/t_filter_read.c +++ b/testpar/t_filter_read.c @@ -192,8 +192,6 @@ filter_read_internal(const char *filename, hid_t dcpl, hsize_t *dset_size) * Programmer: Christian Chilan * Tuesday, May 15, 2007 * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/testpar/t_pread.c b/testpar/t_pread.c index 9a2493d..d05ec46 100644 --- a/testpar/t_pread.c +++ b/testpar/t_pread.c @@ -77,8 +77,6 @@ static char *test_argv0 = NULL; * Programmer: Richard Warren * 10/1/17 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -483,8 +481,6 @@ generate_test_file(MPI_Comm comm, int mpi_rank, int group_id) * Programmer: Richard Warren * 10/1/17 * - * Modifications: - * *------------------------------------------------------------------------- */ static int diff --git a/testpar/t_vfd.c b/testpar/t_vfd.c index 512aa5b..86cfe2f 100644 --- a/testpar/t_vfd.c +++ b/testpar/t_vfd.c @@ -117,10 +117,6 @@ static unsigned vector_write_test_7(int file_name_id, int mpi_rank, int mpi_size * Programmer: John Mainzer * 3/25/26 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -199,10 +195,6 @@ alloc_and_init_file_images(int mpi_size) * Programmer: John Mainzer * 1/25/17 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -261,10 +253,6 @@ free_file_images(void) * Programmer: John Mainzer * 3/25/26 * - * Modifications: - * - * Updated for subfiling VFD 9/29/30 - * *------------------------------------------------------------------------- */ @@ -535,10 +523,6 @@ setup_vfd_test_file(int file_name_id, char *file_name, int mpi_size, H5FD_mpio_x * Programmer: John Mainzer * 3/25/26 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -658,10 +642,6 @@ takedown_vfd_test_file(int mpi_rank, char *filename, H5FD_t **lf_ptr, hid_t *fap * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -895,10 +875,6 @@ vector_read_test_1(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer_ * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -1199,10 +1175,6 @@ vector_read_test_2(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer_ * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -1559,10 +1531,6 @@ vector_read_test_3(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer_ * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -1994,10 +1962,6 @@ vector_read_test_4(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer_ * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2240,10 +2204,6 @@ vector_read_test_5(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer_ * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2433,10 +2393,6 @@ vector_write_test_1(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 3/28/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2689,10 +2645,6 @@ vector_write_test_2(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 3/31/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -2956,10 +2908,6 @@ vector_write_test_3(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 3/31/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -3261,10 +3209,6 @@ vector_write_test_4(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 3/31/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -3704,10 +3648,6 @@ vector_write_test_5(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 3/26/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -3965,10 +3905,6 @@ vector_write_test_6(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 10/10/21 * - * Modifications: - * - * None. - * *------------------------------------------------------------------------- */ @@ -4190,8 +4126,6 @@ vector_write_test_7(int file_name_id, int mpi_rank, int mpi_size, H5FD_mpio_xfer * Programmer: John Mainzer * 3/2621/ * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/tools/lib/h5diff.c b/tools/lib/h5diff.c index 1ab9236..ea268f3 100644 --- a/tools/lib/h5diff.c +++ b/tools/lib/h5diff.c @@ -1105,10 +1105,6 @@ done: * * Return: Number of differences found * - * Modifications: Compare the graph and make h5diff return 1 for difference if - * 1) the number of objects in file1 is not the same as in file2 - * 2) the graph does not match, i.e same names (absolute path) - * 3) objects with the same name are not of the same type *------------------------------------------------------------------------- */ hsize_t diff --git a/tools/lib/h5tools_dump.c b/tools/lib/h5tools_dump.c index d80ef1f..435ca87 100644 --- a/tools/lib/h5tools_dump.c +++ b/tools/lib/h5tools_dump.c @@ -232,24 +232,7 @@ h5tools_dump_init(void) * Failure: FAIL * Programmer: * Robb Matzke, Monday, April 26, 1999 - * Modifications: - * Robb Matzke, 1999-06-04 - * The `container' argument is the optional dataset for reference types. * - * Robb Matzke, 1999-09-29 - * Understands the `per_line' property which indicates that every Nth - * element should begin a new line. - * - * Robb Matzke, LLNL, 2003-06-05 - * Do not dereference the memory for a variable-length string here. - * Deref in h5tools_str_sprint() instead so recursive types are - * handled correctly. - * - * Pedro Vicente Nunes, The HDF Group, 2005-10-19 - * pass to the prefix in h5tools_simple_prefix the total position - * instead of the current stripmine position i; this is necessary - * to print the array indices - * new field sm_pos in h5tools_context_t, the current stripmine element position *------------------------------------------------------------------------- */ int diff --git a/tools/lib/h5tools_ref.c b/tools/lib/h5tools_ref.c index d5c1cf9..9f12367 100644 --- a/tools/lib/h5tools_ref.c +++ b/tools/lib/h5tools_ref.c @@ -51,8 +51,6 @@ static int ref_path_table_put(const char *, const H5O_token_t *token); * * Programmer: Quincey Koziol * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -160,8 +158,6 @@ init_ref_path_table(void) * * Programmer: Quincey Koziol * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -187,8 +183,6 @@ term_ref_path_table(void) * * Programmer: REMcG * - * Modifications: - * *------------------------------------------------------------------------- */ int @@ -237,8 +231,6 @@ ref_path_table_lookup(const char *thepath, H5O_token_t *token) * * Programmer: REMcG * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -322,8 +314,6 @@ ref_path_table_gen_fake(const char *path, H5O_token_t *token) * * Programmer: REMcG * - * Modifications: - * *------------------------------------------------------------------------- */ const char * diff --git a/tools/lib/io_timer.c b/tools/lib/io_timer.c index ce21b3e..49a4a20 100644 --- a/tools/lib/io_timer.c +++ b/tools/lib/io_timer.c @@ -57,7 +57,6 @@ sub_time(struct timeval *a, struct timeval *b) * SYS_CLOCK for system time). * Return: Pointer to io_time object * Programmer: Bill Wendling, 01. October 2001 - * Modifications: */ io_time_t * io_time_new(clock_type type) @@ -78,7 +77,6 @@ io_time_new(clock_type type) * function. * Return: Nothing * Programmer: Bill Wendling, 01. October 2001 - * Modifications: */ void io_time_destroy(io_time_t *pt) @@ -97,7 +95,6 @@ io_time_destroy(io_time_t *pt) * timer with the pio_timer_new function (shame!). * Return: Nothing * Programmer: Bill Wendling, 04. October 2001 - * Modifications: */ void set_timer_type(io_time_t *pt, clock_type type) @@ -110,7 +107,6 @@ set_timer_type(io_time_t *pt, clock_type type) * Purpose: Get the type of the timer. * Return: MPI_CLOCK or SYS_CLOCK. * Programmer: Bill Wendling, 04. October 2001 - * Modifications: */ clock_type get_timer_type(io_time_t *pt) @@ -124,7 +120,6 @@ get_timer_type(io_time_t *pt) * Purpose: Set the time in a ``io_time_t'' object. * Return: Pointer to the passed in ``io_time_t'' object if SUCCEED; Null otherwise. * Programmer: Bill Wendling, 01. October 2001 - * Modifications: */ io_time_t * io_time_set(io_time_t *pt, timer_type t, int start_stop) @@ -214,7 +209,6 @@ io_time_set(io_time_t *pt, timer_type t, int start_stop) * Purpose: Get the time from a ``io_time_t'' object. * Return: The number of seconds as a DOUBLE. * Programmer: Bill Wendling, 01. October 2001 - * Modifications: */ H5_ATTR_PURE double io_time_get(io_time_t *pt, timer_type t) diff --git a/tools/libtest/h5tools_test_utils.c b/tools/libtest/h5tools_test_utils.c index 9bc3f76..f060e2c 100644 --- a/tools/libtest/h5tools_test_utils.c +++ b/tools/libtest/h5tools_test_utils.c @@ -372,8 +372,6 @@ H5_GCC_CLANG_DIAG_OFF("format") * Programmer: Jacob Smith * 2017-11-11 * - * Changes: None. - * *---------------------------------------------------------------------------- */ static unsigned @@ -595,8 +593,6 @@ error: * Programmer: Jacob Smith * 2017-11-13 * - * Changes: None - * *---------------------------------------------------------------------------- */ static unsigned @@ -975,8 +971,6 @@ error: * Programmer: Jacob Smith * 2018-07-12 * - * Changes: None - * *---------------------------------------------------------------------------- */ static unsigned @@ -1229,8 +1223,6 @@ H5_GCC_CLANG_DIAG_ON("format") * Programmer: Jacob Smith * 2017-11-10 * - * Changes: None. - * *---------------------------------------------------------------------------- */ int diff --git a/tools/src/h5copy/h5copy.c b/tools/src/h5copy/h5copy.c index 3f8f8cf..9756d11 100644 --- a/tools/src/h5copy/h5copy.c +++ b/tools/src/h5copy/h5copy.c @@ -46,8 +46,6 @@ char *str_flag = NULL; * Programmer: Quincey Koziol * Saturday, 31. January 2004 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -77,8 +75,6 @@ leave(int ret) * * Programmer: Pedro Vicente Nunes, 7/8/2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -159,8 +155,6 @@ usage(void) * * Programmer: Pedro Vicente Nunes, 7/8/2006 * - * Modifications: - * *------------------------------------------------------------------------- */ @@ -207,8 +201,6 @@ parse_flag(const char *s_flag, unsigned *flag) * * Programmer: Pedro Vicente Nunes * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/tools/src/h5diff/h5diff_main.c b/tools/src/h5diff/h5diff_main.c index 9aa0cdd..561f139 100644 --- a/tools/src/h5diff/h5diff_main.c +++ b/tools/src/h5diff/h5diff_main.c @@ -30,36 +30,6 @@ * * Comments: * - * Modifications: July 2004 - * Introduced the four modes: - * Normal mode: print the number of differences found and where they occurred - * Report mode: print the above plus the differences - * Verbose mode: print the above plus a list of objects and warnings - * Quiet mode: do not print output - * - * November 2004: Leon Arber (larber@uiuc.edu) - * Additions that allow h5diff to be run in parallel - * - * February 2005: Leon Arber (larber@uiuc.edu) - * h5diff and ph5diff split into two files, one that is used - * to build a serial h5diff and one used to build a parallel h5diff - * Common functions have been moved to h5diff_common.c - * - * October 2005 - * Introduced a new field 'not_cmp' to 'diff_opt_t' that detects - * if some objects are not comparable and prints the message - * "Some objects are not comparable" - * - * February 2007 - * Added comparison for dataset regions. - * Added support for reading and comparing by hyperslabs for large files. - * Inclusion of a relative error formula to compare floating - * point numbers in order to deal with floating point uncertainty. - * Printing of dataset dimensions along with dataset name - * - * November 19, 2007 - * adopted the syntax h5diff [OPTIONS] file1 file2 [obj1[obj2]] - * *------------------------------------------------------------------------- */ @@ -147,8 +117,6 @@ main(int argc, char *argv[]) * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ H5_ATTR_NORETURN void diff --git a/tools/src/h5diff/ph5diff_main.c b/tools/src/h5diff/ph5diff_main.c index ee8669f..64b1f28 100644 --- a/tools/src/h5diff/ph5diff_main.c +++ b/tools/src/h5diff/ph5diff_main.c @@ -116,10 +116,6 @@ main(int argc, char *argv[]) * Programmer: Leon Arber * Date: January 2005 * - * Comments: - * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -286,10 +282,6 @@ print_manager_output(void) * Programmer: Albert Cheng * Date: Feb 6, 2005 * - * Comments: - * - * Modifications: - * *------------------------------------------------------------------------- */ void diff --git a/tools/src/h5dump/h5dump.c b/tools/src/h5dump/h5dump.c index 76c9596..1c22124 100644 --- a/tools/src/h5dump/h5dump.c +++ b/tools/src/h5dump/h5dump.c @@ -1695,8 +1695,6 @@ done: * * Return: void * - * Modifications: - * *------------------------------------------------------------------------- */ static void diff --git a/tools/src/h5import/h5import.c b/tools/src/h5import/h5import.c index 0bdd6d0..e63b6a8 100644 --- a/tools/src/h5import/h5import.c +++ b/tools/src/h5import/h5import.c @@ -346,9 +346,6 @@ gtoken(char *s) * * Programmer: pkmat * - * Modifications: pvn - * 7/23/2007. Added support for STR type, extra parameter FILE_ID - * *------------------------------------------------------------------------- */ diff --git a/tools/src/h5perf/pio_engine.c b/tools/src/h5perf/pio_engine.c index 5c99443..2238aac 100644 --- a/tools/src/h5perf/pio_engine.c +++ b/tools/src/h5perf/pio_engine.c @@ -133,8 +133,6 @@ static off_t sqrto(off_t); * Purpose: PIO Engine where Parallel IO are executed. * Return: results * Programmer: Albert Cheng, Bill Wendling 2001/12/12 - * Modifications: - * Added 2D testing (Christian Chilan, 10. August 2005) */ results do_pio(parameters param) @@ -382,7 +380,6 @@ done: * USER or LOGIN are specified in the environment. * Return: Pointer to filename or NULL * Programmer: Bill Wendling, 21. November 2001 - * Modifications: */ static char * pio_create_filename(iotype iot, const char *base_name, char *fullname, size_t size) @@ -497,8 +494,6 @@ pio_create_filename(iotype iot, const char *base_name, char *fullname, size_t si * Purpose: Write the required amount of data to the file. * Return: SUCCESS or FAIL * Programmer: Albert Cheng, Bill Wendling, 2001/12/13 - * Modifications: - * Added 2D testing (Christian Chilan, 10. August 2005) */ static herr_t do_write(results *res, file_descr *fd, parameters *parms, long ndsets, off_t nbytes, size_t buf_size, @@ -1514,8 +1509,6 @@ sqrto(off_t x) * Purpose: read the required amount of data from the file. * Return: SUCCESS or FAIL * Programmer: Albert Cheng 2001/12/13 - * Modifications: - * Added 2D testing (Christian Chilan, 10. August 2005) */ static herr_t do_read(results *res, file_descr *fd, parameters *parms, long ndsets, off_t nbytes, size_t buf_size, @@ -2497,7 +2490,6 @@ done: * Purpose: Open the specified file. * Return: SUCCESS or FAIL * Programmer: Albert Cheng, Bill Wendling, 2001/12/13 - * Modifications: */ static herr_t do_fopen(parameters *param, char *fname, file_descr *fd /*out*/, int flags) @@ -2607,7 +2599,6 @@ done: * Purpose: Close the specified file descriptor. * Return: SUCCESS or FAIL * Programmer: Albert Cheng, Bill Wendling, 2001/12/13 - * Modifications: */ static herr_t do_fclose(iotype iot, file_descr *fd /*out*/) @@ -2664,7 +2655,6 @@ done: * Other processes just return. * Return: void * Programmer: Albert Cheng 2001/12/12 - * Modifications: */ static void do_cleanupfile(iotype iot, char *fname) diff --git a/tools/src/h5perf/pio_perf.c b/tools/src/h5perf/pio_perf.c index 26e90f8..d4b302e 100644 --- a/tools/src/h5perf/pio_perf.c +++ b/tools/src/h5perf/pio_perf.c @@ -206,7 +206,6 @@ static off_t squareo(off_t); * function. * Return: EXIT_SUCCESS or EXIT_FAILURE * Programmer: Bill Wendling, 30. October 2001 - * Modifications: */ int main(int argc, char *argv[]) @@ -303,8 +302,6 @@ squareo(off_t x) * * Return: Nothing * Programmer: Bill Wendling, 30. October 2001 - * Modifications: - * Added 2D testing (Christian Chilan, 10. August 2005) */ static void run_test_loop(struct options *opts) @@ -399,7 +396,6 @@ run_test_loop(struct options *opts) * Purpose: Inner loop call to actually run the I/O test. * Return: Nothing * Programmer: Bill Wendling, 18. December 2001 - * Modifications: */ static int run_test(iotype iot, parameters parms, struct options *opts) @@ -715,7 +711,6 @@ run_test(iotype iot, parameters parms, struct options *opts) * Purpose: * Return: Nothing * Programmer: Bill Wendling, 29. January 2002 - * Modifications: */ static void output_all_info(minmax *mm, int count, int indent_level) @@ -738,12 +733,6 @@ output_all_info(minmax *mm, int count, int indent_level) * object. * Return: 0 if all is fine; otherwise non-zero. * Programmer: Albert Cheng, 2002/05/21. - * Modifications: - * Bill Wendling, 2002/05/31 - * Modified so that the HDF5_MPI_INFO environment variable can - * be a semicolon separated list of "key=value" pairings. Most - * of the code is to remove any whitespaces which might be - * surrounding the "key=value" pairs. */ int h5_set_info_object(void) @@ -836,7 +825,6 @@ h5_set_info_object(void) * Purpose: Display content of an MPI Info object * Return: void * Programmer: Albert Cheng 2002/05/21 - * Modifications: */ void h5_dump_info_object(MPI_Info info) @@ -866,8 +854,6 @@ h5_dump_info_object(MPI_Info info) * Purpose: Gather all the min, max and total of val. * Return: Nothing * Programmer: Bill Wendling, 21. December 2001 - * Modifications: - * Use MPI_Allreduce to do it. -akc, 2002/01/11 */ static void get_minmax(minmax *mm, double val) @@ -888,8 +874,6 @@ get_minmax(minmax *mm, double val) * across all processes. * Return: TOTAL_MM - the total of all of these. * Programmer: Bill Wendling, 21. December 2001 - * Modifications: - * Changed to use seconds instead of MB/s - QAK, 5/9/02 */ static minmax accumulate_minmax_stuff(minmax *mm, int count) @@ -924,7 +908,6 @@ accumulate_minmax_stuff(minmax *mm, int count) * Return: SUCCESS on success. * FAIL otherwise. * Programmer: Bill Wendling, 19. December 2001 - * Modifications: */ static int create_comm_world(int num_procs, int *doing_pio) @@ -983,7 +966,6 @@ error_done: * Return: SUCCESS on success. * FAIL otherwise. * Programmer: Bill Wendling, 19. December 2001 - * Modifications: */ static int destroy_comm_world(void) @@ -1003,7 +985,6 @@ destroy_comm_world(void) * minmax & # of iterations. * Return: Nothing * Programmer: Quincey Koziol, 9. May 2002 - * Modifications: */ static void output_results(const struct options *opts, const char *name, minmax *table, int table_size, off_t data_size) @@ -1067,7 +1048,6 @@ output_times(const struct options *opts, const char *name, minmax *table, int ta * Purpose: Print a line of the report. Only do so if I'm the 0 process. * Return: Nothing * Programmer: Bill Wendling, 19. December 2001 - * Modifications: */ static void output_report(const char *fmt, ...) @@ -1266,8 +1246,6 @@ report_parameters(struct options *opts) * structure which will need to be freed by the calling function. * Return: Pointer to an OPTIONS structure * Programmer: Bill Wendling, 31. October 2001 - * Modifications: - * Added 2D testing (Christian Chilan, 10. August 2005) */ static struct options * parse_command_line(int argc, const char *const *argv) @@ -1518,7 +1496,6 @@ parse_command_line(int argc, const char *const *argv) * If an unknown size indicator is used, then the program will * exit with EXIT_FAILURE as the return value. * Programmer: Bill Wendling, 18. December 2001 - * Modifications: */ static off_t parse_size_directive(const char *size) @@ -1559,8 +1536,6 @@ parse_size_directive(const char *size) * Purpose: Print a usage message and then exit. * Return: Nothing * Programmer: Bill Wendling, 31. October 2001 - * Modifications: - * Added 2D testing (Christian Chilan, 10. August 2005) */ static void usage(const char *prog) diff --git a/tools/src/h5perf/sio_engine.c b/tools/src/h5perf/sio_engine.c index 376fc0b..b80189b 100644 --- a/tools/src/h5perf/sio_engine.c +++ b/tools/src/h5perf/sio_engine.c @@ -282,7 +282,6 @@ done: * USER or LOGIN are specified in the environment. * Return: Pointer to filename or NULL * Programmer: Bill Wendling, 21. November 2001 - * Modifications: Support for file drivers. Christian Chilan, April, 2008 */ static char * sio_create_filename(iotype iot, const char *base_name, char *fullname, size_t size, parameters *param) @@ -403,7 +402,6 @@ sio_create_filename(iotype iot, const char *base_name, char *fullname, size_t si * Purpose: Write the required amount of data to the file. * Return: SUCCESS or FAIL * Programmer: Christian Chilan, April, 2008 - * Modifications: */ static herr_t do_write(results *res, file_descr *fd, parameters *parms, void *buffer) @@ -618,7 +616,6 @@ done: * Purpose: Write buffer into the dataset. * Return: SUCCESS or FAIL * Programmer: Christian Chilan, April, 2008 - * Modifications: */ static herr_t dset_write(int local_dim, file_descr *fd, parameters *parms, void *buffer) @@ -701,7 +698,6 @@ done: * Purpose: Write buffer into the POSIX file considering contiguity. * Return: SUCCESS or FAIL * Programmer: Christian Chilan, April, 2008 - * Modifications: */ static herr_t @@ -762,7 +758,6 @@ done: * Purpose: Read the required amount of data to the file. * Return: SUCCESS or FAIL * Programmer: Christian Chilan, April, 2008 - * Modifications: */ static herr_t do_read(results *res, file_descr *fd, parameters *parms, void *buffer) @@ -940,7 +935,6 @@ done: * Purpose: Read buffer into the dataset. * Return: SUCCESS or FAIL * Programmer: Christian Chilan, April, 2008 - * Modifications: */ static herr_t @@ -1002,7 +996,6 @@ done: * Purpose: Read buffer into the POSIX file considering contiguity. * Return: SUCCESS or FAIL * Programmer: Christian Chilan, April, 2008 - * Modifications: */ static herr_t @@ -1057,7 +1050,6 @@ done: * Purpose: Open the specified file. * Return: SUCCESS or FAIL * Programmer: Albert Cheng, Bill Wendling, 2001/12/13 - * Modifications: Support for file drivers, Christian Chilan, April, 2008 */ static herr_t do_fopen(parameters *param, char *fname, file_descr *fd /*out*/, int flags) @@ -1223,7 +1215,6 @@ set_vfd(parameters *param) * Purpose: Close the specified file descriptor. * Return: SUCCESS or FAIL * Programmer: Albert Cheng, Bill Wendling, 2001/12/13 - * Modifications: */ static herr_t do_fclose(iotype iot, file_descr *fd /*out*/) diff --git a/tools/src/h5perf/sio_perf.c b/tools/src/h5perf/sio_perf.c index fc300fb..ef9e7db 100644 --- a/tools/src/h5perf/sio_perf.c +++ b/tools/src/h5perf/sio_perf.c @@ -182,7 +182,6 @@ static void report_parameters(struct options *opts); * Purpose: Start things up. * Return: EXIT_SUCCESS or EXIT_FAILURE * Programmer: Bill Wendling, 30. October 2001 - * Modifications: */ int main(int argc, char *argv[]) @@ -237,8 +236,6 @@ finish: * * Return: Nothing * Programmer: Bill Wendling, 30. October 2001 - * Modifications: - * Added multidimensional testing (Christian Chilan, April, 2008) */ static void run_test_loop(struct options *opts) @@ -292,7 +289,6 @@ run_test_loop(struct options *opts) * Purpose: Inner loop call to actually run the I/O test. * Return: Nothing * Programmer: Bill Wendling, 18. December 2001 - * Modifications: */ static int run_test(iotype iot, parameters parms, struct options *opts) @@ -524,7 +520,6 @@ run_test(iotype iot, parameters parms, struct options *opts) * Purpose: * Return: Nothing * Programmer: Bill Wendling, 29. January 2002 - * Modifications: */ static void output_all_info(minmax *mm, int count, int indent_level) @@ -546,8 +541,6 @@ output_all_info(minmax *mm, int count, int indent_level) * Purpose: Gather all the min, max and total of val. * Return: Nothing * Programmer: Bill Wendling, 21. December 2001 - * Modifications: - * Use MPI_Allreduce to do it. -akc, 2002/01/11 */ static void @@ -564,8 +557,6 @@ get_minmax(minmax *mm, double val) * across all processes. * Return: TOTAL_MM - the total of all of these. * Programmer: Bill Wendling, 21. December 2001 - * Modifications: - * Changed to use seconds instead of MB/s - QAK, 5/9/02 */ static void accumulate_minmax_stuff(const minmax *mm, int count, minmax *total_mm) @@ -596,7 +587,6 @@ accumulate_minmax_stuff(const minmax *mm, int count, minmax *total_mm) * minmax & # of iterations. * Return: Nothing * Programmer: Quincey Koziol, 9. May 2002 - * Modifications: */ static void output_results(const struct options *opts, const char *name, minmax *table, int table_size, off_t data_size) @@ -637,7 +627,6 @@ output_results(const struct options *opts, const char *name, minmax *table, int * Purpose: Print a line of the report. Only do so if I'm the 0 process. * Return: Nothing * Programmer: Bill Wendling, 19. December 2001 - * Modifications: */ static void output_report(const char *fmt, ...) @@ -812,8 +801,6 @@ report_parameters(struct options *opts) * structure which will need to be freed by the calling function. * Return: Pointer to an OPTIONS structure * Programmer: Bill Wendling, 31. October 2001 - * Modifications: - * Added multidimensional testing (Christian Chilan, April, 2008) */ static struct options * parse_command_line(int argc, const char *const *argv) @@ -1180,7 +1167,6 @@ parse_command_line(int argc, const char *const *argv) * If an unknown size indicator is used, then the program will * exit with EXIT_FAILURE as the return value. * Programmer: Bill Wendling, 18. December 2001 - * Modifications: */ static hsize_t @@ -1225,7 +1211,6 @@ parse_size_directive(const char *size) * Purpose: Print a usage message and then exit. * Return: Nothing * Programmer: Bill Wendling, 31. October 2001 - * Modifications: */ static void usage(const char *prog) diff --git a/tools/src/h5stat/h5stat.c b/tools/src/h5stat/h5stat.c index d29c6e4..04d1723 100644 --- a/tools/src/h5stat/h5stat.c +++ b/tools/src/h5stat/h5stat.c @@ -335,18 +335,6 @@ attribute_stats(iter_t *iter, const H5O_info2_t *oi, const H5O_native_info_t *na * Programmer: Quincey Koziol * Tuesday, August 16, 2005 * - * Modifications: Refactored code from the walk_function - * EIP, Wednesday, August 16, 2006 - * - * Vailin Choi 12 July 2007 - * 1. Gathered storage info for btree and heap - * (groups and attributes) - * 2. Gathered info for attributes - * - * Vailin Choi 14 July 2007 - * Cast "num_objs" and "num_attrs" to size_t - * Due to the -Mbounds problem for the pgi-32 bit compiler on indexing - * *------------------------------------------------------------------------- */ static herr_t @@ -1103,8 +1091,6 @@ iter_free(iter_t *iter) * Programmer: Elena Pourmal * Saturday, August 12, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -1190,11 +1176,6 @@ print_file_metadata(const iter_t *iter) * Programmer: Elena Pourmal * Saturday, August 12, 2006 * - * Modifications: - * bug #1253; Oct 6th 2008; Vailin Choi - * Fixed segmentation fault: print iter->group_bins[0] when - * there is iter->group_nbins - * *------------------------------------------------------------------------- */ static herr_t @@ -1636,8 +1617,6 @@ print_file_statistics(const iter_t *iter) * Programmer: Elena Pourmal * Thursday, August 17, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -1658,8 +1637,6 @@ print_object_statistics(const char *name) * Programmer: Elena Pourmal * Thursday, August 17, 2006 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -1674,10 +1651,6 @@ print_statistics(const char *name, const iter_t *iter) /*------------------------------------------------------------------------- * Function: main * - * Modifications: - * 2/2010; Vailin Choi - * Get the size of user block - * *------------------------------------------------------------------------- */ int diff --git a/tools/src/misc/h5repart.c b/tools/src/misc/h5repart.c index ac10944..c01ec0f 100644 --- a/tools/src/misc/h5repart.c +++ b/tools/src/misc/h5repart.c @@ -45,8 +45,6 @@ * Programmer: Robb Matzke * Wednesday, May 13, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -146,8 +144,6 @@ get_size(const char *progname, int *argno, int argc, char *argv[]) * Programmer: Robb Matzke * Wednesday, May 13, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ H5_GCC_CLANG_DIAG_OFF("format-nonliteral") diff --git a/tools/test/h5dump/binread.c b/tools/test/h5dump/binread.c index 484e354..2315e85 100644 --- a/tools/test/h5dump/binread.c +++ b/tools/test/h5dump/binread.c @@ -39,8 +39,6 @@ * * Programmer: Pedro Vicente Nunes * - * Modifications: - * *------------------------------------------------------------------------- */ static void diff --git a/tools/test/h5dump/h5dumpgentest.c b/tools/test/h5dump/h5dumpgentest.c index 7e8e19b..1fd512c 100644 --- a/tools/test/h5dump/h5dumpgentest.c +++ b/tools/test/h5dump/h5dumpgentest.c @@ -7175,10 +7175,6 @@ gent_fs_strategy_threshold(void) * Create one dataset with (set_chunk, fixed dims, fixed max. dims) * so that Fixed Array indexing will be used. * - * Modifications: - * Fixed Array indexing will be used for chunked dataset - * with fixed max. dims setting. - * */ static void gent_dataset_idx(void) diff --git a/tools/test/h5repack/testh5repack_detect_szip.c b/tools/test/h5repack/testh5repack_detect_szip.c index f4e4aec..b2be484 100644 --- a/tools/test/h5repack/testh5repack_detect_szip.c +++ b/tools/test/h5repack/testh5repack_detect_szip.c @@ -30,10 +30,6 @@ * * Date: * - * Comments: - * - * Modifications: - * *------------------------------------------------------------------------- */ diff --git a/tools/test/h5stat/testh5stat.sh.in b/tools/test/h5stat/testh5stat.sh.in index 9cbedce..65e40c4 100644 --- a/tools/test/h5stat/testh5stat.sh.in +++ b/tools/test/h5stat/testh5stat.sh.in @@ -12,10 +12,6 @@ # # Tests for the h5stat tool # -# Modifications: -# Vailin Choi; July 2013 -# Add tests for -l, -m, -a options -# srcdir=@srcdir@ diff --git a/tools/test/perform/chunk.c b/tools/test/perform/chunk.c index 27ada87..3f4b3d7 100644 --- a/tools/test/perform/chunk.c +++ b/tools/test/perform/chunk.c @@ -97,8 +97,6 @@ const H5Z_class2_t H5Z_COUNTER[1] = {{ * Programmer: Robb Matzke * Thursday, May 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static size_t @@ -123,8 +121,6 @@ counter(unsigned H5_ATTR_UNUSED flags, size_t H5_ATTR_UNUSED cd_nelmts, * Programmer: Robb Matzke * Thursday, May 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -175,8 +171,6 @@ create_dataset(void) * Programmer: Robb Matzke * Thursday, May 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static double @@ -247,8 +241,6 @@ test_rowmaj(int op, size_t cache_size, size_t io_size) * Programmer: Robb Matzke * Friday, May 15, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static double @@ -318,8 +310,6 @@ test_diag(int op, size_t cache_size, size_t io_size, size_t offset) * Programmer: Robb Matzke * Thursday, May 14, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/tools/test/perform/overhead.c b/tools/test/perform/overhead.c index 69a8251..257d3ec 100644 --- a/tools/test/perform/overhead.c +++ b/tools/test/perform/overhead.c @@ -62,8 +62,6 @@ typedef enum fill_t { FILL_ALL, FILL_FORWARD, FILL_REVERSE, FILL_INWARD, FILL_OU * Programmer: Robb Matzke * Wednesday, September 30, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -111,8 +109,6 @@ usage(const char *prog) * Programmer: Robb Matzke * Thursday, June 4, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -135,8 +131,6 @@ cleanup(void) * Programmer: Robb Matzke * Wednesday, March 4, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -160,8 +154,6 @@ display_error_cb(hid_t estack, void H5_ATTR_UNUSED *client_data) * Programmer: Robb Matzke * Wednesday, September 30, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -333,8 +325,6 @@ error: * Programmer: Robb Matzke * Monday, September 28, 1998 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/tools/test/perform/perf_meta.c b/tools/test/perform/perf_meta.c index 94fe849..6e62f6a 100644 --- a/tools/test/perform/perf_meta.c +++ b/tools/test/perform/perf_meta.c @@ -68,13 +68,11 @@ void print_perf(p_time, p_time, p_time); /*------------------------------------------------------------------------- * Function: parse_options * - Purpose: Parse command line options + * Purpose: Parse command line options * * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static int @@ -188,13 +186,11 @@ parse_options(int argc, char **argv) /*------------------------------------------------------------------------- * Function: usage * - Purpose: Prints help page + * Purpose: Prints help page * * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static void @@ -248,8 +244,6 @@ usage(void) * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -288,8 +282,6 @@ error: * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -330,8 +322,6 @@ error: * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -435,8 +425,6 @@ error: * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -538,8 +526,6 @@ error: * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ static herr_t @@ -644,8 +630,6 @@ error: * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ double @@ -674,8 +658,6 @@ retrieve_time(void) * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ void @@ -728,8 +710,6 @@ perf(p_time *perf_t, double start_t, double end_t) * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ void @@ -756,8 +736,6 @@ print_perf(p_time open_t, p_time close_t, p_time attr_t) * Programmer: Raymond Lu * Friday, Oct 3, 2003 * - * Modifications: - * *------------------------------------------------------------------------- */ int diff --git a/tools/test/perform/zip_perf.c b/tools/test/perform/zip_perf.c index 19b29ba..256289c 100644 --- a/tools/test/perform/zip_perf.c +++ b/tools/test/perform/zip_perf.c @@ -77,7 +77,6 @@ static struct h5_long_options l_opts[] = {{"help", no_arg, 'h'}, * Function: error * Purpose: Display error message and exit. * Programmer: Bill Wendling, 05. June 2002 - * Modifications: */ static void error(const char *fmt, ...) @@ -99,7 +98,6 @@ error(const char *fmt, ...) * Purpose: Cleanup the output file. * Returns: Nothing * Programmer: Bill Wendling, 06. June 2002 - * Modifications: */ static void cleanup(void) @@ -164,7 +162,6 @@ write_file(Bytef *source, uLongf sourceLen) * Z_BUF_ERROR - not enough room in the output buffer * Z_STREAM_ERROR - level parameter is invalid * Programmer: Bill Wendling, 05. June 2002 - * Modifications: */ static void compress_buffer(Bytef *dest, uLongf *destLen, const Bytef *source, uLong sourceLen) @@ -198,7 +195,6 @@ compress_buffer(Bytef *dest, uLongf *destLen, const Bytef *source, uLong sourceL * pre-existing files. * Returns: Nothing * Programmer: Bill Wendling, 06. June 2002 - * Modifications: */ #define ZIP_PERF_FILE "zip_perf.data" static void @@ -235,7 +231,6 @@ get_unique_name(void) * Purpose: Print a usage message and then exit. * Return: Nothing * Programmer: Bill Wendling, 05. June 2002 - * Modifications: */ static void usage(void) @@ -278,7 +273,6 @@ usage(void) * If an unknown size indicator is used, then the program will * exit with EXIT_FAILURE as the return value. * Programmer: Bill Wendling, 05. June 2002 - * Modifications: */ static unsigned long parse_size_directive(const char *size) @@ -467,7 +461,6 @@ do_write_test(unsigned long file_size, unsigned long min_buf_size, unsigned long * Purpose: Run the program * Return: EXIT_SUCCESS or EXIT_FAILURE * Programmer: Bill Wendling, 05. June 2002 - * Modifications: */ int main(int argc, char *argv[]) @@ -555,7 +548,6 @@ main(int argc, char *argv[]) * zlib stuff. * Return: EXIT_SUCCESS * Programmer: Bill Wendling, 10. June 2002 - * Modifications: */ int main(void) diff --git a/utils/tools/h5dwalk/h5dwalk.c b/utils/tools/h5dwalk/h5dwalk.c index e91fd19..acb1724 100644 --- a/utils/tools/h5dwalk/h5dwalk.c +++ b/utils/tools/h5dwalk/h5dwalk.c @@ -1694,8 +1694,6 @@ main(int argc, char *argv[]) * * Comments: * - * Modifications: - * *------------------------------------------------------------------------- */ H5_ATTR_NORETURN void |