diff options
| author | Jonathan Kim <jkm@hdfgroup.org> | 2013-02-05 16:13:49 (GMT) |
|---|---|---|
| committer | Jonathan Kim <jkm@hdfgroup.org> | 2013-02-05 16:13:49 (GMT) |
| commit | bf59bd4d095272019248fd42ca71455fe2712952 (patch) | |
| tree | 9c9a94be92b07e6d61d16368f0bd86abb095f71b | |
| parent | ccdd2b66f1b00b2e7cad60754fcbdd8f069bd6ae (diff) | |
| download | hdf5-bf59bd4d095272019248fd42ca71455fe2712952.zip hdf5-bf59bd4d095272019248fd42ca71455fe2712952.tar.gz hdf5-bf59bd4d095272019248fd42ca71455fe2712952.tar.bz2 | |
[svn-r23229]
Purpose:
Revert back one of the coverity updates from previous (r23220) checkin. "r20457: Coverity issue 691" in previous svn log. Only revert the change about using "STDOUT_FILENO".
Description:
Using "STDOUT_FILENO" caused error on Windows. On unix it's defined in <unistd.h>, but not in Windows. After a little discussion with Allen, he remembered how the similar case were handled for h5dump redirecting those streams. (in h5dump.c) However it would requires more attention to apply, so this issue is entered as a separate task in jira HDDFV-8306.
Tested:
jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE), fred (mac64-LE)
| -rw-r--r-- | tools/h5jam/h5unjam.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/h5jam/h5unjam.c b/tools/h5jam/h5unjam.c index 18b5f11..691e2f2 100644 --- a/tools/h5jam/h5unjam.c +++ b/tools/h5jam/h5unjam.c @@ -307,7 +307,7 @@ main(int argc, const char *argv[]) if (ub_file == NULL) { /* write to sdtout */ - ufid = STDOUT_FILENO; + ufid = HDdup(1); } else { ufid = HDopen(ub_file,O_WRONLY|O_CREAT|O_TRUNC, 0644 ); |