summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLarry Knox <lrknox@hdfgroup.org>2023-09-30 00:50:27 (GMT)
committerGitHub <noreply@github.com>2023-09-30 00:50:27 (GMT)
commitc423e74fbfbfe84497210e5b15db20bee8c84c3c (patch)
tree57ace42cf75642443af3eea5a92c57ae93d17cd9
parent9f00c099dbcd1e5e287bc6c35cb028dfac4118dc (diff)
downloadhdf5-c423e74fbfbfe84497210e5b15db20bee8c84c3c.zip
hdf5-c423e74fbfbfe84497210e5b15db20bee8c84c3c.tar.gz
hdf5-c423e74fbfbfe84497210e5b15db20bee8c84c3c.tar.bz2
Removed the use of -commons linking option on Darwin (#3581) (#3618)
-rw-r--r--configure.ac8
-rw-r--r--fortran/src/H5f90global.F902
-rw-r--r--release_docs/RELEASE.txt5
3 files changed, 4 insertions, 11 deletions
diff --git a/configure.ac b/configure.ac
index 0fad0ae..c5e08f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1077,14 +1077,6 @@ H5_FORTRAN_SHARED="no"
if test "X${HDF_FORTRAN}" = "Xyes" && test "X${enable_shared}" != "Xno"; then
AC_MSG_CHECKING([if shared Fortran libraries are supported])
H5_FORTRAN_SHARED="yes"
- ## tell libtool to do the right thing with COMMON symbols, this fixes
- ## corrupt values with COMMON and EQUIVALENCE when building shared
- ## Fortran libraries on OSX with gnu and Intel compilers (HDFFV-2772).
- case "`uname`" in
- Darwin*)
- H5_LDFLAGS="$H5_LDFLAGS -Wl,-commons,use_dylibs"
- ;;
- esac
## Report results of check(s)
diff --git a/fortran/src/H5f90global.F90 b/fortran/src/H5f90global.F90
index 718b95d..fe57550 100644
--- a/fortran/src/H5f90global.F90
+++ b/fortran/src/H5f90global.F90
@@ -9,8 +9,6 @@
! PURPOSE
! This module is used to pass C stubs for H5 Fortran APIs. The C stubs are
! packed into arrays in H5_f.c and these arrays are then passed to Fortran.
-! This module then uses EQUIVALENCE to assign elements of the arrays to
-! Fortran equivalent C stubs.
!
! NOTES
! The size of the C arrays in H5_f.c has to match the values of the variables
diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt
index b237ad1..4287fcf 100644
--- a/release_docs/RELEASE.txt
+++ b/release_docs/RELEASE.txt
@@ -138,7 +138,10 @@ New Features
Fortran Library:
----------------
- -
+ - Removed "-commons" linking option on Darwin, as COMMON and EQUIVALENCE
+ are no longer used in the Fortran source.
+
+ Fixes GitHub issue #3571
C++ Library: