summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlbert Cheng <acheng@hdfgroup.org>2001-12-05 17:18:29 (GMT)
committerAlbert Cheng <acheng@hdfgroup.org>2001-12-05 17:18:29 (GMT)
commite9f142f85d33cc182f99826b542a121f351e8e28 (patch)
tree965e7479f0c57b7b17485fed086b94e4a83b8283
parent130f85df82bbb39c458f92cbfe0d58f926c13335 (diff)
downloadhdf5-e9f142f85d33cc182f99826b542a121f351e8e28.zip
hdf5-e9f142f85d33cc182f99826b542a121f351e8e28.tar.gz
hdf5-e9f142f85d33cc182f99826b542a121f351e8e28.tar.bz2
[svn-r4671] Purpose:
Bug fix Description: Snapshot does "make check" directly, instead of building all binary first. This means it does not cover code that are not tested (e.g., example, perform). (That explained why the errors in the PIO performance code were not reported in daily test but blew up when people built the library the "normal" way.) It is done this way so that the snaptest aborts as soon as the first test failed rather than after all code are compiled. Solution: Add "make" (to build all binary) before "make check". The allows snaptest to fail as soon as the first compiling failure. If we wish the snaptest to abort on the first test failure, the two can be swapped as "make check && make ...". (It would appear strange to run tests then make binary.) Platforms tested: Would be tested in the daily test tonight. (I should have tested it first but I started this commit process already. Sorry.)
-rwxr-xr-xbin/snapshot3
1 files changed, 2 insertions, 1 deletions
diff --git a/bin/snapshot b/bin/snapshot
index 520e2b2..c67b756 100755
--- a/bin/snapshot
+++ b/bin/snapshot
@@ -256,10 +256,11 @@ if [ "$cmd" = "all" -o -n "$cmdtest" ]; then
fi
fi
- # Make sure all the serial tests work.
+ # Build, run tests and install procedures
if [ "$snapshot" = "yes" ]; then
if (cd ${TESTDIR} && \
${srcdir:+${CURRENT}/}${CONFIGURE} --prefix=$INSTALLDIR && \
+ ${MAKE} && \
${MAKE} check && \
${MAKE} install install-doc && \
${MAKE} uninstall uninstall-doc); then