diff options
| author | Thomas Haller <thaller@redhat.com> | 2022-04-22 16:47:18 (GMT) |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2022-04-22 17:04:19 (GMT) |
| commit | 31380f8b93ce3390e3aa32d593d56b0d05b3f73a (patch) | |
| tree | a9b4768f9989547167a2b456d0f5b49c1975d383 | |
| parent | aa398b5fdaa27678069ea7b4a322b14281075db4 (diff) | |
| download | libnl-31380f8b93ce3390e3aa32d593d56b0d05b3f73a.zip libnl-31380f8b93ce3390e3aa32d593d56b0d05b3f73a.tar.gz libnl-31380f8b93ce3390e3aa32d593d56b0d05b3f73a.tar.bz2 | |
utils: suppress coverity warning in nl_cli_load_module() about leaked handle
It's unclear to me, how to avoid this "leak". It's intentional, given the
existing API. Try to suppress the warning.
Error: RESOURCE_LEAK (CWE-772):
libnl-3.6.0/src/lib/utils.c:232: alloc_fn: Storage is returned from allocation function "dlopen".
libnl-3.6.0/src/lib/utils.c:232: var_assign: Assigning: "handle" = storage returned from "dlopen(path, 2)".
libnl-3.6.0/src/lib/utils.c:236: leaked_storage: Variable "handle" going out of scope leaks the storage it points to.
# 234| path, dlerror());
# 235| }
# 236|-> }
# 237| #else
# 238| nl_cli_fatal(ENOTSUP, "Unable to load module \"%s\": built without dynamic libraries support\n",
| -rw-r--r-- | src/lib/utils.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/utils.c b/src/lib/utils.c index 2dc7783..cbcdafe 100644 --- a/src/lib/utils.c +++ b/src/lib/utils.c @@ -234,6 +234,8 @@ void nl_cli_load_module(const char *prefix, const char *name) nl_cli_fatal(ENOENT, "Unable to load module \"%s\": %s\n", path, dlerror()); } + /* We intentionally leak the dlopen handle. */ + /* coverity[RESOURCE_LEAK] */ } #else nl_cli_fatal(ENOTSUP, "Unable to load module \"%s\": built without dynamic libraries support\n", |