summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSanthosh Kumar <sshanmugham@twitter.com>2017-03-21 17:38:36 (GMT)
committerThomas Haller <thaller@redhat.com>2017-05-03 11:00:42 (GMT)
commita20a49fa5411aa98318a1a1313f3d993b1bceb54 (patch)
tree341719855569f4794df4d7d33fb9541b264a05e1
parent7a26c7934b64816ebf66ad4b129271633fb38a9a (diff)
downloadlibnl-a20a49fa5411aa98318a1a1313f3d993b1bceb54.zip
libnl-a20a49fa5411aa98318a1a1313f3d993b1bceb54.tar.gz
libnl-a20a49fa5411aa98318a1a1313f3d993b1bceb54.tar.bz2
Do not increment refcount in rtnl_*_get_action APIs.
-rw-r--r--lib/route/cls/basic.c4
-rw-r--r--lib/route/cls/u32.c4
-rw-r--r--libnl-route-3.sym2
3 files changed, 3 insertions, 7 deletions
diff --git a/lib/route/cls/basic.c b/lib/route/cls/basic.c
index d330a19..912ded6 100644
--- a/lib/route/cls/basic.c
+++ b/lib/route/cls/basic.c
@@ -243,9 +243,7 @@ struct rtnl_act* rtnl_basic_get_action(struct rtnl_cls *cls)
if (!(b->b_mask & BASIC_ATTR_ACTION))
return NULL;
- struct rtnl_act* act = b->b_act;
- rtnl_act_get(act);
- return act;
+ return b->b_act;
}
int rtnl_basic_del_action(struct rtnl_cls *cls, struct rtnl_act *act)
diff --git a/lib/route/cls/u32.c b/lib/route/cls/u32.c
index a6047b4..087797e 100644
--- a/lib/route/cls/u32.c
+++ b/lib/route/cls/u32.c
@@ -570,9 +570,7 @@ struct rtnl_act* rtnl_u32_get_action(struct rtnl_cls *cls)
if (!(u->cu_mask & U32_ATTR_ACTION))
return NULL;
- struct rtnl_act* act = u->cu_act;
- rtnl_act_get(act);
- return act;
+ return u->cu_act;
}
int rtnl_u32_del_action(struct rtnl_cls *cls, struct rtnl_act *act)
diff --git a/libnl-route-3.sym b/libnl-route-3.sym
index 9edfec7..4d937ca 100644
--- a/libnl-route-3.sym
+++ b/libnl-route-3.sym
@@ -824,8 +824,8 @@ global:
rtnl_u32_add_key_uint16;
rtnl_u32_add_key_uint32;
rtnl_u32_add_key_uint8;
- rtnl_u32_get_action;
rtnl_u32_del_action;
+ rtnl_u32_get_action;
rtnl_u32_get_key;
rtnl_u32_set_classid;
rtnl_u32_set_cls_terminal;