diff options
| author | Brad King <brad.king@kitware.com> | 2017-04-06 19:54:09 (GMT) |
|---|---|---|
| committer | Kitware Robot <kwrobot@kitware.com> | 2017-04-06 19:54:23 (GMT) |
| commit | 2ec40c746fd1f6e5cdae5cd8d8123152c4eeb99b (patch) | |
| tree | fe8f13f65499239f3cee8eed6acc94b513928d28 | |
| parent | da9fe11b98ae9b176c1fbee8afb2cacddacf0c11 (diff) | |
| parent | 43381b4de7dcc7ac35532141a75f50951cc0603f (diff) | |
| download | CMake-2ec40c746fd1f6e5cdae5cd8d8123152c4eeb99b.zip CMake-2ec40c746fd1f6e5cdae5cd8d8123152c4eeb99b.tar.gz CMake-2ec40c746fd1f6e5cdae5cd8d8123152c4eeb99b.tar.bz2 | |
Merge topic 'doc-dev-review-comments'
43381b4d Help/dev: Document preferred page for MR comments
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !672
| -rw-r--r-- | Help/dev/review.rst | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Help/dev/review.rst b/Help/dev/review.rst index 3004a14..3db1f40 100644 --- a/Help/dev/review.rst +++ b/Help/dev/review.rst @@ -106,6 +106,10 @@ Human Review Anyone is welcome to review merge requests and make comments! +Please make comments directly on the MR page Discussion and Changes tabs +and not on individual commits. Comments on a commit may disappear +from the MR page if the commit is rewritten in response. + Reviewers may add comments providing feedback or to acknowledge their approval. Lines of specific forms will be extracted during the `merge`_ step and included as trailing lines of the generated merge commit message. |