diff options
author | Stephen Kelly <steveire@gmail.com> | 2015-07-18 12:32:09 (GMT) |
---|---|---|
committer | Stephen Kelly <steveire@gmail.com> | 2015-07-19 14:01:39 (GMT) |
commit | 41bb831fc910d85d79811dc367b25c0880cbe6ac (patch) | |
tree | d5283d326117a628ecefb50c669edf595f9c1a1e | |
parent | 881613c4abbbca35223678d6b17da418958a0005 (diff) | |
download | CMake-41bb831fc910d85d79811dc367b25c0880cbe6ac.zip CMake-41bb831fc910d85d79811dc367b25c0880cbe6ac.tar.gz CMake-41bb831fc910d85d79811dc367b25c0880cbe6ac.tar.bz2 |
cmMakefile: Remove special handling of MACROS property.
-rw-r--r-- | Source/cmGetCMakePropertyCommand.cxx | 5 | ||||
-rw-r--r-- | Source/cmMacroCommand.cxx | 2 | ||||
-rw-r--r-- | Source/cmMakefile.cxx | 17 | ||||
-rw-r--r-- | Source/cmMakefile.h | 13 |
4 files changed, 5 insertions, 32 deletions
diff --git a/Source/cmGetCMakePropertyCommand.cxx b/Source/cmGetCMakePropertyCommand.cxx index a460ca6..99e2867 100644 --- a/Source/cmGetCMakePropertyCommand.cxx +++ b/Source/cmGetCMakePropertyCommand.cxx @@ -41,7 +41,10 @@ bool cmGetCMakePropertyCommand else if ( args[1] == "MACROS" ) { output.clear(); - this->Makefile->GetListOfMacros(output); + if (const char* macrosProp = this->Makefile->GetProperty("MACROS")) + { + output = macrosProp; + } } else if ( args[1] == "COMPONENTS" ) { diff --git a/Source/cmMacroCommand.cxx b/Source/cmMacroCommand.cxx index 6d3054a..fa5a623 100644 --- a/Source/cmMacroCommand.cxx +++ b/Source/cmMacroCommand.cxx @@ -211,7 +211,7 @@ IsFunctionBlocked(const cmListFileFunction& lff, cmMakefile &mf, // if this is the endmacro for this macro then execute if (!this->Depth) { - mf.AddMacro(this->Args[0].c_str()); + mf.AppendProperty("MACROS", this->Args[0].c_str()); // create a new command and add it to cmake cmMacroHelperCommand *f = new cmMacroHelperCommand(); f->Args = this->Args; diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index 3c8a41d2..14ef934 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -3817,18 +3817,6 @@ cmVariableWatch *cmMakefile::GetVariableWatch() const } #endif -void cmMakefile::AddMacro(const char* name) -{ - assert(name); - this->MacrosList.push_back(name); -} - -void cmMakefile::GetListOfMacros(std::string& macros) const -{ - assert(macros.empty()); - macros = cmJoin(this->MacrosList, ";"); -} - cmState *cmMakefile::GetState() const { return this->GetCMakeInstance()->GetState(); @@ -4265,11 +4253,6 @@ const char *cmMakefile::GetProperty(const std::string& prop, output = cmJoin(this->GetDefinitions(), ";"); return output.c_str(); } - else if (prop == "MACROS") - { - this->GetListOfMacros(output); - return output.c_str(); - } else if (prop == "INCLUDE_DIRECTORIES") { std::string sep; diff --git a/Source/cmMakefile.h b/Source/cmMakefile.h index 98d199a..489a8b1 100644 --- a/Source/cmMakefile.h +++ b/Source/cmMakefile.h @@ -655,12 +655,6 @@ public: */ cmSourceFile *GetSourceFileWithOutput(const std::string& outName) const; - /** - * Add a macro to the list of macros. The arguments should be name of the - * macro and a documentation signature of it - */ - void AddMacro(const char* name); - ///! Add a new cmTest to the list of tests for this makefile. cmTest* CreateTest(const std::string& testName); @@ -670,11 +664,6 @@ public: cmTest* GetTest(const std::string& testName) const; /** - * Get a list of macros as a ; separated string - */ - void GetListOfMacros(std::string& macros) const; - - /** * Return a location of a file in cmake or custom modules directory */ std::string GetModulesFile(const char* name) const; @@ -909,8 +898,6 @@ private: std::stack<int> LoopBlockCounter; - std::vector<std::string> MacrosList; - mutable cmsys::RegularExpression cmDefineRegex; mutable cmsys::RegularExpression cmDefine01Regex; mutable cmsys::RegularExpression cmAtVarRegex; |