summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Kelly <steveire@gmail.com>2014-04-01 21:53:05 (GMT)
committerStephen Kelly <steveire@gmail.com>2014-04-03 19:53:13 (GMT)
commitff710539ab31ba4b6f3b376621dd9fbd56e1b558 (patch)
treeb48a73a41699fd1f8ef7b3926c7396d2562d49e4
parent5376151aa1d724b6d7ddef8d2e521d97cbfa74ae (diff)
downloadCMake-ff710539ab31ba4b6f3b376621dd9fbd56e1b558.zip
CMake-ff710539ab31ba4b6f3b376621dd9fbd56e1b558.tar.gz
CMake-ff710539ab31ba4b6f3b376621dd9fbd56e1b558.tar.bz2
Remove default labels from fully covered switch statements.
Allow compilers to warn when new enum values are added, making switches no-longer fully-covered.
-rw-r--r--Source/cmCTest.cxx2
-rw-r--r--Source/cmLocalGenerator.cxx1
-rw-r--r--Source/cmMakefile.cxx1
-rw-r--r--Source/cmNewLineStyle.cxx2
-rw-r--r--Source/cmTargetLinkLibrariesCommand.cxx1
5 files changed, 0 insertions, 7 deletions
diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index 9f711b7..d797d3b 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -217,8 +217,6 @@ int cmCTest::HTTPRequest(std::string url, HTTPMethod method,
url += "?" + fields;
}
break;
- default:
- break;
}
::curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx
index dcf9f97..1e65a02 100644
--- a/Source/cmLocalGenerator.cxx
+++ b/Source/cmLocalGenerator.cxx
@@ -2283,7 +2283,6 @@ bool cmLocalGenerator::GetShouldUseOldFlags(bool shared,
case cmPolicies::REQUIRED_IF_USED:
case cmPolicies::REQUIRED_ALWAYS:
case cmPolicies::NEW:
- default:
return false;
}
}
diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx
index b1d6fe2..1328974 100644
--- a/Source/cmMakefile.cxx
+++ b/Source/cmMakefile.cxx
@@ -3365,7 +3365,6 @@ std::string cmMakefile::GetModulesFile(const char* filename) const
case cmPolicies::REQUIRED_IF_USED:
case cmPolicies::REQUIRED_ALWAYS:
case cmPolicies::NEW:
- default:
result = moduleInCMakeRoot;
break;
}
diff --git a/Source/cmNewLineStyle.cxx b/Source/cmNewLineStyle.cxx
index a7d7429..08f0b5b 100644
--- a/Source/cmNewLineStyle.cxx
+++ b/Source/cmNewLineStyle.cxx
@@ -76,8 +76,6 @@ const std::string cmNewLineStyle::GetCharacters() const
return "\n";
case CRLF:
return "\r\n";
- default:
- ;
}
return "";
}
diff --git a/Source/cmTargetLinkLibrariesCommand.cxx b/Source/cmTargetLinkLibrariesCommand.cxx
index 1c2e625..56e1338 100644
--- a/Source/cmTargetLinkLibrariesCommand.cxx
+++ b/Source/cmTargetLinkLibrariesCommand.cxx
@@ -70,7 +70,6 @@ bool cmTargetLinkLibrariesCommand
GetRequiredPolicyError(cmPolicies::CMP0016);
break;
case cmPolicies::NEW: // NEW behavior prints the error.
- default:
break;
}
}