summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2019-09-09 17:40:08 (GMT)
committerBrad King <brad.king@kitware.com>2019-09-09 17:51:23 (GMT)
commitf1f57cffc73cbb518d9559308f3d36a655e5738d (patch)
tree82accc9791cced7cb1abb82cffa01869bea67884
parent175d8c4bf6505eeb02bb588527f3ff7b5eb143b9 (diff)
downloadCMake-f1f57cffc73cbb518d9559308f3d36a655e5738d.zip
CMake-f1f57cffc73cbb518d9559308f3d36a655e5738d.tar.gz
CMake-f1f57cffc73cbb518d9559308f3d36a655e5738d.tar.bz2
clang-tidy: Fix performance-for-range-copy diagnostic in Xcode generator
Fix diagnostics that appear on macOS with clang-tidy-8.
-rw-r--r--Source/cmGlobalXCodeGenerator.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx
index 502a642..3dae824 100644
--- a/Source/cmGlobalXCodeGenerator.cxx
+++ b/Source/cmGlobalXCodeGenerator.cxx
@@ -1254,7 +1254,7 @@ bool cmGlobalXCodeGenerator::CreateXCodeTarget(
bundleFiles[tsFlags.MacFolder].push_back(sourceFile);
}
}
- for (auto keySources : bundleFiles) {
+ for (auto const& keySources : bundleFiles) {
cmXCodeObject* copyFilesBuildPhase =
this->CreateObject(cmXCodeObject::PBXCopyFilesBuildPhase);
copyFilesBuildPhase->SetComment("Copy files");
@@ -1302,7 +1302,7 @@ bool cmGlobalXCodeGenerator::CreateXCodeTarget(
bundleFiles[tsFlags.MacFolder].push_back(sourceFile);
}
}
- for (auto keySources : bundleFiles) {
+ for (auto const& keySources : bundleFiles) {
cmXCodeObject* copyFilesBuildPhase =
this->CreateObject(cmXCodeObject::PBXCopyFilesBuildPhase);
copyFilesBuildPhase->SetComment("Copy files");