diff options
| author | Brad King <brad.king@kitware.com> | 2018-05-15 13:54:01 (GMT) |
|---|---|---|
| committer | Kitware Robot <kwrobot@kitware.com> | 2018-05-15 13:54:08 (GMT) |
| commit | c29992078f2d8683228030f847948a902ac9173b (patch) | |
| tree | 3c9d9f941c541ae2cb0169ee9a180ab0de607600 | |
| parent | d793b482d914e0d8706b901dceeb1b5f0c405413 (diff) | |
| parent | 6e594916592e5f8f17b387546d79e484ac092b9e (diff) | |
| download | CMake-c29992078f2d8683228030f847948a902ac9173b.zip CMake-c29992078f2d8683228030f847948a902ac9173b.tar.gz CMake-c29992078f2d8683228030f847948a902ac9173b.tar.bz2 | |
Merge topic 'custom-command-expand-empty'
6e59491659 add_custom_{command,target}: Fix crash on empty expanded command
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2074
| -rw-r--r-- | Source/cmCustomCommandGenerator.cxx | 8 | ||||
| -rw-r--r-- | Tests/RunCMake/add_custom_target/CommandExpandsEmpty.cmake | 1 | ||||
| -rw-r--r-- | Tests/RunCMake/add_custom_target/RunCMakeTest.cmake | 1 |
3 files changed, 10 insertions, 0 deletions
diff --git a/Source/cmCustomCommandGenerator.cxx b/Source/cmCustomCommandGenerator.cxx index 136cf39..6c9f9d6 100644 --- a/Source/cmCustomCommandGenerator.cxx +++ b/Source/cmCustomCommandGenerator.cxx @@ -40,6 +40,14 @@ cmCustomCommandGenerator::cmCustomCommandGenerator(cmCustomCommand const& cc, argv.push_back(std::move(parsed_arg)); } } + + // Later code assumes at least one entry exists, but expanding + // lists on an empty command may have left this empty. + // FIXME: Should we define behavior for removing empty commands? + if (argv.empty()) { + argv.push_back(std::string()); + } + this->CommandLines.push_back(std::move(argv)); } diff --git a/Tests/RunCMake/add_custom_target/CommandExpandsEmpty.cmake b/Tests/RunCMake/add_custom_target/CommandExpandsEmpty.cmake new file mode 100644 index 0000000..bc899a4 --- /dev/null +++ b/Tests/RunCMake/add_custom_target/CommandExpandsEmpty.cmake @@ -0,0 +1 @@ +add_custom_target(EmptyCustom COMMAND "" COMMAND_EXPAND_LISTS) diff --git a/Tests/RunCMake/add_custom_target/RunCMakeTest.cmake b/Tests/RunCMake/add_custom_target/RunCMakeTest.cmake index 6c4e91b..2caed03 100644 --- a/Tests/RunCMake/add_custom_target/RunCMakeTest.cmake +++ b/Tests/RunCMake/add_custom_target/RunCMakeTest.cmake @@ -1,5 +1,6 @@ include(RunCMake) +run_cmake(CommandExpandsEmpty) run_cmake(NoArguments) run_cmake(BadTargetName) run_cmake(ByproductsNoCommand) |