diff options
author | Brad King <brad.king@kitware.com> | 2023-10-10 13:58:32 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2023-10-11 13:52:41 (GMT) |
commit | 32438138c331bc0bc24b47c9ac0cc93c8298c8d5 (patch) | |
tree | cd6f3c90d73e1524d1686e4ebf4e8cba583f9ba9 | |
parent | 604466b83e0c54640c15d00909cbdbe747a47965 (diff) | |
download | CMake-32438138c331bc0bc24b47c9ac0cc93c8298c8d5.zip CMake-32438138c331bc0bc24b47c9ac0cc93c8298c8d5.tar.gz CMake-32438138c331bc0bc24b47c9ac0cc93c8298c8d5.tar.bz2 |
cxxmodules: Reference documentation in no-modules-support diagnostics
Help users avoid errors about module support when they may not need it.
While at it, polish sentence syntax in the diagnostic messages.
-rw-r--r-- | Source/cmGeneratorTarget.cxx | 20 | ||||
-rw-r--r-- | Tests/RunCMake/CXXModules/CMP0155-NEW-stderr.txt | 11 | ||||
-rw-r--r-- | Tests/RunCMake/CXXModules/NoCXX-stderr.txt | 9 | ||||
-rw-r--r-- | Tests/RunCMake/CXXModules/NoCXX20-stderr.txt | 9 | ||||
-rw-r--r-- | Tests/RunCMake/CXXModules/NoDyndepSupport-stderr.txt | 5 | ||||
-rw-r--r-- | Tests/RunCMake/CXXModules/NoScanningSourceFileProperty-stderr.txt | 12 | ||||
-rw-r--r-- | Tests/RunCMake/CXXModules/NoScanningTargetProperty-stderr.txt | 12 |
7 files changed, 45 insertions, 33 deletions
diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx index 01af14f..2ea18bd 100644 --- a/Source/cmGeneratorTarget.cxx +++ b/Source/cmGeneratorTarget.cxx @@ -9195,8 +9195,9 @@ void cmGeneratorTarget::CheckCxxModuleStatus(std::string const& config) const MessageType::FATAL_ERROR, cmStrCat( "The target named \"", this->GetName(), - "\" contains C++ " - "sources that use modules which is not supported by the generator")); + "\" has C++ sources that may use modules, but modules are not " + "supported by this generator. See the cmake-cxxmodules(7) manual " + "and the CMAKE_CXX_SCAN_FOR_MODULES variable.")); return; } @@ -9205,8 +9206,8 @@ void cmGeneratorTarget::CheckCxxModuleStatus(std::string const& config) const this->Makefile->IssueMessage( MessageType::FATAL_ERROR, cmStrCat("The target named \"", this->GetName(), - "\" has C++ sources that use modules but the \"CXX\" " - "language has not been enabled")); + "\" has C++ sources that use modules, but the \"CXX\" " + "language has not been enabled.")); break; case cmGeneratorTarget::Cxx20SupportLevel::NoCxx20: { cmStandardLevelResolver standardResolver(this->Makefile); @@ -9221,17 +9222,18 @@ void cmGeneratorTarget::CheckCxxModuleStatus(std::string const& config) const MessageType::FATAL_ERROR, cmStrCat( "The target named \"", this->GetName(), - "\" has C++ sources that use modules but does not include " + "\" has C++ sources that use modules, but does not include " "\"cxx_std_20\" (or newer) among its `target_compile_features`", - effStandard)); + effStandard, '.')); } break; case cmGeneratorTarget::Cxx20SupportLevel::MissingRule: { this->Makefile->IssueMessage( MessageType::FATAL_ERROR, cmStrCat("The target named \"", this->GetName(), - "\" has C++ sources that use modules but the compiler does " - "not provide a way to discover the import graph " - "dependencies")); + "\" has C++ sources that may use modules, but the compiler " + "does not provide a way to discover the import graph " + "dependencies. See the cmake-cxxmodules(7) manual " + "and the CMAKE_CXX_SCAN_FOR_MODULES variable.")); } break; case cmGeneratorTarget::Cxx20SupportLevel::Supported: // All is well. diff --git a/Tests/RunCMake/CXXModules/CMP0155-NEW-stderr.txt b/Tests/RunCMake/CXXModules/CMP0155-NEW-stderr.txt index d103201..0843d0b 100644 --- a/Tests/RunCMake/CXXModules/CMP0155-NEW-stderr.txt +++ b/Tests/RunCMake/CXXModules/CMP0155-NEW-stderr.txt @@ -1,7 +1,10 @@ (CMake Error in CMakeLists.txt: - The target named "cmp0155-new" has C\+\+ sources that use modules but the - compiler does not provide a way to discover the import graph dependencies + The target named "cmp0155-new" has C\+\+ sources that may use modules, but + the compiler does not provide a way to discover the import graph + dependencies\. See the cmake-cxxmodules\(7\) manual and the + CMAKE_CXX_SCAN_FOR_MODULES variable\. |CMake Error in CMakeLists.txt: - The target named "cmp0155-new" contains C\+\+ sources that use modules which - is not supported by the generator + The target named "cmp0155-new" has C\+\+ sources that may use modules, but + modules are not supported by this generator\. See the cmake-cxxmodules\(7\) + manual and the CMAKE_CXX_SCAN_FOR_MODULES variable\. ) diff --git a/Tests/RunCMake/CXXModules/NoCXX-stderr.txt b/Tests/RunCMake/CXXModules/NoCXX-stderr.txt index accc622..ba2715b 100644 --- a/Tests/RunCMake/CXXModules/NoCXX-stderr.txt +++ b/Tests/RunCMake/CXXModules/NoCXX-stderr.txt @@ -1,9 +1,10 @@ (CMake Error in CMakeLists.txt: - The target named "nocxx" has C\+\+ sources that use modules but the "CXX" - language has not been enabled + The target named "nocxx" has C\+\+ sources that use modules, but the "CXX" + language has not been enabled\. |CMake Error in CMakeLists.txt: - The target named "nocxx" contains C\+\+ sources that use modules which is not - supported by the generator + The target named "nocxx" has C\+\+ sources that may use modules, but modules + are not supported by this generator\. See the cmake-cxxmodules\(7\) manual + and the CMAKE_CXX_SCAN_FOR_MODULES variable\. |CMake Error in CMakeLists.txt: Target "nocxx" has source file diff --git a/Tests/RunCMake/CXXModules/NoCXX20-stderr.txt b/Tests/RunCMake/CXXModules/NoCXX20-stderr.txt index c83e26d..3f3a547 100644 --- a/Tests/RunCMake/CXXModules/NoCXX20-stderr.txt +++ b/Tests/RunCMake/CXXModules/NoCXX20-stderr.txt @@ -1,8 +1,9 @@ (CMake Error in CMakeLists.txt: - The target named "nocxx20" has C\+\+ sources that use modules but does not + The target named "nocxx20" has C\+\+ sources that use modules, but does not include "cxx_std_20" \(or newer\) among its `target_compile_features`; found - "cxx_std_17" + "cxx_std_17"\. |CMake Error in CMakeLists.txt: - The target named "nocxx20" contains C\+\+ sources that use modules which is - not supported by the generator + The target named "nocxx20" has C\+\+ sources that may use modules, but + modules are not supported by this generator\. See the cmake-cxxmodules\(7\) + manual and the CMAKE_CXX_SCAN_FOR_MODULES variable\. ) diff --git a/Tests/RunCMake/CXXModules/NoDyndepSupport-stderr.txt b/Tests/RunCMake/CXXModules/NoDyndepSupport-stderr.txt index 0ba2dde..c7e2979 100644 --- a/Tests/RunCMake/CXXModules/NoDyndepSupport-stderr.txt +++ b/Tests/RunCMake/CXXModules/NoDyndepSupport-stderr.txt @@ -6,6 +6,7 @@ due to lack of required features\. Ninja 1\.11 or higher is required\. |CMake Error in CMakeLists.txt: - The target named "nodyndep" contains C\+\+ sources that use modules which is - not supported by the generator + The target named "nodyndep" has C\+\+ sources that may use modules, but + modules are not supported by this generator\. See the cmake-cxxmodules\(7\) + manual and the CMAKE_CXX_SCAN_FOR_MODULES variable\. ) diff --git a/Tests/RunCMake/CXXModules/NoScanningSourceFileProperty-stderr.txt b/Tests/RunCMake/CXXModules/NoScanningSourceFileProperty-stderr.txt index d3edb21..ed78672 100644 --- a/Tests/RunCMake/CXXModules/NoScanningSourceFileProperty-stderr.txt +++ b/Tests/RunCMake/CXXModules/NoScanningSourceFileProperty-stderr.txt @@ -1,8 +1,10 @@ (CMake Error in CMakeLists.txt: - The target named "noscanning-sf-property" has C\+\+ sources that use modules - but the compiler does not provide a way to discover the import graph - dependencies + The target named "noscanning-sf-property" has C\+\+ sources that may use + modules, but the compiler does not provide a way to discover the import + graph dependencies\. See the cmake-cxxmodules\(7\) manual and the + CMAKE_CXX_SCAN_FOR_MODULES variable\. |CMake Error in CMakeLists.txt: - The target named "noscanning-sf-property" contains C\+\+ sources that use - modules which is not supported by the generator + The target named "noscanning-sf-property" has C\+\+ sources that may use + modules, but modules are not supported by this generator\. See the + cmake-cxxmodules\(7\) manual and the CMAKE_CXX_SCAN_FOR_MODULES variable\. ) diff --git a/Tests/RunCMake/CXXModules/NoScanningTargetProperty-stderr.txt b/Tests/RunCMake/CXXModules/NoScanningTargetProperty-stderr.txt index a18b98b..9dfb3e9 100644 --- a/Tests/RunCMake/CXXModules/NoScanningTargetProperty-stderr.txt +++ b/Tests/RunCMake/CXXModules/NoScanningTargetProperty-stderr.txt @@ -1,8 +1,10 @@ (CMake Error in CMakeLists.txt: - The target named "noscanning-target-property" has C\+\+ sources that use - modules but the compiler does not provide a way to discover the import - graph dependencies + The target named "noscanning-target-property" has C\+\+ sources that may use + modules, but the compiler does not provide a way to discover the import + graph dependencies\. See the cmake-cxxmodules\(7\) manual and the + CMAKE_CXX_SCAN_FOR_MODULES variable\. |CMake Error in CMakeLists.txt: - The target named "noscanning-target-property" contains C\+\+ sources that use - modules which is not supported by the generator + The target named "noscanning-target-property" has C\+\+ sources that may use + modules, but modules are not supported by this generator\. See the + cmake-cxxmodules\(7\) manual and the CMAKE_CXX_SCAN_FOR_MODULES variable\. ) |