summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKyle Edwards <kyle.edwards@kitware.com>2023-10-27 13:43:18 (GMT)
committerKyle Edwards <kyle.edwards@kitware.com>2023-10-27 13:43:18 (GMT)
commitd3cc815c989a8f1ddaf8639dc80b9f12350a87c7 (patch)
tree42c2787faa3d9f4c05fc03fb9d370b14142274a7
parent8313d261984a372078576296385c349cac2168c5 (diff)
downloadCMake-d3cc815c989a8f1ddaf8639dc80b9f12350a87c7.zip
CMake-d3cc815c989a8f1ddaf8639dc80b9f12350a87c7.tar.gz
CMake-d3cc815c989a8f1ddaf8639dc80b9f12350a87c7.tar.bz2
CMP0153: Add suggestion to use execute_process()
-rw-r--r--Source/cmCommands.cxx8
-rw-r--r--Tests/RunCMake/CMP0153/CMP0153-NEW-stderr.txt3
-rw-r--r--Tests/RunCMake/CMP0153/CMP0153-WARN-stderr.txt2
3 files changed, 9 insertions, 4 deletions
diff --git a/Source/cmCommands.cxx b/Source/cmCommands.cxx
index 2ee4f47..91f7691 100644
--- a/Source/cmCommands.cxx
+++ b/Source/cmCommands.cxx
@@ -219,9 +219,11 @@ void GetScriptingCommands(cmState* state)
state->AddDisallowedCommand(
"use_mangled_mesa", cmUseMangledMesaCommand, cmPolicies::CMP0030,
"The use_mangled_mesa command should not be called; see CMP0030.");
- state->AddDisallowedCommand(
- "exec_program", cmExecProgramCommand, cmPolicies::CMP0153,
- "The exec_program command should not be called; see CMP0153.");
+ state->AddDisallowedCommand("exec_program", cmExecProgramCommand,
+ cmPolicies::CMP0153,
+ "The exec_program command should not be called; "
+ "see CMP0153. Use execute_process() instead.",
+ "Use execute_process() instead.");
#endif
}
diff --git a/Tests/RunCMake/CMP0153/CMP0153-NEW-stderr.txt b/Tests/RunCMake/CMP0153/CMP0153-NEW-stderr.txt
index e24eee7..2b0a661 100644
--- a/Tests/RunCMake/CMP0153/CMP0153-NEW-stderr.txt
+++ b/Tests/RunCMake/CMP0153/CMP0153-NEW-stderr.txt
@@ -1,3 +1,4 @@
^CMake Error at [^
]*/Tests/RunCMake/CMP0153/CMP0153-NEW\.cmake:[0-9]+ \(exec_program\):
- The exec_program command should not be called; see CMP0153\.$
+ The exec_program command should not be called; see CMP0153\. Use
+ execute_process\(\) instead\.$
diff --git a/Tests/RunCMake/CMP0153/CMP0153-WARN-stderr.txt b/Tests/RunCMake/CMP0153/CMP0153-WARN-stderr.txt
index 8f22d4e..d0b9422 100644
--- a/Tests/RunCMake/CMP0153/CMP0153-WARN-stderr.txt
+++ b/Tests/RunCMake/CMP0153/CMP0153-WARN-stderr.txt
@@ -3,4 +3,6 @@
Policy CMP0153 is not set: The exec_program command should not be called\.
Run "cmake --help-policy CMP0153" for policy details\. Use the cmake_policy
command to set the policy and suppress this warning\.
+
+ Use execute_process\(\) instead\.
This warning is for project developers\. Use -Wno-dev to suppress it\.$