summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2020-03-23 13:27:36 (GMT)
committerKitware Robot <kwrobot@kitware.com>2020-03-23 13:27:43 (GMT)
commit170087f0652a2f3717098470168501352295543a (patch)
tree902454d6089765e46eb6d1ddcbd4bafb1d618390
parente3185e3d1b92a95c18f22f70b3cef6944dd019eb (diff)
parentecc0086bfc754f5adc4e496ae025da4bb1796490 (diff)
downloadCMake-170087f0652a2f3717098470168501352295543a.zip
CMake-170087f0652a2f3717098470168501352295543a.tar.gz
CMake-170087f0652a2f3717098470168501352295543a.tar.bz2
Merge topic 'cmake-gui-open-check' into release-3.17
ecc0086bfc cmake-gui: Fix use-after-free in Open-possible check Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4508
-rw-r--r--Source/QtDialog/QCMake.cxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/QtDialog/QCMake.cxx b/Source/QtDialog/QCMake.cxx
index 3b5dc04..a9089e5 100644
--- a/Source/QtDialog/QCMake.cxx
+++ b/Source/QtDialog/QCMake.cxx
@@ -486,7 +486,7 @@ void QCMake::setWarnUnusedMode(bool value)
void QCMake::checkOpenPossible()
{
- auto data = this->BinaryDirectory.toLocal8Bit().data();
+ std::string data = this->BinaryDirectory.toLocal8Bit().data();
auto possible = this->CMakeInstance->Open(data, true);
emit openPossible(possible);
}