summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNAKAMURA Takumi <geek4civic@gmail.com>2021-11-14 07:55:38 (GMT)
committerBrad King <brad.king@kitware.com>2021-11-18 17:02:37 (GMT)
commit68b4e3b255be7a8d0831d19b206f701efdb001c8 (patch)
tree7fbcca342b992c0d33fac647f1c8cca1aeedadbb
parente37511ae7eb68a46fb9edb9f00d3fc179f713e45 (diff)
downloadCMake-68b4e3b255be7a8d0831d19b206f701efdb001c8.zip
CMake-68b4e3b255be7a8d0831d19b206f701efdb001c8.tar.gz
CMake-68b4e3b255be7a8d0831d19b206f701efdb001c8.tar.bz2
cmGlobalVisualStudio8Generator: Fix the misaligned argument, stdPipesUTF8
The call to AddCustomCommandToTarget for "Checking File Globs" had misaligned arguments and previously passed `stdPipesUTF8` as `escapeOldStyle`. For now, set `escapeOldStyle` as `true`. Also `stdPipesUTF8` is `true` here.
-rw-r--r--Source/cmGlobalVisualStudio8Generator.cxx16
1 files changed, 11 insertions, 5 deletions
diff --git a/Source/cmGlobalVisualStudio8Generator.cxx b/Source/cmGlobalVisualStudio8Generator.cxx
index 1e45813..c4da8c3 100644
--- a/Source/cmGlobalVisualStudio8Generator.cxx
+++ b/Source/cmGlobalVisualStudio8Generator.cxx
@@ -203,11 +203,17 @@ bool cmGlobalVisualStudio8Generator::AddCheckTarget()
std::vector<std::string> byproducts;
byproducts.push_back(cm->GetGlobVerifyStamp());
- lg.AddCustomCommandToTarget(CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts,
- no_depends, verifyCommandLines,
- cmCustomCommandType::PRE_BUILD,
- "Checking File Globs", no_working_directory,
- cmPolicies::NEW, stdPipesUTF8);
+ lg.AddCustomCommandToTarget(
+ CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts, no_depends,
+ verifyCommandLines, cmCustomCommandType::PRE_BUILD,
+ "Checking File Globs", no_working_directory, cmPolicies::NEW,
+ /*escapeOldStyle=*/true,
+ /*uses_terminal=*/false,
+ /*depfile=*/"",
+ /*job_pool=*/"",
+ /*command_expand_lists=*/false,
+ /*objLibCommands=*/cmObjectLibraryCommands::Reject,
+ /*stdPipesUTF8=*/stdPipesUTF8);
// Ensure ZERO_CHECK always runs in Visual Studio using MSBuild,
// otherwise the prebuild command will not be run.