diff options
author | Brad King <brad.king@kitware.com> | 2024-03-13 14:50:52 (GMT) |
---|---|---|
committer | Kitware Robot <kwrobot@kitware.com> | 2024-03-13 14:51:11 (GMT) |
commit | be27ce8feabad2ecc69996e6525cca6cbae3960b (patch) | |
tree | dc570bb9dcc5637fb25ee4441503de9bd8c24d23 | |
parent | 3677b2d916fb8d3ba5ff4eac0115f905b9727f9d (diff) | |
parent | 682767e8a5028fe930913d3144d9182797fd4331 (diff) | |
download | CMake-be27ce8feabad2ecc69996e6525cca6cbae3960b.zip CMake-be27ce8feabad2ecc69996e6525cca6cbae3960b.tar.gz CMake-be27ce8feabad2ecc69996e6525cca6cbae3960b.tar.bz2 |
Merge topic 'ci-xcode-15.3' into release-3.29
682767e8a5 Merge branch 'backport-3.28-ci-xcode-15.3'
e572986231 LinkerId: Update detection of linker tool for Xcode 15.3
8a6d05aa9d gitlab-ci: update macOS jobs to use Xcode 15.3
7bf893bc30 Tests: Update RunCMake.CheckCompilerFlag for Xcode 15.3
7f5f0ab4b3 Tests: Update RunCMake.CompileFeatures for Xcode 15.3
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9333
-rw-r--r-- | .gitlab/os-macos.yml | 12 | ||||
-rw-r--r-- | Modules/CMakeParseImplicitLinkInfo.cmake | 2 | ||||
-rw-r--r-- | Tests/RunCMake/CheckCompilerFlag/CheckCompilerFlagSwift.cmake | 4 | ||||
-rw-r--r-- | Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake | 2 | ||||
-rw-r--r-- | Tests/RunCMake/CompileFeatures/compiler_introspection.cmake | 7 |
5 files changed, 17 insertions, 10 deletions
diff --git a/.gitlab/os-macos.yml b/.gitlab/os-macos.yml index 81e9ce2..23c68d5 100644 --- a/.gitlab/os-macos.yml +++ b/.gitlab/os-macos.yml @@ -7,7 +7,7 @@ GIT_CLONE_PATH: "$CI_BUILDS_DIR/cmake ci ext/$CI_CONCURRENT_ID" # TODO: Factor this out so that each job selects the Xcode version to # use so that different versions can be tested in a single pipeline. - DEVELOPER_DIR: "/Applications/Xcode-15.2.app/Contents/Developer" + DEVELOPER_DIR: "/Applications/Xcode-15.3.app/Contents/Developer" # Avoid conflicting with other projects running on the same machine. SCCACHE_SERVER_PORT: 4227 @@ -135,7 +135,7 @@ - cmake # Since this is a bare runner, pin to a project. - macos-x86_64 - shell - - xcode-15.2 + - xcode-15.3 - nonconcurrent .macos_x86_64_tags_ext: @@ -143,7 +143,7 @@ - cmake # Since this is a bare runner, pin to a project. - macos-x86_64 - shell - - xcode-15.2 + - xcode-15.3 - concurrent .macos_arm64_tags: @@ -151,7 +151,7 @@ - cmake # Since this is a bare runner, pin to a project. - macos-arm64 - shell - - xcode-15.2 + - xcode-15.3 - nonconcurrent .macos_arm64_tags_ext: @@ -159,7 +159,7 @@ - cmake # Since this is a bare runner, pin to a project. - macos-arm64 - shell - - xcode-15.2 + - xcode-15.3 - concurrent .macos_arm64_tags_package: @@ -167,7 +167,7 @@ - cmake # Since this is a bare runner, pin to a project. - macos-arm64 - shell - - xcode-15.2 + - xcode-15.3 - nonconcurrent - finder diff --git a/Modules/CMakeParseImplicitLinkInfo.cmake b/Modules/CMakeParseImplicitLinkInfo.cmake index 896eac0..dc09b20 100644 --- a/Modules/CMakeParseImplicitLinkInfo.cmake +++ b/Modules/CMakeParseImplicitLinkInfo.cmake @@ -75,7 +75,7 @@ function(cmake_parse_implicit_link_info2 text log_var obj_regex) set(linker_regex "^( *|.*[/\\])(${linker}|${startfile}|([^/\\]+-)?ld|collect2)[^/\\]*( |$)") set(linker_exclude_regex "collect2 version |^[A-Za-z0-9_]+=|/ldfe ") set(linker_tool_regex "^[ \t]*(->|\")?[ \t]*(([^\"]*[/\\])?(${linker}))(\"|,| |$)") - set(linker_tool_exclude_regex "cuda-fake-ld|-fuse-ld=") + set(linker_tool_exclude_regex "cuda-fake-ld|-fuse-ld=|^ExecuteExternalTool ") set(linker_tool "NOTFOUND") set(linker_tool_fallback "") set(link_line_parsed 0) diff --git a/Tests/RunCMake/CheckCompilerFlag/CheckCompilerFlagSwift.cmake b/Tests/RunCMake/CheckCompilerFlag/CheckCompilerFlagSwift.cmake index c85783d..97e9b24 100644 --- a/Tests/RunCMake/CheckCompilerFlag/CheckCompilerFlagSwift.cmake +++ b/Tests/RunCMake/CheckCompilerFlag/CheckCompilerFlagSwift.cmake @@ -13,9 +13,9 @@ if(SHOULD_FAIL) message(SEND_ERROR "invalid Swift compile flag didn't fail.") endif() -check_compiler_flag(Swift "-parseable-output" SHOULD_WORK) +check_compiler_flag(Swift "-Onone" SHOULD_WORK) if(NOT SHOULD_WORK) - message(SEND_ERROR "Swift compiler flag '-parseable-output' check failed") + message(SEND_ERROR "Swift compiler flag '-Onone' check failed") endif() # Reset locale diff --git a/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake b/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake index 7b72ffe..731a303 100644 --- a/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake +++ b/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake @@ -62,7 +62,7 @@ macro(mangle_flags variable) if(RunCMake_GENERATOR MATCHES "Visual Studio" AND MSVC_TOOLSET_VERSION GREATER_EQUAL 141) string(REPLACE "-" "/" result "${result}") - elseif(RunCMake_GENERATOR STREQUAL "Xcode" AND CMAKE_XCODE_BUILD_SYSTEM GREATER_EQUAL 12) + elseif(RunCMake_GENERATOR STREQUAL "Xcode" AND XCODE_VERSION VERSION_LESS 15.3 AND CMAKE_XCODE_BUILD_SYSTEM GREATER_EQUAL 12) string(REPLACE "=" [[\\=]] result "${result}") endif() diff --git a/Tests/RunCMake/CompileFeatures/compiler_introspection.cmake b/Tests/RunCMake/CompileFeatures/compiler_introspection.cmake index 5691344..f3360c7 100644 --- a/Tests/RunCMake/CompileFeatures/compiler_introspection.cmake +++ b/Tests/RunCMake/CompileFeatures/compiler_introspection.cmake @@ -16,6 +16,13 @@ set(CMAKE_XCODE_BUILD_SYSTEM ${CMAKE_XCODE_BUILD_SYSTEM}) ") endif() +if(XCODE_VERSION) + string(APPEND info " +set(XCODE_VERSION ${XCODE_VERSION}) + +") +endif() + macro(info lang) string(APPEND info "\ set(${lang}_STANDARD_DEFAULT ${CMAKE_${lang}_STANDARD_DEFAULT}) |