diff options
| author | Ben Boeckel <ben.boeckel@kitware.com> | 2023-10-20 02:06:23 (GMT) |
|---|---|---|
| committer | Ben Boeckel <ben.boeckel@kitware.com> | 2023-10-20 03:00:17 (GMT) |
| commit | c2e949b700318b1632eed99b6343abc4c3bc658a (patch) | |
| tree | 28f084b4587561a9502823e4512505716d1107f6 | |
| parent | 1cfba13004c0f2cba512c78c64f160e221ca85ae (diff) | |
| download | CMake-c2e949b700318b1632eed99b6343abc4c3bc658a.zip CMake-c2e949b700318b1632eed99b6343abc4c3bc658a.tar.gz CMake-c2e949b700318b1632eed99b6343abc4c3bc658a.tar.bz2 | |
cmGlobalNinjaGenerator: remove unnecessary virtual method
The implementation is the same and the called method used internally is
`virtual`, so just make the call non-virtual.
| -rw-r--r-- | Source/cmGlobalNinjaGenerator.cxx | 7 | ||||
| -rw-r--r-- | Source/cmGlobalNinjaGenerator.h | 5 |
2 files changed, 1 insertions, 11 deletions
diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx index 949e84f..4cf9dff 100644 --- a/Source/cmGlobalNinjaGenerator.cxx +++ b/Source/cmGlobalNinjaGenerator.cxx @@ -3183,10 +3183,3 @@ std::string cmGlobalNinjaMultiGenerator::OrderDependsTargetForTarget( return cmStrCat("cmake_object_order_depends_target_", target->GetName(), '_', cmSystemTools::UpperCase(config)); } - -std::string cmGlobalNinjaMultiGenerator::OrderDependsTargetForTargetPrivate( - cmGeneratorTarget const* target, const std::string& config) const -{ - return cmStrCat(this->OrderDependsTargetForTarget(target, config), - "_private"); -} diff --git a/Source/cmGlobalNinjaGenerator.h b/Source/cmGlobalNinjaGenerator.h index 56a922c..d731b16 100644 --- a/Source/cmGlobalNinjaGenerator.h +++ b/Source/cmGlobalNinjaGenerator.h @@ -349,7 +349,7 @@ public: virtual std::string OrderDependsTargetForTarget( cmGeneratorTarget const* target, const std::string& config) const; - virtual std::string OrderDependsTargetForTargetPrivate( + std::string OrderDependsTargetForTargetPrivate( cmGeneratorTarget const* target, const std::string& config) const; void AppendTargetOutputs(cmGeneratorTarget const* target, @@ -741,9 +741,6 @@ public: std::string OrderDependsTargetForTarget( cmGeneratorTarget const* target, const std::string& config) const override; - std::string OrderDependsTargetForTargetPrivate( - cmGeneratorTarget const* target, const std::string& config) const override; - protected: bool OpenBuildFileStreams() override; void CloseBuildFileStreams() override; |