diff options
| author | Orkun Tokdemir <ilhanorkuntokdemir@gmail.com> | 2024-02-08 12:48:57 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2024-02-09 14:10:41 (GMT) |
| commit | 9e87df4d468fb8d3a835cbdfeca30fee9586e00d (patch) | |
| tree | 47cbf7686661af362b30c39673a4f6cfc37f66c1 | |
| parent | c673511263822c688fa302120a29e1e0cf812c0b (diff) | |
| download | CMake-9e87df4d468fb8d3a835cbdfeca30fee9586e00d.zip CMake-9e87df4d468fb8d3a835cbdfeca30fee9586e00d.tar.gz CMake-9e87df4d468fb8d3a835cbdfeca30fee9586e00d.tar.bz2 | |
Autogen/RCC: Disable zstd if it is not supported
Add the `--no-zstd` argument for `RCC` when `QT_FEATURE_zstd` is `OFF`.
This causes user project builds to fail. That bug is fixed in Qt
by https://codereview.qt-project.org/c/qt/qtbase/+/537546 but for
the older versions, fix it here too.
Fixes: #25664
| -rw-r--r-- | Source/cmQtAutoGenInitializer.cxx | 21 | ||||
| -rw-r--r-- | Tests/RunCMake/Autogen/RccExample.cmake | 4 | ||||
| -rw-r--r-- | Tests/RunCMake/Autogen/RunCMakeTest.cmake | 21 |
3 files changed, 46 insertions, 0 deletions
diff --git a/Source/cmQtAutoGenInitializer.cxx b/Source/cmQtAutoGenInitializer.cxx index aaf1817..8542206 100644 --- a/Source/cmQtAutoGenInitializer.cxx +++ b/Source/cmQtAutoGenInitializer.cxx @@ -883,6 +883,27 @@ bool cmQtAutoGenInitializer::InitRcc() } } + // Disable zstd if it is not supported + { + std::string const qtFeatureZSTD = "QT_FEATURE_zstd"; + if (this->GenTarget->Target->GetMakefile()->IsDefinitionSet( + qtFeatureZSTD)) { + const auto zstdDef = + this->GenTarget->Target->GetMakefile()->GetSafeDefinition( + qtFeatureZSTD); + const auto zstdVal = cmValue(zstdDef); + if (zstdVal.IsOff()) { + auto const& kw = this->GlobalInitializer->kw(); + auto rccOptions = this->GenTarget->GetSafeProperty(kw.AUTORCC_OPTIONS); + std::string const nozstd = "--no-zstd"; + if (rccOptions.find(nozstd) == std::string::npos) { + rccOptions.append(";" + nozstd + ";"); + } + this->GenTarget->Target->SetProperty(kw.AUTORCC_OPTIONS, rccOptions); + } + } + } + return true; } diff --git a/Tests/RunCMake/Autogen/RccExample.cmake b/Tests/RunCMake/Autogen/RccExample.cmake index 4554eb0..ade0fef 100644 --- a/Tests/RunCMake/Autogen/RccExample.cmake +++ b/Tests/RunCMake/Autogen/RccExample.cmake @@ -9,3 +9,7 @@ target_link_libraries(dummy Qt${with_qt_version}::Core Qt${with_qt_version}::Gui) set_target_properties(dummy PROPERTIES AUTORCC ON) + +if(DEFINED ZSTD_VALUE) + set(QT_FEATURE_zstd ${ZSTD_VALUE}) +endif() diff --git a/Tests/RunCMake/Autogen/RunCMakeTest.cmake b/Tests/RunCMake/Autogen/RunCMakeTest.cmake index d0bbbb0..0036551 100644 --- a/Tests/RunCMake/Autogen/RunCMakeTest.cmake +++ b/Tests/RunCMake/Autogen/RunCMakeTest.cmake @@ -463,4 +463,25 @@ ${make_program_stderr} endblock() endforeach() endif() + + if (QtCore_VERSION VERSION_GREATER_EQUAL 6) + if (RunCMake_GENERATOR MATCHES "Make|Ninja") + foreach(value IN ITEMS ON OFF) + block() + set(RunCMake_TEST_BINARY_DIR + ${RunCMake_BINARY_DIR}/RccNoZTSD-${value}-build) + run_cmake_with_options(RccExample ${RunCMake_TEST_OPTIONS} + -DCMAKE_AUTOGEN_VERBOSE=ON -DZSTD_VALUE=${value}) + if (value STREQUAL "OFF") + set(RunCMake_TEST_EXPECT_stdout "--no-zstd") + else() + set(RunCMake_TEST_NOT_EXPECT_stdout "--no-zstd") + endif() + set(RunCMake_TEST_NO_CLEAN 1) + run_cmake_command(RccNoZTSD-${value}-build ${CMAKE_COMMAND} + --build . --config Debug) + endblock() + endforeach() + endif() + endif() endif () |