diff options
| author | Evan Wilde <etceterawilde@gmail.com> | 2024-01-10 00:33:46 (GMT) |
|---|---|---|
| committer | Evan Wilde <etceterawilde@gmail.com> | 2024-01-11 00:08:16 (GMT) |
| commit | b767917ebb2130f097b7190713605cef481803fa (patch) | |
| tree | 5958fad7ff7ba3a47af3d1e921dd3bea0c6c7d0d | |
| parent | 38234058ff68d3e28b8c4672033dd118127581be (diff) | |
| download | CMake-b767917ebb2130f097b7190713605cef481803fa.zip CMake-b767917ebb2130f097b7190713605cef481803fa.tar.gz CMake-b767917ebb2130f097b7190713605cef481803fa.tar.bz2 | |
Swift/Ninja: Include sources in response file
Unlike C/C++, Swift compiles all sources in a module at once. This can
quickly overwhelm the commandline length limit on Windows, so it is
useful to place the source files in the response file.
Issue: #25572
| -rw-r--r-- | Source/cmNinjaTargetGenerator.cxx | 10 | ||||
| -rw-r--r-- | Source/cmPlaceholderExpander.cxx | 4 | ||||
| -rw-r--r-- | Tests/RunCMake/Swift/ForceResponseFile-check-stdout.txt | 6 |
3 files changed, 14 insertions, 6 deletions
diff --git a/Source/cmNinjaTargetGenerator.cxx b/Source/cmNinjaTargetGenerator.cxx index c493778..24e3e58 100644 --- a/Source/cmNinjaTargetGenerator.cxx +++ b/Source/cmNinjaTargetGenerator.cxx @@ -848,6 +848,14 @@ void cmNinjaTargetGenerator::WriteCompileRule(const std::string& lang, flags = cmStrCat(responseFlag, rule.RspFile); vars.Defines = ""; vars.Includes = ""; + + // Swift consumes all source files in a module at once, which reaches + // command line length limits pretty quickly. Inject source files into the + // response file in this case as well. + if (lang == "Swift") { + rule.RspContent = cmStrCat(rule.RspContent, ' ', vars.Source); + vars.Source = ""; + } } // Tell ninja dependency format so all deps can be loaded into a database @@ -1925,8 +1933,6 @@ void cmNinjaTargetGenerator::WriteSwiftObjectBuildStatement( // For that, we need the "NEW" behavior for CMP0157. Otherwise, we have to // fall back on the old "linker" build. Otherwise, this should be // indistinguishable from the old behavior. - // - // FIXME(#25490): Add response file support to Swift object build step if (sources.empty()) { return; diff --git a/Source/cmPlaceholderExpander.cxx b/Source/cmPlaceholderExpander.cxx index 118017e..11c7485 100644 --- a/Source/cmPlaceholderExpander.cxx +++ b/Source/cmPlaceholderExpander.cxx @@ -48,6 +48,10 @@ std::string& cmPlaceholderExpander::ExpandVariables(std::string& s) } // add the rest of the input expandedInput += s.substr(pos, s.size() - pos); + // remove trailing whitespace + if (!expandedInput.empty() && expandedInput.back() == ' ') { + expandedInput.pop_back(); + } s = expandedInput; return s; diff --git a/Tests/RunCMake/Swift/ForceResponseFile-check-stdout.txt b/Tests/RunCMake/Swift/ForceResponseFile-check-stdout.txt index 576f5a1..3d70f12 100644 --- a/Tests/RunCMake/Swift/ForceResponseFile-check-stdout.txt +++ b/Tests/RunCMake/Swift/ForceResponseFile-check-stdout.txt @@ -1,4 +1,2 @@ -swiftc [^ -]* -c @CMakeFiles/L.dir/L.o.swift.rsp [^ -]* -.*swiftc -emit-library -static -o libL.a @CMakeFiles/L.rsp.* +swiftc -j [0-9]+ -num-threads [0-9]+ -c @CMakeFiles/L.dir/L.o.swift.rsp +.*swiftc -emit-library -static -o libL.a @CMakeFiles/L.rsp |