diff options
| author | Brad King <brad.king@kitware.com> | 2017-04-04 17:14:36 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2017-04-04 17:41:54 (GMT) |
| commit | 1b1ad2a2f4c1fa1369be7f192d1fc1a790aa5503 (patch) | |
| tree | a105e7e7ed4dcf3aef38d8ff611397f68f56f6fe /Modules/CPackNSIS.cmake | |
| parent | 1180fdb6565dcc5f94930a399feed803e7871e46 (diff) | |
| download | CMake-1b1ad2a2f4c1fa1369be7f192d1fc1a790aa5503.zip CMake-1b1ad2a2f4c1fa1369be7f192d1fc1a790aa5503.tar.gz CMake-1b1ad2a2f4c1fa1369be7f192d1fc1a790aa5503.tar.bz2 | |
Revert "CPack/NSIS: Sign the uninstaller"
This reverts commit 09475c29 (CPack/NSIS: Sign the uninstaller,
2017-03-01) and follow-up commit e1ee7b43 (CPack/NSIS: Avoid a race
condition when generating the installer, 2017-03-22). The signing
implementation does not work on Linux for a couple reasons:
* The script tries to run the temporary uninstaller executable,
but of course this cannot be done except on a Windows host.
* The `${NSISDIR}\makensis` file does not exist because `makensis`
is installed elsewhere.
The result is that existing package configurations can break on Linux.
For example, the CPackComponents test fails.
Revert the feature until an alternative implementation approach can be
found.
Diffstat (limited to 'Modules/CPackNSIS.cmake')
| -rw-r--r-- | Modules/CPackNSIS.cmake | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/Modules/CPackNSIS.cmake b/Modules/CPackNSIS.cmake index 37fedf3..18d1871 100644 --- a/Modules/CPackNSIS.cmake +++ b/Modules/CPackNSIS.cmake @@ -133,10 +133,6 @@ # "doc/cmake-@CMake_VERSION_MAJOR@.@CMake_VERSION_MINOR@/cmake.html" # "CMake Help" "https://cmake.org" "CMake Web Site") # -# .. variable:: CPACK_NSIS_SIGN_UNINSTALLER -# -# Specify a command to use for signing the uninstaller. The command will -# be invoked a path to the uninstaller as its only argument. #FIXME we should put NSIS specific code here #FIXME but I'm not doing it because I'm not able to test it... |