diff options
author | Mike Gelfand <mikedld@mikedld.com> | 2020-07-27 22:05:13 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2020-07-28 13:09:43 (GMT) |
commit | 0faedae33531372fb01b158a449d03ecf9e78ee0 (patch) | |
tree | 858d3199e2af149197b86b1ba91042cf55197b5b /Modules/FindBZip2.cmake | |
parent | dde97681e9eabcb6aada1d5d2d90a9b34beddc0f (diff) | |
download | CMake-0faedae33531372fb01b158a449d03ecf9e78ee0.zip CMake-0faedae33531372fb01b158a449d03ecf9e78ee0.tar.gz CMake-0faedae33531372fb01b158a449d03ecf9e78ee0.tar.bz2 |
FindCURL: Fix list index check after search
Fix logic added by commit fc5afbe970 (FindCURL: support COMPONENTS to
check features, 2018-11-28, v3.14.0-rc1~287^2~2).
When searching for particular components and `curl-config` reports one of
the components being searched for first in the list, `find_package` fails.
This is due to the check that treats non-zero index in the list as success
and zero index as failure, while documentation on `list(FIND)` states that
failure to find an element results in return value of -1 (not 0). I'm
hitting this when building cURL with support for HTTP and HTTPS protocols
only, and then trying to `find_package(CURL COMPONENTS HTTP HTTPS)`.
I'm using `if(NOT x EQUAL -1)` check form as it appears to be the most used
throughout the modules.
While fixing this issue I've looked through all the uses of `list(FIND)` in
other modules but wasn't able to find improper use except here.
Diffstat (limited to 'Modules/FindBZip2.cmake')
0 files changed, 0 insertions, 0 deletions