diff options
| author | Brad King <brad.king@kitware.com> | 2018-01-29 13:05:17 (GMT) |
|---|---|---|
| committer | Kitware Robot <kwrobot@kitware.com> | 2018-01-29 13:05:27 (GMT) |
| commit | 92cd3d06772ada13935790d66927ab4663c7d628 (patch) | |
| tree | 2550a2ad9003b47f9029c186aeabdfd6521bc615 /Source/CPack/cmCPackArchiveGenerator.cxx | |
| parent | 18153217e27d2cf560d874313557ec9fa2bcffdb (diff) | |
| parent | c85bb007df37aad9f20355cdf4d7ca9af562cb20 (diff) | |
| download | CMake-92cd3d06772ada13935790d66927ab4663c7d628.zip CMake-92cd3d06772ada13935790d66927ab4663c7d628.tar.gz CMake-92cd3d06772ada13935790d66927ab4663c7d628.tar.bz2 | |
Merge topic 'reduce-temporaries'
c85bb007 Reduce allocation of temporary values on heap.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1698
Diffstat (limited to 'Source/CPack/cmCPackArchiveGenerator.cxx')
| -rw-r--r-- | Source/CPack/cmCPackArchiveGenerator.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Source/CPack/cmCPackArchiveGenerator.cxx b/Source/CPack/cmCPackArchiveGenerator.cxx index 641be38..893b2fc 100644 --- a/Source/CPack/cmCPackArchiveGenerator.cxx +++ b/Source/CPack/cmCPackArchiveGenerator.cxx @@ -132,7 +132,7 @@ int cmCPackArchiveGenerator::PackageComponents(bool ignoreGroup) } } // add the generated package to package file names list - packageFileNames.push_back(packageFileName); + packageFileNames.push_back(std::move(packageFileName)); } // Handle Orphan components (components not belonging to any groups) for (auto& comp : this->Components) { @@ -157,7 +157,7 @@ int cmCPackArchiveGenerator::PackageComponents(bool ignoreGroup) addOneComponentToArchive(archive, &(comp.second)); } // add the generated package to package file names list - packageFileNames.push_back(packageFileName); + packageFileNames.push_back(std::move(packageFileName)); } } } @@ -178,7 +178,7 @@ int cmCPackArchiveGenerator::PackageComponents(bool ignoreGroup) addOneComponentToArchive(archive, &(comp.second)); } // add the generated package to package file names list - packageFileNames.push_back(packageFileName); + packageFileNames.push_back(std::move(packageFileName)); } } return 1; @@ -188,7 +188,7 @@ int cmCPackArchiveGenerator::PackageComponentsAllInOne() { // reset the package file names packageFileNames.clear(); - packageFileNames.push_back(std::string(toplevel)); + packageFileNames.emplace_back(toplevel); packageFileNames[0] += "/"; if (this->IsSet("CPACK_ARCHIVE_FILE_NAME")) { |