diff options
| author | Matthias Maennich <matthias@maennich.net> | 2017-09-20 21:44:34 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2017-09-28 11:23:43 (GMT) |
| commit | f0bab294dcd3f2c4f3be5e491426b5eefb2a9aba (patch) | |
| tree | c50347984fbb1086cd99de7b440dad6f72070f5b /Source/CPack/cmCPackBundleGenerator.cxx | |
| parent | b5d7f5b0e8490a66cdd603e0ee38890426b3b6c4 (diff) | |
| download | CMake-f0bab294dcd3f2c4f3be5e491426b5eefb2a9aba.zip CMake-f0bab294dcd3f2c4f3be5e491426b5eefb2a9aba.tar.gz CMake-f0bab294dcd3f2c4f3be5e491426b5eefb2a9aba.tar.bz2 | |
Convert some leftover loops to C++11 range-based loop
Fix issues diagnosed by clang-tidy [modern-loop-convert]
Signed-off-by: Matthias Maennich <matthias@maennich.net>
Diffstat (limited to 'Source/CPack/cmCPackBundleGenerator.cxx')
| -rw-r--r-- | Source/CPack/cmCPackBundleGenerator.cxx | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/Source/CPack/cmCPackBundleGenerator.cxx b/Source/CPack/cmCPackBundleGenerator.cxx index bbf2a50..f47ca7a 100644 --- a/Source/CPack/cmCPackBundleGenerator.cxx +++ b/Source/CPack/cmCPackBundleGenerator.cxx @@ -213,8 +213,7 @@ int cmCPackBundleGenerator::SignBundle(const std::string& src_dir) cmSystemTools::ExpandListArgument(sign_files, relFiles); // sign the files supplied by the user, ie. frameworks. - for (std::vector<std::string>::iterator it = relFiles.begin(); - it != relFiles.end(); ++it) { + for (auto const& file : relFiles) { std::ostringstream temp_sign_file_cmd; temp_sign_file_cmd << this->GetOption("CPACK_COMMAND_CODESIGN"); temp_sign_file_cmd << " " << sign_parameter << " -s \"" @@ -223,11 +222,11 @@ int cmCPackBundleGenerator::SignBundle(const std::string& src_dir) temp_sign_file_cmd << this->GetOption("CPACK_APPLE_BUNDLE_ID"); temp_sign_file_cmd << " \""; temp_sign_file_cmd << bundle_path; - temp_sign_file_cmd << *it << "\""; + temp_sign_file_cmd << file << "\""; if (!this->RunCommand(temp_sign_file_cmd, &output)) { cmCPackLogger(cmCPackLog::LOG_ERROR, - "Error signing file:" << bundle_path << *it << std::endl + "Error signing file:" << bundle_path << file << std::endl << output << std::endl); return 0; |