summaryrefslogtreecommitdiffstats
path: root/Source/CPack/cmCPackDebGenerator.h
diff options
context:
space:
mode:
authorDaniel Pfeifer <daniel@pfeifer-mail.de>2016-05-26 19:58:51 (GMT)
committerDaniel Pfeifer <daniel@pfeifer-mail.de>2016-05-26 19:58:51 (GMT)
commit618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (patch)
treeabaabfaae8a9f5448d7ee062c757c61254792995 /Source/CPack/cmCPackDebGenerator.h
parentacd8a73044e879286f0cfa24b54497a8307f204b (diff)
downloadCMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.zip
CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.gz
CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.bz2
Pass arguments that are not modified as const&.
Use clang-tidy's performance-unnecessary-value-param checker to find value parameter declarations of expensive to copy types that are not modified inside the function. Ignore findings in kwsys. After applying the fix-its, manually change `const T&` to `T const&`.
Diffstat (limited to 'Source/CPack/cmCPackDebGenerator.h')
-rw-r--r--Source/CPack/cmCPackDebGenerator.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/Source/CPack/cmCPackDebGenerator.h b/Source/CPack/cmCPackDebGenerator.h
index f640ab4..ff34ca5 100644
--- a/Source/CPack/cmCPackDebGenerator.h
+++ b/Source/CPack/cmCPackDebGenerator.h
@@ -49,7 +49,8 @@ protected:
/**
* This method factors out the work done in component packaging case.
*/
- int PackageOnePack(std::string initialToplevel, std::string packageName);
+ int PackageOnePack(std::string const& initialToplevel,
+ std::string const& packageName);
/**
* The method used to package files when component
* install is used. This will create one