diff options
| author | Artur Ryt <artur.ryt@gmail.com> | 2019-03-30 15:11:21 (GMT) |
|---|---|---|
| committer | Artur Ryt <artur.ryt@gmail.com> | 2019-03-30 15:15:05 (GMT) |
| commit | 2d66567dca2a5a80e41493ec0a9d6d86f7d955f5 (patch) | |
| tree | 84468e248f456f65c75a99033ba8073e48ea0f5b /Source/CPack/cpack.cxx | |
| parent | 5bdee3786359b6560eb9ee1d6fab8664feb90db4 (diff) | |
| download | CMake-2d66567dca2a5a80e41493ec0a9d6d86f7d955f5.zip CMake-2d66567dca2a5a80e41493ec0a9d6d86f7d955f5.tar.gz CMake-2d66567dca2a5a80e41493ec0a9d6d86f7d955f5.tar.bz2 | |
Modernize: Prefer .substr in place of .c_str() + int
A lot of temporary/local strings were created out of C-strings
substr can utilize current string size, so in theory be a little
more efficient.
Diffstat (limited to 'Source/CPack/cpack.cxx')
| -rw-r--r-- | Source/CPack/cpack.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/CPack/cpack.cxx b/Source/CPack/cpack.cxx index da9575b..3ceb824 100644 --- a/Source/CPack/cpack.cxx +++ b/Source/CPack/cpack.cxx @@ -82,7 +82,7 @@ int cpackDefinitionArgument(const char* argument, const char* cValue, return 0; } std::string key = value.substr(0, pos); - value = value.c_str() + pos + 1; + value = value.substr(pos + 1); def->Map[key] = value; cmCPack_Log(def->Log, cmCPackLog::LOG_DEBUG, "Set CPack variable: " << key << " to \"" << value << "\"" |