summaryrefslogtreecommitdiffstats
path: root/Source/CPack
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2019-05-02 15:11:28 (GMT)
committerBrad King <brad.king@kitware.com>2019-05-02 18:34:58 (GMT)
commitc85524a94ace9ee400229fede179a605b1c144e3 (patch)
treedd6d26483bef6d6fddd0e5a488762d9e5757e952 /Source/CPack
parentce79364581643700ab88ee4c442e0cf1736c926e (diff)
downloadCMake-c85524a94ace9ee400229fede179a605b1c144e3.zip
CMake-c85524a94ace9ee400229fede179a605b1c144e3.tar.gz
CMake-c85524a94ace9ee400229fede179a605b1c144e3.tar.bz2
Ensure stdin, stdout, and stderr pipes are always open
On non-Windows platforms libuv assumes that file descriptors 0-2 are always used for standard pipes and never for anything else. Otherwise, libuv may re-use one of these descriptors and then fail an assertion when closing it. Similarly, On Windows platforms our ConsoleBuf implementation assumes that the standard handles are always open. If CMake is run with any standard pipes closed, open them with `/dev/null` or `NUL` to satisfy these assumptions. Fixes: #19219
Diffstat (limited to 'Source/CPack')
-rw-r--r--Source/CPack/cpack.cxx1
1 files changed, 1 insertions, 0 deletions
diff --git a/Source/CPack/cpack.cxx b/Source/CPack/cpack.cxx
index 3ceb824..58b9e70 100644
--- a/Source/CPack/cpack.cxx
+++ b/Source/CPack/cpack.cxx
@@ -98,6 +98,7 @@ static void cpackProgressCallback(const std::string& message, float /*unused*/)
// this is CPack.
int main(int argc, char const* const* argv)
{
+ cmSystemTools::EnsureStdPipes();
#if defined(_WIN32) && defined(CMAKE_BUILD_WITH_CMAKE)
// Replace streambuf so we can output Unicode to console
cmsys::ConsoleBuf::Manager consoleOut(std::cout);