diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 19:58:51 (GMT) |
|---|---|---|
| committer | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 19:58:51 (GMT) |
| commit | 618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (patch) | |
| tree | abaabfaae8a9f5448d7ee062c757c61254792995 /Source/CPack | |
| parent | acd8a73044e879286f0cfa24b54497a8307f204b (diff) | |
| download | CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.zip CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.gz CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.bz2 | |
Pass arguments that are not modified as const&.
Use clang-tidy's performance-unnecessary-value-param checker to find
value parameter declarations of expensive to copy types that are not
modified inside the function. Ignore findings in kwsys.
After applying the fix-its, manually change `const T&` to `T const&`.
Diffstat (limited to 'Source/CPack')
| -rw-r--r-- | Source/CPack/cmCPackDebGenerator.cxx | 4 | ||||
| -rw-r--r-- | Source/CPack/cmCPackDebGenerator.h | 3 | ||||
| -rw-r--r-- | Source/CPack/cmCPackRPMGenerator.cxx | 4 | ||||
| -rw-r--r-- | Source/CPack/cmCPackRPMGenerator.h | 3 |
4 files changed, 8 insertions, 6 deletions
diff --git a/Source/CPack/cmCPackDebGenerator.cxx b/Source/CPack/cmCPackDebGenerator.cxx index 7fd76df..1ad4152 100644 --- a/Source/CPack/cmCPackDebGenerator.cxx +++ b/Source/CPack/cmCPackDebGenerator.cxx @@ -50,8 +50,8 @@ int cmCPackDebGenerator::InitializeInternal() return this->Superclass::InitializeInternal(); } -int cmCPackDebGenerator::PackageOnePack(std::string initialTopLevel, - std::string packageName) +int cmCPackDebGenerator::PackageOnePack(std::string const& initialTopLevel, + std::string const& packageName) { int retval = 1; // Begin the archive for this pack diff --git a/Source/CPack/cmCPackDebGenerator.h b/Source/CPack/cmCPackDebGenerator.h index f640ab4..ff34ca5 100644 --- a/Source/CPack/cmCPackDebGenerator.h +++ b/Source/CPack/cmCPackDebGenerator.h @@ -49,7 +49,8 @@ protected: /** * This method factors out the work done in component packaging case. */ - int PackageOnePack(std::string initialToplevel, std::string packageName); + int PackageOnePack(std::string const& initialToplevel, + std::string const& packageName); /** * The method used to package files when component * install is used. This will create one diff --git a/Source/CPack/cmCPackRPMGenerator.cxx b/Source/CPack/cmCPackRPMGenerator.cxx index a4b9a47..9827b70 100644 --- a/Source/CPack/cmCPackRPMGenerator.cxx +++ b/Source/CPack/cmCPackRPMGenerator.cxx @@ -61,8 +61,8 @@ void cmCPackRPMGenerator::AddGeneratedPackageNames() packageFileNames.push_back(fileNames.substr(pos1, pos2 - pos1)); } -int cmCPackRPMGenerator::PackageOnePack(std::string initialToplevel, - std::string packageName) +int cmCPackRPMGenerator::PackageOnePack(std::string const& initialToplevel, + std::string const& packageName) { int retval = 1; // Begin the archive for this pack diff --git a/Source/CPack/cmCPackRPMGenerator.h b/Source/CPack/cmCPackRPMGenerator.h index 40b9bb8..b39f2c2 100644 --- a/Source/CPack/cmCPackRPMGenerator.h +++ b/Source/CPack/cmCPackRPMGenerator.h @@ -54,7 +54,8 @@ protected: /** * This method factors out the work done in component packaging case. */ - int PackageOnePack(std::string initialToplevel, std::string packageName); + int PackageOnePack(std::string const& initialToplevel, + std::string const& packageName); /** * The method used to package files when component * install is used. This will create one |