diff options
| author | Brad King <brad.king@kitware.com> | 2017-10-02 14:06:23 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2017-10-02 14:09:37 (GMT) |
| commit | 39b50975d9b6351ef82bbe16fc0aa521a5410e22 (patch) | |
| tree | ff48f2624498c4625c43322b4ba08f093c817e97 /Source/CPack | |
| parent | a9870c92118e242dfbc079aa1cea6a4214378e14 (diff) | |
| download | CMake-39b50975d9b6351ef82bbe16fc0aa521a5410e22.zip CMake-39b50975d9b6351ef82bbe16fc0aa521a5410e22.tar.gz CMake-39b50975d9b6351ef82bbe16fc0aa521a5410e22.tar.bz2 | |
CPack: Fix .dmg HFS+ creation on macOS APFS hosts
When running `hdiutil create`, specify the HFS+ filesystem explicitly.
Otherwise `hdiutil` may choose a filesystem based on the host. We do
not want to create APFS images for `.dmg` packages because they may not
mount on macOS versions prior to 10.12.
Diffstat (limited to 'Source/CPack')
| -rw-r--r-- | Source/CPack/cmCPackDragNDropGenerator.cxx | 1 | ||||
| -rw-r--r-- | Source/CPack/cmCPackOSXX11Generator.cxx | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/Source/CPack/cmCPackDragNDropGenerator.cxx b/Source/CPack/cmCPackDragNDropGenerator.cxx index 5a173fc..1e1543f 100644 --- a/Source/CPack/cmCPackDragNDropGenerator.cxx +++ b/Source/CPack/cmCPackDragNDropGenerator.cxx @@ -417,6 +417,7 @@ int cmCPackDragNDropGenerator::CreateDMG(const std::string& src_dir, temp_image_command << " -ov"; temp_image_command << " -srcfolder \"" << staging.str() << "\""; temp_image_command << " -volname \"" << cpack_dmg_volume_name << "\""; + temp_image_command << " -fs HFS+"; temp_image_command << " -format " << temp_image_format; temp_image_command << " \"" << temp_image << "\""; diff --git a/Source/CPack/cmCPackOSXX11Generator.cxx b/Source/CPack/cmCPackOSXX11Generator.cxx index e75061e..8d3c40c 100644 --- a/Source/CPack/cmCPackOSXX11Generator.cxx +++ b/Source/CPack/cmCPackOSXX11Generator.cxx @@ -144,8 +144,8 @@ int cmCPackOSXX11Generator::PackageFiles() tmpFile += "/hdiutilOutput.log"; std::ostringstream dmgCmd; dmgCmd << "\"" << this->GetOption("CPACK_INSTALLER_PROGRAM_DISK_IMAGE") - << "\" create -ov -format UDZO -srcfolder \"" << diskImageDirectory - << "\" \"" << packageFileNames[0] << "\""; + << "\" create -ov -fs HFS+ -format UDZO -srcfolder \"" + << diskImageDirectory << "\" \"" << packageFileNames[0] << "\""; cmCPackLogger(cmCPackLog::LOG_VERBOSE, "Compress disk image using command: " << dmgCmd.str() << std::endl); // since we get random dashboard failures with this one |