summaryrefslogtreecommitdiffstats
path: root/Source/CTest/cmCTestGlobalVC.cxx
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2017-02-15 18:58:40 (GMT)
committerBrad King <brad.king@kitware.com>2017-02-16 18:19:26 (GMT)
commitef399f9bc6b8e2ff917a5f2809346fb81fd954ae (patch)
tree329a270ad32f04ebba493ea9abe5486fd74898a1 /Source/CTest/cmCTestGlobalVC.cxx
parentbb4730dc5add8c5ac54b41efa5375189636429f3 (diff)
downloadCMake-ef399f9bc6b8e2ff917a5f2809346fb81fd954ae.zip
CMake-ef399f9bc6b8e2ff917a5f2809346fb81fd954ae.tar.gz
CMake-ef399f9bc6b8e2ff917a5f2809346fb81fd954ae.tar.bz2
ctest_update: Refactor internal APIs to support more failure cases
Thread failure of VC tool commands through more APIs so that we can detect when they fail. Defer updating of the individual VC tool usage the future and just return true from them for now.
Diffstat (limited to 'Source/CTest/cmCTestGlobalVC.cxx')
-rw-r--r--Source/CTest/cmCTestGlobalVC.cxx7
1 files changed, 4 insertions, 3 deletions
diff --git a/Source/CTest/cmCTestGlobalVC.cxx b/Source/CTest/cmCTestGlobalVC.cxx
index 08af179..25294b5 100644
--- a/Source/CTest/cmCTestGlobalVC.cxx
+++ b/Source/CTest/cmCTestGlobalVC.cxx
@@ -102,14 +102,15 @@ void cmCTestGlobalVC::WriteXMLGlobal(cmXMLWriter& xml)
bool cmCTestGlobalVC::WriteXMLUpdates(cmXMLWriter& xml)
{
+ bool result = true;
cmCTestLog(this->CTest, HANDLER_OUTPUT,
" Gathering version information (one . per revision):\n"
" "
<< std::flush);
- this->LoadRevisions();
+ result = this->LoadRevisions() && result;
cmCTestLog(this->CTest, HANDLER_OUTPUT, std::endl);
- this->LoadModifications();
+ result = this->LoadModifications() && result;
this->WriteXMLGlobal(xml);
@@ -119,5 +120,5 @@ bool cmCTestGlobalVC::WriteXMLUpdates(cmXMLWriter& xml)
this->WriteXMLDirectory(xml, di->first, di->second);
}
- return true;
+ return result;
}