diff options
| author | Brad King <brad.king@kitware.com> | 2019-01-23 13:16:55 (GMT) |
|---|---|---|
| committer | Kitware Robot <kwrobot@kitware.com> | 2019-01-23 13:17:49 (GMT) |
| commit | a7f5cd45e135dd51d67176fc40e2d769ac5f7db8 (patch) | |
| tree | 677ad083ef4b1c9f7ca182ef6a29863841bf2169 /Source/QtDialog | |
| parent | 22893baed1556420b93c4f3a62b4c450ac354040 (diff) | |
| parent | 5a0784ddea62ee653a3a1199d4ff2140868d2c1d (diff) | |
| download | CMake-a7f5cd45e135dd51d67176fc40e2d769ac5f7db8.zip CMake-a7f5cd45e135dd51d67176fc40e2d769ac5f7db8.tar.gz CMake-a7f5cd45e135dd51d67176fc40e2d769ac5f7db8.tar.bz2 | |
Merge topic 'tidy-pass-by-value'
5a0784ddea clang-tidy: Pass by value
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2836
Diffstat (limited to 'Source/QtDialog')
| -rw-r--r-- | Source/QtDialog/QCMakeWidgets.cxx | 5 | ||||
| -rw-r--r-- | Source/QtDialog/QCMakeWidgets.h | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/Source/QtDialog/QCMakeWidgets.cxx b/Source/QtDialog/QCMakeWidgets.cxx index b544b86..eab418f 100644 --- a/Source/QtDialog/QCMakeWidgets.cxx +++ b/Source/QtDialog/QCMakeWidgets.cxx @@ -7,10 +7,11 @@ #include <QFileInfo> #include <QResizeEvent> #include <QToolButton> +#include <utility> -QCMakeFileEditor::QCMakeFileEditor(QWidget* p, const QString& var) +QCMakeFileEditor::QCMakeFileEditor(QWidget* p, QString var) : QLineEdit(p) - , Variable(var) + , Variable(std::move(var)) { this->ToolButton = new QToolButton(this); this->ToolButton->setText("..."); diff --git a/Source/QtDialog/QCMakeWidgets.h b/Source/QtDialog/QCMakeWidgets.h index e63c197..5d2368e 100644 --- a/Source/QtDialog/QCMakeWidgets.h +++ b/Source/QtDialog/QCMakeWidgets.h @@ -18,7 +18,7 @@ class QCMakeFileEditor : public QLineEdit { Q_OBJECT public: - QCMakeFileEditor(QWidget* p, const QString& var); + QCMakeFileEditor(QWidget* p, QString var); protected slots: virtual void chooseFile() = 0; signals: |