summaryrefslogtreecommitdiffstats
path: root/Source/QtDialog
diff options
context:
space:
mode:
authorMatthew Woehlke <matthew.woehlke@kitware.com>2021-01-15 16:24:16 (GMT)
committerMatthew Woehlke <matthew.woehlke@kitware.com>2021-01-15 16:24:16 (GMT)
commit8aebd159fc2941b600b08535cf5ced805c185e87 (patch)
tree58d8293a5129576fae2a35f31153e520266ec884 /Source/QtDialog
parent0bc327a79ca4d875df6084d490c4fd7da315a33a (diff)
downloadCMake-8aebd159fc2941b600b08535cf5ced805c185e87.zip
CMake-8aebd159fc2941b600b08535cf5ced805c185e87.tar.gz
CMake-8aebd159fc2941b600b08535cf5ced805c185e87.tar.bz2
CMake GUI: Don't use QToolButton
Replace QToolButton instances with QPushButton. QToolButton is only meant to be used on tool bars and some other special situations. Worse, we had a mix of QToolButton and QPushButton for things that clearly should be using the same widget. This will improve visual consistency and may fix some rendering issues.
Diffstat (limited to 'Source/QtDialog')
-rw-r--r--Source/QtDialog/CMakeSetupDialog.cxx1
-rw-r--r--Source/QtDialog/CMakeSetupDialog.ui10
-rw-r--r--Source/QtDialog/EnvironmentDialog.ui10
3 files changed, 4 insertions, 17 deletions
diff --git a/Source/QtDialog/CMakeSetupDialog.cxx b/Source/QtDialog/CMakeSetupDialog.cxx
index 7c4d96b..0313088 100644
--- a/Source/QtDialog/CMakeSetupDialog.cxx
+++ b/Source/QtDialog/CMakeSetupDialog.cxx
@@ -22,7 +22,6 @@
#include <QShortcut>
#include <QStatusBar>
#include <QString>
-#include <QToolButton>
#include <QUrl>
#include <QVector>
diff --git a/Source/QtDialog/CMakeSetupDialog.ui b/Source/QtDialog/CMakeSetupDialog.ui
index a5c35b1..25d1cbe 100644
--- a/Source/QtDialog/CMakeSetupDialog.ui
+++ b/Source/QtDialog/CMakeSetupDialog.ui
@@ -208,7 +208,7 @@
</widget>
</item>
<item>
- <widget class="QToolButton" name="AddEntry">
+ <widget class="QPushButton" name="AddEntry">
<property name="toolTip">
<string>Add New Entry</string>
</property>
@@ -219,13 +219,10 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Plus16.png</normaloff>:/Icons/Plus16.png</iconset>
</property>
- <property name="toolButtonStyle">
- <enum>Qt::ToolButtonTextBesideIcon</enum>
- </property>
</widget>
</item>
<item>
- <widget class="QToolButton" name="RemoveEntry">
+ <widget class="QPushButton" name="RemoveEntry">
<property name="toolTip">
<string>Remove Selected Entries</string>
</property>
@@ -236,9 +233,6 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Delete16.png</normaloff>:/Icons/Delete16.png</iconset>
</property>
- <property name="toolButtonStyle">
- <enum>Qt::ToolButtonTextBesideIcon</enum>
- </property>
</widget>
</item>
<item>
diff --git a/Source/QtDialog/EnvironmentDialog.ui b/Source/QtDialog/EnvironmentDialog.ui
index dea7624..c0b5e9d 100644
--- a/Source/QtDialog/EnvironmentDialog.ui
+++ b/Source/QtDialog/EnvironmentDialog.ui
@@ -46,7 +46,7 @@
</spacer>
</item>
<item>
- <widget class="QToolButton" name="AddEntry">
+ <widget class="QPushButton" name="AddEntry">
<property name="text">
<string>&amp;Add Entry</string>
</property>
@@ -54,13 +54,10 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Plus16.png</normaloff>:/Icons/Plus16.png</iconset>
</property>
- <property name="toolButtonStyle">
- <enum>Qt::ToolButtonTextBesideIcon</enum>
- </property>
</widget>
</item>
<item>
- <widget class="QToolButton" name="RemoveEntry">
+ <widget class="QPushButton" name="RemoveEntry">
<property name="text">
<string>&amp;Remove Entry</string>
</property>
@@ -68,9 +65,6 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Delete16.png</normaloff>:/Icons/Delete16.png</iconset>
</property>
- <property name="toolButtonStyle">
- <enum>Qt::ToolButtonTextBesideIcon</enum>
- </property>
</widget>
</item>
</layout>