summaryrefslogtreecommitdiffstats
path: root/Source/cmCMakeMinimumRequired.cxx
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2009-09-11 12:18:15 (GMT)
committerBrad King <brad.king@kitware.com>2009-09-11 12:18:15 (GMT)
commitb41a548d86f8989e790f0150abd3eb337e8c03d0 (patch)
treee22e5e910e1b5769e8bcec6fa20ac703df013e55 /Source/cmCMakeMinimumRequired.cxx
parente0df0495e5b313e1f017ebb938c4522db6d5b89c (diff)
downloadCMake-b41a548d86f8989e790f0150abd3eb337e8c03d0.zip
CMake-b41a548d86f8989e790f0150abd3eb337e8c03d0.tar.gz
CMake-b41a548d86f8989e790f0150abd3eb337e8c03d0.tar.bz2
Add parentheses around '&&' between '||' for gcc
The GNU compiler warns about possible operator precedence mistakes and asks for explicit parentheses (-Wparentheses). We add the parentheses to silence the warning. This also fixes one real logic error in the find_package() implementation by correcting expression evaluation order.
Diffstat (limited to 'Source/cmCMakeMinimumRequired.cxx')
-rw-r--r--Source/cmCMakeMinimumRequired.cxx14
1 files changed, 7 insertions, 7 deletions
diff --git a/Source/cmCMakeMinimumRequired.cxx b/Source/cmCMakeMinimumRequired.cxx
index 49860c5..f3fad85 100644
--- a/Source/cmCMakeMinimumRequired.cxx
+++ b/Source/cmCMakeMinimumRequired.cxx
@@ -87,12 +87,12 @@ bool cmCMakeMinimumRequired
}
// Compare the version numbers.
- if(current_major < required_major ||
- current_major == required_major &&
- current_minor < required_minor ||
- current_major == required_major &&
- current_minor == required_minor &&
- current_patch < required_patch)
+ if((current_major < required_major) ||
+ (current_major == required_major &&
+ current_minor < required_minor) ||
+ (current_major == required_major &&
+ current_minor == required_minor &&
+ current_patch < required_patch))
{
// The current version is too low.
cmOStringStream e;
@@ -110,7 +110,7 @@ bool cmCMakeMinimumRequired
return false;
}
- if (required_major < 2 || required_major == 2 && required_minor < 4)
+ if (required_major < 2 || (required_major == 2 && required_minor < 4))
{
this->Makefile->SetPolicyVersion("2.4");
}