summaryrefslogtreecommitdiffstats
path: root/Source/cmCTest.cxx
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2016-12-12 19:21:27 (GMT)
committerCMake Topic Stage <kwrobot@kitware.com>2016-12-12 19:21:27 (GMT)
commitd1d11f73a1a7d2d2ad949e9a4ad1c65f155f3cfa (patch)
tree7a8b2cc1b50622473fc47fff676e68a3d52b147b /Source/cmCTest.cxx
parent55ff3c78b3d0d08cdbc6dea700e2add6a64c988b (diff)
parentb932cd429800bb24d71e1d60f954fe4df2d1eb5c (diff)
downloadCMake-d1d11f73a1a7d2d2ad949e9a4ad1c65f155f3cfa.zip
CMake-d1d11f73a1a7d2d2ad949e9a4ad1c65f155f3cfa.tar.gz
CMake-d1d11f73a1a7d2d2ad949e9a4ad1c65f155f3cfa.tar.bz2
Merge topic 'clang-tidy'
b932cd42 clang-tidy: apply misc-redundant-expression fixes 88da3d68 clang-tidy: apply misc-suspicious-string-compare fixes 58c66393 clang-tidy: apply readability-static-definition-in-anonymous-namespace fixes 85bfddda clang-tidy: apply readability-redundant-control-flow fixes 2988abd9 clang-tidy: apply modernize-use-bool-literals fixes a74e6893 clang-tidy: apply readability-redundant-string-init fixes cac529dd clang-tidy: apply performance-faster-string-find fixes 7c9db8f8 clang-tidy: apply performance-unnecessary-value-param fixes
Diffstat (limited to 'Source/cmCTest.cxx')
-rw-r--r--Source/cmCTest.cxx6
1 files changed, 3 insertions, 3 deletions
diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index 1527b30..559275e 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -1509,7 +1509,7 @@ bool cmCTest::SubmitExtraFiles(const VectorOfStrings& files)
bool cmCTest::SubmitExtraFiles(const char* cfiles)
{
if (!cfiles) {
- return 1;
+ return true;
}
VectorOfStrings files;
@@ -1518,7 +1518,7 @@ bool cmCTest::SubmitExtraFiles(const char* cfiles)
files = cmSystemTools::SplitString(cfiles, ';');
if (files.empty()) {
- return 1;
+ return true;
}
return this->SubmitExtraFiles(files);
@@ -2787,7 +2787,7 @@ bool cmCTest::CompressString(std::string& str)
strm.next_out = &out[0];
ret = deflate(&strm, Z_FINISH);
- if (ret == Z_STREAM_ERROR || ret != Z_STREAM_END) {
+ if (ret != Z_STREAM_END) {
cmCTestLog(this, ERROR_MESSAGE, "Error during gzip compression."
<< std::endl);
return false;