diff options
author | Brad King <brad.king@kitware.com> | 2018-09-06 17:10:55 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2018-09-07 12:57:51 (GMT) |
commit | fc7e4d1ed85370d03acbd62bc753cced3550752b (patch) | |
tree | 25e5d5719b2da65398e7d2f0fbc4cb490e4428ff /Source/cmComputeLinkDepends.h | |
parent | f782759ed0997eb3d71e1187a829da62668ed5d2 (diff) | |
download | CMake-fc7e4d1ed85370d03acbd62bc753cced3550752b.zip CMake-fc7e4d1ed85370d03acbd62bc753cced3550752b.tar.gz CMake-fc7e4d1ed85370d03acbd62bc753cced3550752b.tar.bz2 |
cmLinkItem: Convert to a "sum type" over a string and target pointer
Avoid exposing the item name implicitly as std::string. When the item
is a target, avoid storing a second copy of its name.
Most link item construction is paired with calls to `FindTargetToLink`
to get the possible target pointer. Rename these methods to
`ResolveLinkItem` and refactor them to construct the entire item.
Diffstat (limited to 'Source/cmComputeLinkDepends.h')
-rw-r--r-- | Source/cmComputeLinkDepends.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Source/cmComputeLinkDepends.h b/Source/cmComputeLinkDepends.h index dd0e029..fb3a02f 100644 --- a/Source/cmComputeLinkDepends.h +++ b/Source/cmComputeLinkDepends.h @@ -79,8 +79,7 @@ private: void AddDirectLinkEntries(); template <typename T> void AddLinkEntries(int depender_index, std::vector<T> const& libs); - cmGeneratorTarget const* FindTargetToLink(int depender_index, - const std::string& name); + cmLinkItem ResolveLinkItem(int depender_index, const std::string& name); // One entry for each unique item. std::vector<LinkEntry> EntryList; |