summaryrefslogtreecommitdiffstats
path: root/Source/cmDefinePropertyCommand.cxx
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2019-09-27 17:06:56 (GMT)
committerBrad King <brad.king@kitware.com>2019-09-27 18:15:00 (GMT)
commit156b56480a786db4d967bde5eb6d5edee56a27d0 (patch)
tree903d26d8951dc566313065625f52052c04711485 /Source/cmDefinePropertyCommand.cxx
parent26a0e200e5f4abe8268235c9fdb23a2612a1b3b1 (diff)
downloadCMake-156b56480a786db4d967bde5eb6d5edee56a27d0.zip
CMake-156b56480a786db4d967bde5eb6d5edee56a27d0.tar.gz
CMake-156b56480a786db4d967bde5eb6d5edee56a27d0.tar.bz2
Makefiles: Revert "Make build root targets ... recursive"
Revert the main logic change from commit 827da1119e (Makefiles: Make build root targets "all", "clean" and "preinstall" recursive, 2019-05-17, v3.15.0-rc1~96^2~2) for the "all" and "preinstall" targets. The commit cleaned up the Makefile generator to use the same logic for the "all" target in the top-level directory as for subdirectories. It exposed a long-existing bug that caused the "all" target in a subdirectory to include the "all" targets from sub-subdirectories even if they are marked `EXCLUDE_FROM_ALL`. The `Tests/SubDir` test should fail but the problem is currently covered up by another bug introduced by commit dc6888573d (Pass EXCLUDE_FROM_ALL from directory to targets, 2019-01-15, v3.14.0-rc1~83^2) that causes the "all" targets in `EXCLUDE_FROM_ALL` subdirectories to be empty. Revert the top-level "all" and "preinstall" targets to the old approach to prepare to fix the latter bug without exposing the long-existing bug at the top-level. Leave the "clean" target in the new approach because it does not honor `EXCLUDE_FROM_ALL` anyway. Issue: #19753
Diffstat (limited to 'Source/cmDefinePropertyCommand.cxx')
0 files changed, 0 insertions, 0 deletions