diff options
author | Alex Neundorf <neundorf@kde.org> | 2012-09-30 15:53:01 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2012-11-06 16:54:39 (GMT) |
commit | e74ff7c29fc764af63ed3f5195ecc64730c07939 (patch) | |
tree | 9aca0b2d414e299638ecc803dddc7c6d438e9749 /Source/cmDependsC.cxx | |
parent | ecc77d09b8996b59bf22bc36e06fa4bb52d665ee (diff) | |
download | CMake-e74ff7c29fc764af63ed3f5195ecc64730c07939.zip CMake-e74ff7c29fc764af63ed3f5195ecc64730c07939.tar.gz CMake-e74ff7c29fc764af63ed3f5195ecc64730c07939.tar.bz2 |
cmDepends: allow multiple dependees per depender
This patch is heavily inspired by Michael Wild.
The interfaces cmDepends::Write and cmDepends::WriteDependencies where
extended to allow multiple dependees (sources) per depender (object).
cmDepends::Write first collect all dependencies into a std::set before
passing it to cmDepends::WriteDependencies.
cmDependsC::WriteDependencies also first collects all explicit and
implicit dependencies into a std::set and only then writes
depend.{internal,make}. The implementation of cmDependsFortran simply
loops over all sources and proceeds as before, whereas the cmDependsJava
implementation is as trivial as before.
This is for preventing exponential growth of depend.{internal,make} in
the next commit which fixes dependency-vector erasure in
cmDepends::CheckDependencies.
Inspired-by: Michael Wild <themiwi@users.sourceforge.net>
Diffstat (limited to 'Source/cmDependsC.cxx')
-rw-r--r-- | Source/cmDependsC.cxx | 33 |
1 files changed, 21 insertions, 12 deletions
diff --git a/Source/cmDependsC.cxx b/Source/cmDependsC.cxx index 6d4ac23..43b7b8a 100644 --- a/Source/cmDependsC.cxx +++ b/Source/cmDependsC.cxx @@ -98,16 +98,18 @@ cmDependsC::~cmDependsC() } //---------------------------------------------------------------------------- -bool cmDependsC::WriteDependencies(const char *src, const char *obj, - std::ostream& makeDepends, std::ostream& internalDepends) +bool cmDependsC::WriteDependencies(const std::set<std::string>& sources, + const std::string& obj, + std::ostream& makeDepends, + std::ostream& internalDepends) { // Make sure this is a scanning instance. - if(!src || src[0] == '\0') + if(sources.empty() || sources.begin()->empty()) { cmSystemTools::Error("Cannot scan dependencies without a source file."); return false; } - if(!obj || obj[0] == '\0') + if(obj.empty()) { cmSystemTools::Error("Cannot scan dependencies without an object file."); return false; @@ -134,12 +136,18 @@ bool cmDependsC::WriteDependencies(const char *src, const char *obj, if (!haveDeps) { // Walk the dependency graph starting with the source file. - bool first = true; - UnscannedEntry root; - root.FileName = src; - this->Unscanned.push(root); + int srcFiles = (int)sources.size(); this->Encountered.clear(); - this->Encountered.insert(src); + + for(std::set<std::string>::const_iterator srcIt = sources.begin(); + srcIt != sources.end(); ++srcIt) + { + UnscannedEntry root; + root.FileName = *srcIt; + this->Unscanned.push(root); + this->Encountered.insert(*srcIt); + } + std::set<cmStdString> scanned; // Use reserve to allocate enough memory for tempPathStr @@ -155,7 +163,8 @@ bool cmDependsC::WriteDependencies(const char *src, const char *obj, // If not a full path, find the file in the include path. std::string fullName; - if(first || cmSystemTools::FileIsFullPath(current.FileName.c_str())) + if((srcFiles>0) + || cmSystemTools::FileIsFullPath(current.FileName.c_str())) { if(cmSystemTools::FileExists(current.FileName.c_str(), true)) { @@ -260,7 +269,7 @@ bool cmDependsC::WriteDependencies(const char *src, const char *obj, } } - first = false; + srcFiles--; } } @@ -269,7 +278,7 @@ bool cmDependsC::WriteDependencies(const char *src, const char *obj, // convert the dependencies to paths relative to the home output // directory. We must do the same here. internalDepends << obj << std::endl; - for(std::set<cmStdString>::iterator i=dependencies.begin(); + for(std::set<cmStdString>::const_iterator i=dependencies.begin(); i != dependencies.end(); ++i) { makeDepends << obj << ": " << |