summaryrefslogtreecommitdiffstats
path: root/Source/cmFileCopier.cxx
diff options
context:
space:
mode:
authorSebastian Holtermann <sebholt@xwmw.org>2019-08-23 10:21:46 (GMT)
committerSebastian Holtermann <sebholt@xwmw.org>2019-08-23 16:52:33 (GMT)
commit3b2b02825d88a045d08b8295927652cbcff408a8 (patch)
tree576d53beef55b9da82fe7e22187efb023c12d59d /Source/cmFileCopier.cxx
parent19612dffd27d90d73e3b7cff9cbba241294c17e9 (diff)
downloadCMake-3b2b02825d88a045d08b8295927652cbcff408a8.zip
CMake-3b2b02825d88a045d08b8295927652cbcff408a8.tar.gz
CMake-3b2b02825d88a045d08b8295927652cbcff408a8.tar.bz2
Source sweep: Replace std::ostringstream when used with a single append
This replaces `std::ostringstream`, when it is written to only once. If the single written argument was numeric, `std::to_string` is used instead. Otherwise, the single written argument is used directly instead of the `std::ostringstream::str()` invocation.
Diffstat (limited to 'Source/cmFileCopier.cxx')
-rw-r--r--Source/cmFileCopier.cxx5
1 files changed, 2 insertions, 3 deletions
diff --git a/Source/cmFileCopier.cxx b/Source/cmFileCopier.cxx
index 3156c95..38a6080 100644
--- a/Source/cmFileCopier.cxx
+++ b/Source/cmFileCopier.cxx
@@ -446,9 +446,8 @@ bool cmFileCopier::Install(const std::string& fromFile,
const std::string& toFile)
{
if (fromFile.empty()) {
- std::ostringstream e;
- e << "INSTALL encountered an empty string input file name.";
- this->Status.SetError(e.str());
+ this->Status.SetError(
+ "INSTALL encountered an empty string input file name.");
return false;
}