summaryrefslogtreecommitdiffstats
path: root/Source/cmGlobalGenerator.cxx
diff options
context:
space:
mode:
authorRolf Eike Beer <eike@sf-mail.de>2019-08-18 12:22:11 (GMT)
committerRolf Eike Beer <eike@sf-mail.de>2019-08-18 12:22:11 (GMT)
commitda26b3be8948471dd2320d1e44af9eb5dfaa0f6a (patch)
treed3e861dde3c600440154767d88a90a13af5abc01 /Source/cmGlobalGenerator.cxx
parent06e32a089df03c158eaee7525de3ac1be25d8136 (diff)
downloadCMake-da26b3be8948471dd2320d1e44af9eb5dfaa0f6a.zip
CMake-da26b3be8948471dd2320d1e44af9eb5dfaa0f6a.tar.gz
CMake-da26b3be8948471dd2320d1e44af9eb5dfaa0f6a.tar.bz2
avoid adding multiple consecutive string literals to std::string
While at it change some single character additions to be of type char.
Diffstat (limited to 'Source/cmGlobalGenerator.cxx')
-rw-r--r--Source/cmGlobalGenerator.cxx11
1 files changed, 4 insertions, 7 deletions
diff --git a/Source/cmGlobalGenerator.cxx b/Source/cmGlobalGenerator.cxx
index 86fcae0..5e5ec4e 100644
--- a/Source/cmGlobalGenerator.cxx
+++ b/Source/cmGlobalGenerator.cxx
@@ -522,7 +522,7 @@ void cmGlobalGenerator::EnableLanguage(
if (!this->ConfiguredFilesPath.empty()) {
rootBin = this->ConfiguredFilesPath;
}
- rootBin += "/";
+ rootBin += '/';
rootBin += cmVersion::GetCMakeVersion();
// set the dir for parent files so they can be used by modules
@@ -1278,8 +1278,7 @@ void cmGlobalGenerator::Configure()
const char* logs[] = { "CMakeOutput.log", "CMakeError.log", nullptr };
for (const char** log = logs; *log; ++log) {
std::string f = this->CMakeInstance->GetHomeOutputDirectory();
- f += "/CMakeFiles";
- f += "/";
+ f += "/CMakeFiles/";
f += *log;
if (cmSystemTools::FileExists(f)) {
msg << "\nSee also \"" << f << "\".";
@@ -2853,8 +2852,7 @@ void cmGlobalGenerator::CheckRuleHashes()
#if !defined(CMAKE_BOOTSTRAP)
std::string home = this->GetCMakeInstance()->GetHomeOutputDirectory();
std::string pfile = home;
- pfile += "/CMakeFiles";
- pfile += "/CMakeRuleHashes.txt";
+ pfile += "/CMakeFiles/CMakeRuleHashes.txt";
this->CheckRuleHashes(pfile, home);
this->WriteRuleHashes(pfile);
#endif
@@ -2931,8 +2929,7 @@ void cmGlobalGenerator::WriteSummary()
{
// Record all target directories in a central location.
std::string fname = this->CMakeInstance->GetHomeOutputDirectory();
- fname += "/CMakeFiles";
- fname += "/TargetDirectories.txt";
+ fname += "/CMakeFiles/TargetDirectories.txt";
cmGeneratedFileStream fout(fname);
for (cmLocalGenerator* lg : this->LocalGenerators) {