summaryrefslogtreecommitdiffstats
path: root/Source/cmGlobalGenerator.cxx
diff options
context:
space:
mode:
authorSebastian Holtermann <sebholt@xwmw.org>2018-07-11 11:29:49 (GMT)
committerSebastian Holtermann <sebholt@xwmw.org>2018-07-11 11:29:49 (GMT)
commitc6a8002827e0d23d27906ea5760a67981660f453 (patch)
treeaa77bda1d24e121983be017fde21ad888c016e7f /Source/cmGlobalGenerator.cxx
parent0723eada4dcdb4332a63c56e1df6160f19cb9ff5 (diff)
downloadCMake-c6a8002827e0d23d27906ea5760a67981660f453.zip
CMake-c6a8002827e0d23d27906ea5760a67981660f453.tar.gz
CMake-c6a8002827e0d23d27906ea5760a67981660f453.tar.bz2
Autogen: Improve error detection during configuration
cmQtAutoGenInitializer::InitCustomTargets and cmQtAutoGenInitializer::SetupCustomTargets now return their success value which gets evaluated and passed on by the caller (cmGlobalGenerator). Checks for the existance of the moc/uic/rcc binaries have been introduces in cmQtAutoGenInitializer. Additionally they get called once with a "-h" argument to determine if they're functional. This way any binary-not-found problem is caught during the configuration phase.
Diffstat (limited to 'Source/cmGlobalGenerator.cxx')
-rw-r--r--Source/cmGlobalGenerator.cxx8
1 files changed, 6 insertions, 2 deletions
diff --git a/Source/cmGlobalGenerator.cxx b/Source/cmGlobalGenerator.cxx
index 2872831..c401844 100644
--- a/Source/cmGlobalGenerator.cxx
+++ b/Source/cmGlobalGenerator.cxx
@@ -1318,7 +1318,9 @@ bool cmGlobalGenerator::Compute()
// the AUTOMOC, AUTOUIC or AUTORCC property set
auto autogenInits = this->CreateQtAutoGenInitializers();
for (auto& autoGen : autogenInits) {
- autoGen->InitCustomTargets();
+ if (!autoGen->InitCustomTargets()) {
+ return false;
+ }
}
#endif
@@ -1341,7 +1343,9 @@ bool cmGlobalGenerator::Compute()
#ifdef CMAKE_BUILD_WITH_CMAKE
for (auto& autoGen : autogenInits) {
- autoGen->SetupCustomTargets();
+ if (!autoGen->SetupCustomTargets()) {
+ return false;
+ }
autoGen.reset(nullptr);
}
autogenInits.clear();